dyn: Use nil as default location instead of empty slice (#2742)

## Why
- This starts to matter once we replace dynassert with regular assert
#2737
- We agreed before to use nils consistently instead of empty slices.

Author: denik

bundle/config/generate/job.go

@@ -34,7 +34,7 @@ func ConvertJobToValue(job *jobs.Job) (dyn.Value, error) {
 				"name":    dyn.NewValue(parameter.Name, []dyn.Location{{Line: 0}}), // We use Line: 0 to ensure that the name goes first.
 				"default": dyn.NewValue(parameter.Default, []dyn.Location{{Line: 1}}),
 			}
-			params = append(params, dyn.NewValue(p, []dyn.Location{}))
+			params = append(params, dyn.V(p))
 		}
 
 		value["parameters"] = dyn.NewValue(params, []dyn.Location{{Line: jobOrder.Get("parameters")}})

bundle/config/mutator/python/apply_python_output_test.go

@@ -254,9 +254,9 @@ func TestCreateOverrideVisitor_omitempty(t *testing.T) {
 }
 
 func mapOf(key string, value dyn.Value) dyn.Value {
-	return dyn.NewValue(map[string]dyn.Value{
+	return dyn.V(map[string]dyn.Value{
 		key: value,
-	}, []dyn.Location{})
+	})
 }
 
 func mapOf2(key1 string, value1 dyn.Value, key2 string, value2 dyn.Value) dyn.Value {
@@ -267,5 +267,5 @@ func mapOf2(key1 string, value1 dyn.Value, key2 string, value2 dyn.Value) dyn.Va
 }
 
 func emptyMap() dyn.Value {
-	return dyn.NewValue(map[string]dyn.Value{}, []dyn.Location{})
+	return dyn.V(map[string]dyn.Value{})
 }

bundle/config/mutator/python/python_locations_test.go

@@ -22,12 +22,11 @@ func TestMergeLocations(t *testing.T) {
 
 	input := dyn.NewValue(
 		map[string]dyn.Value{
-			"foo": dyn.NewValue(
+			"foo": dyn.V(
 				map[string]dyn.Value{
 					"baz": dyn.NewValue("baz", []dyn.Location{yamlLocation}),
 					"qux": dyn.NewValue("baz", []dyn.Location{generatedLocation, yamlLocation}),
 				},
-				[]dyn.Location{},
 			),
 			"bar": dyn.NewValue("baz", []dyn.Location{generatedLocation}),
 		},

bundle/config/root.go

@@ -555,7 +555,7 @@ func (r Root) GetLocation(path string) dyn.Location {
 func (r Root) GetLocations(path string) []dyn.Location {
 	v, err := dyn.Get(r.value, path)
 	if err != nil {
-		return []dyn.Location{}
+		return nil
 	}
 	return v.Locations()
 }

bundle/config/validate/unique_resource_keys.go

@@ -59,8 +59,8 @@ func (m *uniqueResourceKeys) Apply(ctx context.Context, b *bundle.Bundle) diag.D
 			m, ok := resourceMetadata[k]
 			if !ok {
 				m = &metadata{
-					paths:     []dyn.Path{},
-					locations: []dyn.Location{},
+					paths:     nil,
+					locations: nil,
 				}
 			}
 

libs/dyn/mapping_test.go

@@ -125,8 +125,8 @@ func TestMappingSetLoc(t *testing.T) {
 func TestMappingKeysValues(t *testing.T) {
 	// Configure mapping
 	var m dyn.Mapping
-	m.SetLoc("key1", []dyn.Location{}, dyn.V("foo"))
-	m.SetLoc("key2", []dyn.Location{}, dyn.V("bar"))
+	m.SetLoc("key1", nil, dyn.V("foo"))
+	m.SetLoc("key2", nil, dyn.V("bar"))
 
 	// Confirm keys
 	keys := m.Keys()

libs/dyn/value.go

@@ -32,7 +32,7 @@ var NilValue = Value{
 
 // V constructs a new Value with the given value.
 func V(v any) Value {
-	return NewValue(v, []Location{})
+	return NewValue(v, nil)
 }
 
 // NewValue constructs a new Value with the given value and location.

libs/dyn/yamlsaver/utils_test.go

@@ -32,25 +32,22 @@ func TestConvertToMap(t *testing.T) {
 	result, err := ConvertToMapValue(v, nil, []string{"format"}, map[string]dyn.Value{})
 	assert.NoError(t, err)
 	assert.Equal(t, dyn.V(map[string]dyn.Value{
-		"list": dyn.NewValue(
+		"list": dyn.V(
 			[]dyn.Value{
 				dyn.V("a"),
 				dyn.V("b"),
 				dyn.V("c"),
 			},
-			[]dyn.Location{},
 		),
-		"long_name_field": dyn.NewValue("long name goes here", []dyn.Location{}),
-		"map": dyn.NewValue(
+		"long_name_field": dyn.V("long name goes here"),
+		"map": dyn.V(
 			map[string]dyn.Value{
 				"key1": dyn.V("value1"),
 				"key2": dyn.V("value2"),
 			},
-			[]dyn.Location{},
 		),
-		"name": dyn.NewValue(
+		"name": dyn.V(
 			"test",
-			[]dyn.Location{},
 		),
 	}), result)
 }