Skip to content

Commit 3cc81f3

Browse files
Always use line feed for newlines in acceptance tests (#2865)
## Why Based on feedback in #2720 (comment). We should always treat new lines in acceptance tests in windows as `\n`. This is important because the characters itself can be semantically important in tests. For example, an additional `\r` character in windows changes the upload payload if you are uploading the file's content to a workspace. ## Tests Existing workspace-io test should no longer need a custom override for windows.
1 parent e1c15fb commit 3cc81f3

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

acceptance/.gitattributes

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# We should always treat new lines in text files acceptance tests in windows as \n.
2+
# This is important because the characters itself can be semantically important in tests.
3+
# For example, an additional \r character in windows changes the upload payload if you are
4+
# uploading the file's content to a workspace.
5+
*.txt text eol=lf
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
# hello, world\n base64 encoded in unix
1+
# hello, world\n base64 encoded
22
[[Repls]]
33
Old = "aGVsbG8sIHdvcmxkCg=="
44
New = "[HELLO-WORLD]"
5-
6-
# hello, world\n base64 encoded in windows
7-
[[Repls]]
8-
Old = "aGVsbG8sIHdvcmxkDQo="
9-
New = "[HELLO-WORLD]"

0 commit comments

Comments
 (0)