Skip to content

Commit f226e6f

Browse files
committed
refactor(dpp): use if-let instead of unwrap for validation error extraction
Replace is_valid() check + unwrap() with if-let pattern to eliminate fragile coupling to ValidationResult internals. Addresses CodeRabbit nitpick on PR #3138.
1 parent 0ac66dd commit f226e6f

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

  • packages/rs-dpp/src/state_transition/state_transitions/identity/identity_topup_transition/v0

packages/rs-dpp/src/state_transition/state_transitions/identity/identity_topup_transition/v0/v0_methods.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ impl IdentityTopUpTransitionMethodsV0 for IdentityTopUpTransitionV0 {
3737
#[cfg(feature = "validation")]
3838
{
3939
let validation_result = asset_lock_proof.validate_structure(platform_version)?;
40-
if !validation_result.is_valid() {
41-
let first_error = validation_result.errors.into_iter().next().unwrap();
40+
if let Some(first_error) = validation_result.errors.into_iter().next() {
4241
return Err(ProtocolError::ConsensusError(Box::new(first_error)));
4342
}
4443
}

0 commit comments

Comments
 (0)