chore: implemented?

Author: lklimek

packages/dapi-grpc/Cargo.toml

@@ -83,6 +83,6 @@ ignored = [
   "platform-version",
   "futures-core",
   "tonic-prost-build",
-  "getrandom", # Ignore getrandom as we need it to enable `js` feature
+  "getrandom",            # Ignore getrandom as we need it to enable `js` feature
   "dash-platform-macros", # used in build.rs
 ]

packages/rs-dpp/src/data_contract/document_type/property/mod.rs

@@ -3,8 +3,8 @@ use std::convert::TryInto;
 
 use std::io::{BufReader, Cursor, Read};
 
-use bincode::{Decode, Encode};
 use crate::data_contract::errors::DataContractError;
+use bincode::{Decode, Encode};
 
 use crate::consensus::basic::decode::DecodingError;
 use crate::data_contract::config::v1::DataContractConfigGettersV1;

packages/rs-dpp/src/errors/consensus/basic/basic_error.rs

@@ -1,3 +1,4 @@
+use crate::consensus::state::document::referenced_entity_not_found_error::ReferencedEntityNotFoundError;
 use crate::errors::ProtocolError;
 use bincode::{Decode, Encode};
 use platform_serialization_derive::{PlatformDeserialize, PlatformSerialize};
@@ -273,6 +274,9 @@ pub enum BasicError {
     #[error(transparent)]
     MaxDocumentsTransitionsExceededError(MaxDocumentsTransitionsExceededError),
 
+    #[error(transparent)]
+    ReferencedEntityNotFoundError(ReferencedEntityNotFoundError),
+
     // Identity
     #[error(transparent)]
     DuplicatedIdentityPublicKeyBasicError(DuplicatedIdentityPublicKeyBasicError),

packages/rs-dpp/src/errors/consensus/codes.rs

@@ -153,6 +153,7 @@ impl ErrorWithCode for BasicError {
             Self::DocumentCreationNotAllowedError(_) => 10416,
             Self::DocumentFieldMaxSizeExceededError(_) => 10417,
             Self::ContestedDocumentsTemporarilyNotAllowedError(_) => 10418,
+            Self::ReferencedEntityNotFoundError(_) => 10419,
 
             // Token Errors: 10450-10499
             Self::InvalidTokenIdError(_) => 10450,

packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs

@@ -241,7 +241,6 @@ pub(super) fn state_transition_to_execution_event_for_check_tx_v0<'a, C: CoreRPC
                 }
                 let action = state_transition_action_result.into_data()?;
 
-                // Validating structure
                 let result = state_transition.validate_advanced_structure_from_state(
                     platform.state.last_block_info(),
                     platform.config.network,

packages/rs-drive-abci/src/execution/validation/state_transition/processor/traits/advanced_structure_with_state.rs

@@ -25,6 +25,7 @@ pub(crate) trait StateTransitionStructureKnownInStateValidationV0 {
     /// # Returns
     ///
     /// * `Result<SimpleConsensusValidationResult, Error>` - A result with either a SimpleConsensusValidationResult or an Error.
+    #[allow(clippy::too_many_arguments)]
     fn validate_advanced_structure_from_state(
         &self,
         block_info: &BlockInfo,

packages/rs-drive-abci/src/execution/validation/state_transition/processor/v0/mod.rs

@@ -269,7 +269,6 @@ pub(super) fn process_state_transition_v0<'a, C: CoreRPCLike>(
         }
         let action = state_transition_action_result.into_data()?;
 
-        // Validating structure
         let result = state_transition.validate_advanced_structure_from_state(
             block_info,
             platform.config.network,

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/action_validation/document/document_create_transition_action/mod.rs

@@ -10,12 +10,14 @@ use crate::error::execution::ExecutionError;
 use crate::execution::types::state_transition_execution_context::StateTransitionExecutionContext;
 use crate::execution::validation::state_transition::batch::action_validation::document::document_create_transition_action::state_v0::DocumentCreateTransitionActionStateValidationV0;
 use crate::execution::validation::state_transition::batch::action_validation::document::document_create_transition_action::state_v1::DocumentCreateTransitionActionStateValidationV1;
+use crate::execution::validation::state_transition::batch::action_validation::document::document_create_transition_action::state_v2::DocumentCreateTransitionActionStateValidationV2;
 use crate::execution::validation::state_transition::batch::action_validation::document::document_create_transition_action::advanced_structure_v0::DocumentCreateTransitionActionStructureValidationV0;
 use crate::platform_types::platform::PlatformStateRef;
 
 mod advanced_structure_v0;
 mod state_v0;
 mod state_v1;
+mod state_v2;
 
 pub trait DocumentCreateTransitionActionValidation {
     fn validate_structure(
@@ -95,9 +97,17 @@ impl DocumentCreateTransitionActionValidation for DocumentCreateTransitionAction
                 transaction,
                 platform_version,
             ),
+            2 => self.validate_state_v2(
+                platform,
+                owner_id,
+                block_info,
+                execution_context,
+                transaction,
+                platform_version,
+            ),
             version => Err(Error::Execution(ExecutionError::UnknownVersionMismatch {
                 method: "DocumentCreateTransitionAction::validate_state".to_string(),
-                known_versions: vec![0, 1],
+                known_versions: vec![0, 1, 2],
                 received: version,
             })),
         }

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/action_validation/document/document_create_transition_action/state_v2/mod.rs

@@ -0,0 +1,65 @@
+use dpp::block::block_info::BlockInfo;
+use dpp::identifier::Identifier;
+use dpp::validation::SimpleConsensusValidationResult;
+use dpp::version::PlatformVersion;
+use drive::query::TransactionArg;
+use drive::state_transition_action::batch::batched_transition::document_transition::document_create_transition_action::{
+    DocumentCreateTransitionAction, DocumentCreateTransitionActionAccessorsV0,
+};
+
+use crate::error::Error;
+use crate::execution::types::state_transition_execution_context::StateTransitionExecutionContext;
+use crate::execution::validation::state_transition::batch::action_validation::document::document_create_transition_action::state_v1::DocumentCreateTransitionActionStateValidationV1;
+use crate::execution::validation::state_transition::batch::action_validation::document::document_reference_validation::DocumentReferenceValidation;
+use crate::platform_types::platform::PlatformStateRef;
+
+pub(in crate::execution::validation::state_transition::state_transitions::batch::action_validation) trait DocumentCreateTransitionActionStateValidationV2
+{
+    fn validate_state_v2(
+        &self,
+        platform: &PlatformStateRef,
+        owner_id: Identifier,
+        block_info: &BlockInfo,
+        execution_context: &mut StateTransitionExecutionContext,
+        transaction: TransactionArg,
+        platform_version: &PlatformVersion,
+    ) -> Result<SimpleConsensusValidationResult, Error>;
+}
+
+impl DocumentCreateTransitionActionStateValidationV2 for DocumentCreateTransitionAction {
+    fn validate_state_v2(
+        &self,
+        platform: &PlatformStateRef,
+        owner_id: Identifier,
+        block_info: &BlockInfo,
+        execution_context: &mut StateTransitionExecutionContext,
+        transaction: TransactionArg,
+        platform_version: &PlatformVersion,
+    ) -> Result<SimpleConsensusValidationResult, Error> {
+        let validation_result = self.validate_state_v1(
+            platform,
+            owner_id,
+            block_info,
+            execution_context,
+            transaction,
+            platform_version,
+        )?;
+        if !validation_result.is_valid() {
+            return Ok(validation_result);
+        }
+
+        let reference_result = self.base().validate_document_references(
+            self.data(),
+            None,
+            platform,
+            transaction,
+            execution_context,
+            platform_version,
+        )?;
+        if !reference_result.is_valid() {
+            return Ok(reference_result);
+        }
+
+        Ok(SimpleConsensusValidationResult::new())
+    }
+}

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/action_validation/document/document_reference_validation/mod.rs

@@ -0,0 +1,61 @@
+pub mod v0;
+
+use std::collections::{BTreeMap, BTreeSet};
+
+use dpp::platform_value::Value;
+use dpp::validation::SimpleConsensusValidationResult;
+use dpp::version::PlatformVersion;
+use drive::query::TransactionArg;
+use drive::state_transition_action::batch::batched_transition::document_transition::document_base_transition_action::DocumentBaseTransitionAction;
+
+use crate::error::execution::ExecutionError;
+use crate::error::Error;
+use crate::execution::types::state_transition_execution_context::StateTransitionExecutionContext;
+use crate::execution::validation::state_transition::batch::action_validation::document::document_reference_validation::v0::DocumentReferenceValidationV0;
+use crate::platform_types::platform::PlatformStateRef;
+
+pub(crate) trait DocumentReferenceValidation {
+    fn validate_document_references(
+        &self,
+        document_data: &BTreeMap<String, Value>,
+        changed_fields: Option<&BTreeSet<String>>,
+        platform: &PlatformStateRef,
+        transaction: TransactionArg,
+        execution_context: &mut StateTransitionExecutionContext,
+        platform_version: &PlatformVersion,
+    ) -> Result<SimpleConsensusValidationResult, Error>;
+}
+
+impl DocumentReferenceValidation for DocumentBaseTransitionAction {
+    fn validate_document_references(
+        &self,
+        document_data: &BTreeMap<String, Value>,
+        changed_fields: Option<&BTreeSet<String>>,
+        platform: &PlatformStateRef,
+        transaction: TransactionArg,
+        execution_context: &mut StateTransitionExecutionContext,
+        platform_version: &PlatformVersion,
+    ) -> Result<SimpleConsensusValidationResult, Error> {
+        match platform_version
+            .drive_abci
+            .validation_and_processing
+            .state_transitions
+            .batch_state_transition
+            .document_reference_validation
+        {
+            0 => self.validate_document_references_v0(
+                document_data,
+                changed_fields,
+                platform,
+                transaction,
+                execution_context,
+                platform_version,
+            ),
+            version => Err(Error::Execution(ExecutionError::UnknownVersionMismatch {
+                method: "DocumentBaseTransitionAction::validate_document_references".to_string(),
+                known_versions: vec![0],
+                received: version,
+            })),
+        }
+    }
+}