fix(drive): restore Ok(None) retry and strengthen test assertions

The previous commit incorrectly restricted retry to Err(_) only,
but Ok(None) from the non-historical path is a legitimate trigger
for historical retry — it means the contract exists in the historical
path, not that it's absent. Restoring the _ catch-all preserves the
original fix from a7fec8b.

Test assertions now require contracts to be returned (not accept None)
for cases where the contract definitely exists, eliminating tautological
acceptance paths.

Author: thepastaclaw

packages/rs-drive/src/verify/contract/verify_contract/v0/mod.rs

@@ -56,10 +56,7 @@ impl Drive {
         if contract_known_keeps_history.is_none() {
             match &result {
                 Ok((_, Some(_))) => result,
-                // Ok(None) is a valid absence proof — contract genuinely doesn't exist.
-                // Don't retry; the server builds a non-historical query for missing contracts.
-                Ok((_, None)) => result,
-                Err(_) => {
+                _ => {
                     tracing::debug!(
                         ?contract_id,
                         "retrying contract verification with history enabled"

packages/rs-drive/src/verify/contract/verify_contract_return_serialization/v0/mod.rs

@@ -58,10 +58,7 @@ impl Drive {
         if contract_known_keeps_history.is_none() {
             match &result {
                 Ok((_, Some(_))) => result,
-                // Ok(None) is a valid absence proof — contract genuinely doesn't exist.
-                // Don't retry; the server builds a non-historical query for missing contracts.
-                Ok((_, None)) => result,
-                Err(_) => {
+                _ => {
                     tracing::debug!(
                         ?contract_id,
                         "retrying contract verification with history enabled"

packages/rs-drive/tests/query_tests.rs

@@ -4744,9 +4744,10 @@ mod tests {
         )
         .expect("verification with None should succeed");
         assert_eq!(root_hash, proof_root_hash);
-        if let Some(contract) = proof_contract {
-            assert_eq!(latest_contract, contract);
-        }
+        assert_eq!(
+            latest_contract,
+            proof_contract.expect("contract exists and was updated — None retry must return it")
+        );
 
         // Test 2: Some(true) - direct historical, must succeed since proof was generated
         // for a historical contract
@@ -4806,9 +4807,9 @@ mod tests {
         )
         .expect("return_serialization with None should succeed for historical contract");
         assert_eq!(root_hash, proof_root_hash_4);
-        if let Some((deserialized, _bytes)) = proof_contract_4 {
-            assert_eq!(latest_contract, deserialized);
-        }
+        let (deserialized, _bytes) =
+            proof_contract_4.expect("contract exists — return_serialization must return it");
+        assert_eq!(latest_contract, deserialized);
     }
 
     #[cfg(feature = "server")]