fix: add clang-tidy nolint exception readability-redundant-declaration for cs_main forward declarations

knst · knst · commit dc20eeb4e53d · 2026-01-15T16:10:15.000+07:00
diff --git a/src/chain.h b/src/chain.h
@@ -35,7 +35,7 @@ static constexpr int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME;
  */
 static constexpr int64_t MAX_BLOCK_TIME_GAP = 25 * 60;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CBlockFileInfo
 {
diff --git a/src/coinjoin/coinjoin.h b/src/coinjoin/coinjoin.h
@@ -34,7 +34,7 @@ class CChainLocksHandler;
 class CInstantSendManager;
 } // namespace llmq
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 // timeouts
 static constexpr int COINJOIN_AUTO_TIMEOUT_MIN = 5;
diff --git a/src/evo/deterministicmns.h b/src/evo/deterministicmns.h
@@ -40,7 +40,7 @@ class CSpecialTxProcessor;
 class TxValidationState;
 struct RPCResult;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CDeterministicMN
 {
diff --git a/src/evo/smldiff.h b/src/evo/smldiff.h
@@ -29,7 +29,7 @@ class CQuorumBlockProcessor;
 class CQuorumManager;
 } // namespace llmq
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 /// P2P messages
 
diff --git a/src/evo/specialtxman.h b/src/evo/specialtxman.h
@@ -33,7 +33,7 @@ class CQuorumManager;
 class CQuorumSnapshotManager;
 } // namespace llmq
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CSpecialTxProcessor
 {
diff --git a/src/governance/governance.h b/src/governance/governance.h
@@ -53,7 +53,7 @@ using vote_time_pair_t = std::pair<CGovernanceVote, int64_t>;
 static constexpr int RATE_BUFFER_SIZE = 5;
 static constexpr bool DEFAULT_GOVERNANCE_ENABLE{true};
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CRateCheckBuffer
 {
diff --git a/src/governance/object.h b/src/governance/object.h
@@ -24,7 +24,7 @@ class ChainstateManager;
 class CMasternodeMetaMan;
 struct RPCResult;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 static constexpr double GOVERNANCE_FILTER_FP_RATE = 0.001;
 static constexpr CAmount GOVERNANCE_PROPOSAL_FEE_TX = (1 * COIN);
diff --git a/src/llmq/blockprocessor.h b/src/llmq/blockprocessor.h
@@ -31,7 +31,7 @@ class CDeterministicMNManager;
 class CEvoDB;
 class CNode;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 namespace llmq
 {
diff --git a/src/node/blockstorage.h b/src/node/blockstorage.h
@@ -16,7 +16,7 @@
 #include <unordered_map>
 #include <vector>
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class ArgsManager;
 class BlockValidationState;
diff --git a/src/rpc/blockchain.h b/src/rpc/blockchain.h
@@ -17,7 +17,7 @@
 #include <optional>
 #include <vector>
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CBlock;
 class CBlockIndex;
diff --git a/src/rpc/index_util.h b/src/rpc/index_util.h
@@ -22,7 +22,7 @@ class uint256;
 
 enum class AddressType : uint8_t;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 //! throws JSONRPCError if address index is unavailable
 bool GetAddressIndex(CBlockTreeDB& block_tree_db, const uint160& addressHash, const AddressType type,
diff --git a/src/txdb.h b/src/txdb.h
@@ -46,7 +46,7 @@ static const int64_t max_filter_index_cache = 1024;
 static const int64_t nMaxCoinsDBCache = 8;
 
 // Actually declared in validation.cpp; can't include because of circular dependency.
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 /** CCoinsView backed by the coin database (chainstate/) */
 class CCoinsViewDB final : public CCoinsView
diff --git a/src/txmempool.h b/src/txmempool.h
@@ -42,7 +42,7 @@
 class CBlockIndex;
 class CChain;
 class CChainState;
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 // Forward declaration for CBLSLazyPublicKey:
 template<typename T> class CBLSLazyWrapper;
diff --git a/src/validation.h b/src/validation.h
@@ -112,7 +112,7 @@ enum class SynchronizationState {
     POST_INIT
 };
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 extern GlobalMutex g_best_block_mutex;
 extern std::condition_variable g_best_block_cv;
 /** Used to notify getblocktemplate RPC of new tips. */
diff --git a/src/validationinterface.h b/src/validationinterface.h
@@ -12,7 +12,7 @@
 #include <functional>
 #include <memory>
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 class BlockValidationState;
 class CBlock;
 class CBlockIndex;

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ static constexpr int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME;`
`35`	`35`	`*/`
`36`	`36`	`static constexpr int64_t MAX_BLOCK_TIME_GAP = 25 * 60;`
`37`	`37`
`38`		`-extern RecursiveMutex cs_main;`
	`38`	`+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)`
`39`	`39`
`40`	`40`	`class CBlockFileInfo`
`41`	`41`	`{`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ class CSpecialTxProcessor;`
`40`	`40`	`class TxValidationState;`
`41`	`41`	`struct RPCResult;`
`42`	`42`
`43`		`-extern RecursiveMutex cs_main;`
	`43`	`+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)`
`44`	`44`
`45`	`45`	`class CDeterministicMN`
`46`	`46`	`{`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class CQuorumManager;`
`33`	`33`	`class CQuorumSnapshotManager;`
`34`	`34`	`} // namespace llmq`
`35`	`35`
`36`		`-extern RecursiveMutex cs_main;`
	`36`	`+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)`
`37`	`37`
`38`	`38`	`class CSpecialTxProcessor`
`39`	`39`	`{`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ using vote_time_pair_t = std::pair<CGovernanceVote, int64_t>;`
`53`	`53`	`static constexpr int RATE_BUFFER_SIZE = 5;`
`54`	`54`	`static constexpr bool DEFAULT_GOVERNANCE_ENABLE{true};`
`55`	`55`
`56`		`-extern RecursiveMutex cs_main;`
	`56`	`+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)`
`57`	`57`
`58`	`58`	`class CRateCheckBuffer`
`59`	`59`	`{`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class CDeterministicMNManager;`
`31`	`31`	`class CEvoDB;`
`32`	`32`	`class CNode;`
`33`	`33`
`34`		`-extern RecursiveMutex cs_main;`
	`34`	`+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)`
`35`	`35`
`36`	`36`	`namespace llmq`
`37`	`37`	`{`