fix: trigger manual re-fetch only if checkbox state changed

Author: kwvg

src/qt/masternodelist.cpp

@@ -250,21 +250,18 @@ void MasternodeList::updateDIP3List()
 
     // Update filters
     if (walletModel && ui->checkBoxOwned->isChecked()) {
-        updateMyMasternodeHashes();
+        updateMyMasternodeHashes(mnList);
     }
 
     updateFilteredCount();
 }
 
-void MasternodeList::updateMyMasternodeHashes()
+void MasternodeList::updateMyMasternodeHashes(const interfaces::MnListPtr& mnList)
 {
-    if (!clientModel || !walletModel) {
+    if (!walletModel || !mnList) {
         return;
     }
 
-    auto [mnList, pindex] = clientModel->getMasternodeList();
-    if (!pindex) return;
-
     std::set<COutPoint> setOutpts;
     for (const auto& outpt : walletModel->wallet().listProTxCoins()) {
         setOutpts.emplace(outpt);
@@ -313,8 +310,11 @@ void MasternodeList::on_comboBoxType_currentIndexChanged(int index)
 void MasternodeList::on_checkBoxOwned_stateChanged(int state)
 {
     m_proxy_model->setShowOwnedOnly(state == Qt::Checked);
-    if (state == Qt::Checked) {
-        updateMyMasternodeHashes();
+    if (clientModel && state == Qt::Checked) {
+        auto [mnList, pindex] = clientModel->getMasternodeList();
+        if (mnList) {
+            updateMyMasternodeHashes(mnList);
+        }
     } else {
         m_proxy_model->forceInvalidateFilter();
     }

src/qt/masternodelist.h

@@ -14,8 +14,13 @@
 #include <QWidget>
 
 #include <atomic>
+#include <memory>
 #include <set>
 
+namespace interfaces {
+class MnList;
+using MnListPtr = std::shared_ptr<MnList>;
+} // namespace interfaces
 namespace Ui {
 class MasternodeList;
 } // namespace Ui
@@ -89,7 +94,7 @@ class MasternodeList : public QWidget
     const MasternodeEntry* GetSelectedEntry();
 
     void updateDIP3List();
-    void updateMyMasternodeHashes();
+    void updateMyMasternodeHashes(const interfaces::MnListPtr& mnList);
 
 Q_SIGNALS:
     void doubleClicked(const QModelIndex&);