fix(qt): only reinitialize splash phase on actual phase transition

During wallet rescans, repeated ShowProgress callbacks with the same message re-entered the resetsBar block, slamming displayProgress back to 0 and restarting phaseTimer on every update. Track the current phase pointer and skip reinitialization when the phase hasn't changed.

Author: PastaPastaPasta

src/qt/splashscreen.cpp

@@ -354,9 +354,12 @@ void SplashScreen::showMessage(const QString &message, int alignment, const QCol
         animTimer.start(30);
     }
 
-    // Look up the phase range for this message
+    // Look up the phase range for this message; only reinitialize when the
+    // phase actually changes so that repeated progress callbacks (e.g. during
+    // wallet rescans) don't reset displayProgress and phaseTimer each time.
     const PhaseInfo* phase = LookupPhase(message);
-    if (phase != nullptr) {
+    if (phase != nullptr && phase != m_current_phase) {
+        m_current_phase = phase;
         if (phase->snapsToEnd) {
             // Final phase: snap to 100% immediately since the splash
             // will be destroyed moments after "Done loading" arrives

src/qt/splashscreen.h

@@ -75,6 +75,7 @@ public Q_SLOTS:
     qreal phaseEnd{0.0};        // Overall progress at end of current phase
     bool phaseIsLong{false};    // True for long independent phases (rescan, wallet load)
     QElapsedTimer phaseTimer;    // Time since current phase started
+    const struct PhaseInfo* m_current_phase{nullptr}; // Current phase (defined in splashscreen.cpp)
     qreal displayProgress{0.0}; // Smoothly animated display value (0.0-1.0)
     QTimer animTimer;