Merge #7112: refactor(qt): UI refresh (1/n, runtime show/hide of "Governance" and "Masternode" tabs, split out proposal model, additional bounds checking, better QTextEdit styling)

f9f7c6e refactor: repurpose `transactiondescdialog` as a generic desc. container (Kittywhiskers Van Gogh)
5f4a6c0 refactor: track "Masternodes" tab show/hide in `OptionsModel` (Kittywhiskers Van Gogh)
1994f8c qt: use show/hide for "Masternodes" tab to avoid client restart (Kittywhiskers Van Gogh)
6a7e6b0 refactor: track "Governance" tab show/hide in `OptionsModel` (Kittywhiskers Van Gogh)
64a2db6 qt: use show/hide for "Governance" tab to avoid client restart (Kittywhiskers Van Gogh)
762e5d3 qt: add styling support for QTextEdit `<b>` and `<h{1-3}>` elements (Kittywhiskers Van Gogh)
7a2f09d refactor: drop `QObject` inheritance, precalculate hash string (Kittywhiskers Van Gogh)
fdd3193 fix: use `unique_ptr` and more bounds checking in `qt/proposalmodel` (Kittywhiskers Van Gogh)
c9e0d94 move-only: split proposal model out to `src/qt/proposalmodel.{cpp,h}` (Kittywhiskers Van Gogh)
42f2345 refactor: add `pruneStaleEntities` helper to deduplicate pruning (Kittywhiskers Van Gogh)
72c4099 refactor: add `getScaledFont` helper, keep `getFont` internal (Kittywhiskers Van Gogh)
6d9b90b chore: enforce alphabetical sorting in `src/Makefile.qt.include` (Kittywhiskers Van Gogh)
83b9271 move-only: move `subFeeFromAmount` into `verticalLayout_2` (Kittywhiskers Van Gogh)
bcfc0e3 refactor: improve CoinJoin tab nullptr checks, bail-out condition (Kittywhiskers Van Gogh)
7648792 refactor: drop `emitCoinJoinEnabledChanged()`, use `setOption()` instead (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Dependency for #7110
  * Dependency for #7116

  | `develop` (cc50446) | This PR (18d6ce6) |
  | ----------------------- | ------------------- |
  | ![](https://github.com/user-attachments/assets/f1e9a4e2-3bc0-42bd-89ed-697c9540f8f2) | ![](https://github.com/user-attachments/assets/2cd4688c-8e20-4c6d-8a2c-95e99e883631) |
  | ![](https://github.com/user-attachments/assets/4debb9f6-8f20-4892-be08-a52474286c31) | ![](https://github.com/user-attachments/assets/719949dd-e03c-4269-9014-2beebe2df990) |
  | ![](https://github.com/user-attachments/assets/7ffb57dc-a229-4522-b670-cc9d6e008495) | ![](https://github.com/user-attachments/assets/7241b76a-6435-44d8-b617-cafc02c6a278) |

  ## Breaking Changes

  None expected.

  ## Checklist

  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation **(note: N/A)**
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK f9f7c6e

Tree-SHA512: 6c219c8bc5b90c52bb030a6f05bcf9168ec51be0d72c23b38b5aba852666419949ebe4ee07c2c8ba70241655a542de24e2e31b6b0241517e183b7bf289373a37

Author: PastaPastaPasta

src/Makefile.qt.include

@@ -20,33 +20,32 @@ QT_FORMS_UI = \
   qt/forms/askpassphrasedialog.ui \
   qt/forms/coincontroldialog.ui \
   qt/forms/createwalletdialog.ui \
+  qt/forms/debugwindow.ui \
+  qt/forms/descriptiondialog.ui \
   qt/forms/editaddressdialog.ui \
   qt/forms/governancelist.ui \
-  qt/forms/proposalwizard.ui \
   qt/forms/helpmessagedialog.ui \
   qt/forms/intro.ui \
-  qt/forms/modaloverlay.ui \
   qt/forms/masternodelist.ui \
   qt/forms/mnemonicverificationdialog.ui \
-  qt/forms/qrdialog.ui \
+  qt/forms/modaloverlay.ui \
   qt/forms/openuridialog.ui \
   qt/forms/optionsdialog.ui \
   qt/forms/overviewpage.ui \
+  qt/forms/proposalwizard.ui \
   qt/forms/psbtoperationsdialog.ui \
+  qt/forms/qrdialog.ui \
   qt/forms/receivecoinsdialog.ui \
   qt/forms/receiverequestdialog.ui \
-  qt/forms/debugwindow.ui \
   qt/forms/sendcoinsdialog.ui \
   qt/forms/sendcoinsentry.ui \
-  qt/forms/signverifymessagedialog.ui \
-  qt/forms/transactiondescdialog.ui
+  qt/forms/signverifymessagedialog.ui
 
 QT_MOC_CPP = \
   qt/moc_addressbookpage.cpp \
   qt/moc_addresstablemodel.cpp \
   qt/moc_appearancewidget.cpp \
   qt/moc_askpassphrasedialog.cpp \
-  qt/moc_createwalletdialog.cpp \
   qt/moc_bantablemodel.cpp \
   qt/moc_bitcoin.cpp \
   qt/moc_bitcoinaddressvalidator.cpp \
@@ -56,26 +55,29 @@ QT_MOC_CPP = \
   qt/moc_clientmodel.cpp \
   qt/moc_coincontroldialog.cpp \
   qt/moc_coincontroltreewidget.cpp \
+  qt/moc_createwalletdialog.cpp \
   qt/moc_csvmodelwriter.cpp \
+  qt/moc_descriptiondialog.cpp \
   qt/moc_editaddressdialog.cpp \
   qt/moc_governancelist.cpp \
-  qt/moc_proposalwizard.cpp \
   qt/moc_guiutil.cpp \
   qt/moc_initexecutor.cpp \
   qt/moc_intro.cpp \
   qt/moc_macdockiconhandler.cpp \
   qt/moc_macnotificationhandler.cpp \
-  qt/moc_modaloverlay.cpp \
   qt/moc_masternodelist.cpp \
   qt/moc_mnemonicverificationdialog.cpp \
+  qt/moc_modaloverlay.cpp \
   qt/moc_notificator.cpp \
   qt/moc_openuridialog.cpp \
   qt/moc_optionsdialog.cpp \
   qt/moc_optionsmodel.cpp \
   qt/moc_overviewpage.cpp \
+  qt/moc_paymentserver.cpp \
   qt/moc_peertablemodel.cpp \
   qt/moc_peertablesortproxy.cpp \
-  qt/moc_paymentserver.cpp \
+  qt/moc_proposalmodel.cpp \
+  qt/moc_proposalwizard.cpp \
   qt/moc_psbtoperationsdialog.cpp \
   qt/moc_qrdialog.cpp \
   qt/moc_qrimagewidget.cpp \
@@ -91,7 +93,6 @@ QT_MOC_CPP = \
   qt/moc_splashscreen.cpp \
   qt/moc_trafficgraphwidget.cpp \
   qt/moc_transactiondesc.cpp \
-  qt/moc_transactiondescdialog.cpp \
   qt/moc_transactionfilterproxy.cpp \
   qt/moc_transactionoverviewwidget.cpp \
   qt/moc_transactiontablemodel.cpp \
@@ -134,9 +135,9 @@ BITCOIN_QT_H = \
   qt/coincontroltreewidget.h \
   qt/createwalletdialog.h \
   qt/csvmodelwriter.h \
+  qt/descriptiondialog.h \
   qt/editaddressdialog.h \
   qt/governancelist.h \
-  qt/proposalwizard.h \
   qt/guiconstants.h \
   qt/guiutil.h \
   qt/guiutil_font.h \
@@ -145,9 +146,9 @@ BITCOIN_QT_H = \
   qt/macdockiconhandler.h \
   qt/macnotificationhandler.h \
   qt/macos_appnap.h \
-  qt/modaloverlay.h \
   qt/masternodelist.h \
   qt/mnemonicverificationdialog.h \
+  qt/modaloverlay.h \
   qt/networkstyle.h \
   qt/notificator.h \
   qt/openuridialog.h \
@@ -157,6 +158,8 @@ BITCOIN_QT_H = \
   qt/paymentserver.h \
   qt/peertablemodel.h \
   qt/peertablesortproxy.h \
+  qt/proposalmodel.h \
+  qt/proposalwizard.h \
   qt/psbtoperationsdialog.h \
   qt/qrdialog.h \
   qt/qrimagewidget.h \
@@ -174,7 +177,6 @@ BITCOIN_QT_H = \
   qt/trafficgraphdata.h \
   qt/trafficgraphwidget.h \
   qt/transactiondesc.h \
-  qt/transactiondescdialog.h \
   qt/transactionfilterproxy.h \
   qt/transactionoverviewwidget.h \
   qt/transactionrecord.h \
@@ -189,36 +191,36 @@ BITCOIN_QT_H = \
   qt/winshutdownmonitor.h
 
 QT_RES_ICONS = \
-  qt/res/icons/dash.ico \
-  qt/res/icons/dash_testnet.ico \
-  qt/res/icons/dash.png \
-  qt/res/icons/warning.png \
   qt/res/icons/address-book.png \
-  qt/res/icons/transaction0.png \
-  qt/res/icons/transaction1.png \
-  qt/res/icons/transaction2.png \
-  qt/res/icons/transaction3.png \
-  qt/res/icons/transaction4.png \
-  qt/res/icons/transaction5.png \
-  qt/res/icons/transaction_abandoned.png \
-  qt/res/icons/transaction_locked.png \
   qt/res/icons/connect1_16.png \
   qt/res/icons/connect2_16.png \
   qt/res/icons/connect3_16.png \
   qt/res/icons/connect4_16.png \
+  qt/res/icons/dash.ico \
+  qt/res/icons/dash.png \
+  qt/res/icons/dash_testnet.ico \
   qt/res/icons/editcopy.png \
   qt/res/icons/editpaste.png \
   qt/res/icons/eye.png \
   qt/res/icons/eye_minus.png \
   qt/res/icons/eye_plus.png \
+  qt/res/icons/fontbigger.png \
+  qt/res/icons/fontsmaller.png \
   qt/res/icons/hd_enabled.png \
   qt/res/icons/lock_closed.png \
   qt/res/icons/lock_open.png \
   qt/res/icons/proxy.png \
   qt/res/icons/remove.png \
   qt/res/icons/synced.png \
-  qt/res/icons/fontbigger.png \
-  qt/res/icons/fontsmaller.png
+  qt/res/icons/transaction0.png \
+  qt/res/icons/transaction1.png \
+  qt/res/icons/transaction2.png \
+  qt/res/icons/transaction3.png \
+  qt/res/icons/transaction4.png \
+  qt/res/icons/transaction5.png \
+  qt/res/icons/transaction_abandoned.png \
+  qt/res/icons/transaction_locked.png \
+  qt/res/icons/warning.png
 
 BITCOIN_QT_BASE_CPP = \
   qt/appearancewidget.cpp \
@@ -258,14 +260,16 @@ BITCOIN_QT_WALLET_CPP = \
   qt/coincontroldialog.cpp \
   qt/coincontroltreewidget.cpp \
   qt/createwalletdialog.cpp \
+  qt/descriptiondialog.cpp \
   qt/editaddressdialog.cpp \
   qt/governancelist.cpp \
-  qt/proposalwizard.cpp \
   qt/masternodelist.cpp \
   qt/mnemonicverificationdialog.cpp \
   qt/openuridialog.cpp \
   qt/overviewpage.cpp \
   qt/paymentserver.cpp \
+  qt/proposalmodel.cpp \
+  qt/proposalwizard.cpp \
   qt/psbtoperationsdialog.cpp \
   qt/qrdialog.cpp \
   qt/qrimagewidget.cpp \
@@ -276,7 +280,6 @@ BITCOIN_QT_WALLET_CPP = \
   qt/sendcoinsentry.cpp \
   qt/signverifymessagedialog.cpp \
   qt/transactiondesc.cpp \
-  qt/transactiondescdialog.cpp \
   qt/transactionfilterproxy.cpp \
   qt/transactionoverviewwidget.cpp \
   qt/transactionrecord.cpp \
@@ -301,50 +304,50 @@ QT_RES_IMAGES = \
   qt/res/images/arrow_down_light.png \
   qt/res/images/arrow_left_dark.png \
   qt/res/images/arrow_left_light.png \
-  qt/res/images/arrow_right_dark.png \
-  qt/res/images/arrow_right_light.png \
-  qt/res/images/arrow_up_dark.png \
-  qt/res/images/arrow_up_light.png \
-  qt/res/images/arrow_light_down_normal.png \
   qt/res/images/arrow_light_down_hover.png \
-  qt/res/images/arrow_light_left_normal.png \
+  qt/res/images/arrow_light_down_normal.png \
   qt/res/images/arrow_light_left_hover.png \
-  qt/res/images/arrow_light_right_normal.png \
+  qt/res/images/arrow_light_left_normal.png \
   qt/res/images/arrow_light_right_hover.png \
-  qt/res/images/arrow_light_up_normal.png \
+  qt/res/images/arrow_light_right_normal.png \
   qt/res/images/arrow_light_up_hover.png \
-  qt/res/images/checkbox_normal_dark.png \
-  qt/res/images/checkbox_normal_hover_dark.png \
-  qt/res/images/checkbox_normal_disabled_dark.png \
+  qt/res/images/arrow_light_up_normal.png \
+  qt/res/images/arrow_right_dark.png \
+  qt/res/images/arrow_right_light.png \
+  qt/res/images/arrow_up_dark.png \
+  qt/res/images/arrow_up_light.png \
   qt/res/images/checkbox_checked_dark.png \
-  qt/res/images/checkbox_checked_hover_dark.png \
   qt/res/images/checkbox_checked_disabled_dark.png \
+  qt/res/images/checkbox_checked_disabled_light.png \
+  qt/res/images/checkbox_checked_hover_dark.png \
+  qt/res/images/checkbox_checked_hover_light.png \
+  qt/res/images/checkbox_checked_light.png \
+  qt/res/images/checkbox_normal_dark.png \
+  qt/res/images/checkbox_normal_disabled_dark.png \
+  qt/res/images/checkbox_normal_disabled_light.png \
+  qt/res/images/checkbox_normal_hover_dark.png \
+  qt/res/images/checkbox_normal_hover_light.png \
+  qt/res/images/checkbox_normal_light.png \
   qt/res/images/checkbox_partly_checked_dark.png \
-  qt/res/images/checkbox_partly_checked_hover_dark.png \
   qt/res/images/checkbox_partly_checked_disabled_dark.png \
-  qt/res/images/checkbox_normal_light.png \
-  qt/res/images/checkbox_normal_hover_light.png \
-  qt/res/images/checkbox_normal_disabled_light.png \
-  qt/res/images/checkbox_checked_light.png \
-  qt/res/images/checkbox_checked_hover_light.png \
-  qt/res/images/checkbox_checked_disabled_light.png \
-  qt/res/images/checkbox_partly_checked_light.png \
-  qt/res/images/checkbox_partly_checked_hover_light.png \
   qt/res/images/checkbox_partly_checked_disabled_light.png \
+  qt/res/images/checkbox_partly_checked_hover_dark.png \
+  qt/res/images/checkbox_partly_checked_hover_light.png \
+  qt/res/images/checkbox_partly_checked_light.png \
   qt/res/images/dash_logo_toolbar.png \
   qt/res/images/dash_logo_toolbar_blue.png \
-  qt/res/images/radio_normal_dark.png \
-  qt/res/images/radio_normal_hover_dark.png \
   qt/res/images/radio_checked_dark.png \
-  qt/res/images/radio_checked_hover_dark.png \
-  qt/res/images/radio_normal_disabled_dark.png \
   qt/res/images/radio_checked_disabled_dark.png \
-  qt/res/images/radio_normal_light.png \
-  qt/res/images/radio_normal_hover_light.png \
-  qt/res/images/radio_checked_light.png \
+  qt/res/images/radio_checked_disabled_light.png \
+  qt/res/images/radio_checked_hover_dark.png \
   qt/res/images/radio_checked_hover_light.png \
+  qt/res/images/radio_checked_light.png \
+  qt/res/images/radio_normal_dark.png \
+  qt/res/images/radio_normal_disabled_dark.png \
   qt/res/images/radio_normal_disabled_light.png \
-  qt/res/images/radio_checked_disabled_light.png \
+  qt/res/images/radio_normal_hover_dark.png \
+  qt/res/images/radio_normal_hover_light.png \
+  qt/res/images/radio_normal_light.png \
   qt/res/images/splash.png
 
 QT_RES_CSS = \