refactor: repurpose transactiondescdialog as a generic desc. container

Author: kwvg

src/Makefile.qt.include

@@ -21,6 +21,7 @@ QT_FORMS_UI = \
   qt/forms/coincontroldialog.ui \
   qt/forms/createwalletdialog.ui \
   qt/forms/debugwindow.ui \
+  qt/forms/descriptiondialog.ui \
   qt/forms/editaddressdialog.ui \
   qt/forms/governancelist.ui \
   qt/forms/helpmessagedialog.ui \
@@ -38,8 +39,7 @@ QT_FORMS_UI = \
   qt/forms/receiverequestdialog.ui \
   qt/forms/sendcoinsdialog.ui \
   qt/forms/sendcoinsentry.ui \
-  qt/forms/signverifymessagedialog.ui \
-  qt/forms/transactiondescdialog.ui
+  qt/forms/signverifymessagedialog.ui
 
 QT_MOC_CPP = \
   qt/moc_addressbookpage.cpp \
@@ -57,6 +57,7 @@ QT_MOC_CPP = \
   qt/moc_coincontroltreewidget.cpp \
   qt/moc_createwalletdialog.cpp \
   qt/moc_csvmodelwriter.cpp \
+  qt/moc_descriptiondialog.cpp \
   qt/moc_editaddressdialog.cpp \
   qt/moc_governancelist.cpp \
   qt/moc_guiutil.cpp \
@@ -92,7 +93,6 @@ QT_MOC_CPP = \
   qt/moc_splashscreen.cpp \
   qt/moc_trafficgraphwidget.cpp \
   qt/moc_transactiondesc.cpp \
-  qt/moc_transactiondescdialog.cpp \
   qt/moc_transactionfilterproxy.cpp \
   qt/moc_transactionoverviewwidget.cpp \
   qt/moc_transactiontablemodel.cpp \
@@ -135,6 +135,7 @@ BITCOIN_QT_H = \
   qt/coincontroltreewidget.h \
   qt/createwalletdialog.h \
   qt/csvmodelwriter.h \
+  qt/descriptiondialog.h \
   qt/editaddressdialog.h \
   qt/governancelist.h \
   qt/guiconstants.h \
@@ -176,7 +177,6 @@ BITCOIN_QT_H = \
   qt/trafficgraphdata.h \
   qt/trafficgraphwidget.h \
   qt/transactiondesc.h \
-  qt/transactiondescdialog.h \
   qt/transactionfilterproxy.h \
   qt/transactionoverviewwidget.h \
   qt/transactionrecord.h \
@@ -260,6 +260,7 @@ BITCOIN_QT_WALLET_CPP = \
   qt/coincontroldialog.cpp \
   qt/coincontroltreewidget.cpp \
   qt/createwalletdialog.cpp \
+  qt/descriptiondialog.cpp \
   qt/editaddressdialog.cpp \
   qt/governancelist.cpp \
   qt/masternodelist.cpp \
@@ -279,7 +280,6 @@ BITCOIN_QT_WALLET_CPP = \
   qt/sendcoinsentry.cpp \
   qt/signverifymessagedialog.cpp \
   qt/transactiondesc.cpp \
-  qt/transactiondescdialog.cpp \
   qt/transactionfilterproxy.cpp \
   qt/transactionoverviewwidget.cpp \
   qt/transactionrecord.cpp \

src/qt/descriptiondialog.cpp

@@ -0,0 +1,27 @@
+// Copyright (c) 2011-2021 The Bitcoin Core developers
+// Copyright (c) 2026 The Dash Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <qt/forms/ui_descriptiondialog.h>
+
+#include <qt/descriptiondialog.h>
+#include <qt/guiutil_font.h>
+
+#include <qt/guiutil.h>
+
+DescriptionDialog::DescriptionDialog(const QString& title, const QString& html, QWidget* parent) :
+    QDialog{parent, GUIUtil::dialog_flags},
+    ui{new Ui::DescriptionDialog}
+{
+    ui->setupUi(this);
+    setWindowTitle(title);
+    GUIUtil::registerWidget(ui->detailText, html);
+    GUIUtil::updateFonts();
+    GUIUtil::handleCloseWindowShortcut(this);
+}
+
+DescriptionDialog::~DescriptionDialog()
+{
+    delete ui;
+}

src/qt/descriptiondialog.h

@@ -0,0 +1,28 @@
+// Copyright (c) 2011-2020 The Bitcoin Core developers
+// Copyright (c) 2026 The Dash Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_QT_DESCRIPTIONDIALOG_H
+#define BITCOIN_QT_DESCRIPTIONDIALOG_H
+
+#include <QDialog>
+
+namespace Ui {
+class DescriptionDialog;
+} // namespace Ui
+
+/** Generic dialog showing detailed text description. */
+class DescriptionDialog : public QDialog
+{
+    Q_OBJECT
+
+public:
+    explicit DescriptionDialog(const QString& title, const QString& html, QWidget* parent = nullptr);
+    ~DescriptionDialog();
+
+private:
+    Ui::DescriptionDialog* ui;
+};
+
+#endif // BITCOIN_QT_DESCRIPTIONDIALOG_H

src/qt/forms/transactiondescdialog.ui src/qt/forms/descriptiondialog.uisrc/qt/forms/transactiondescdialog.ui renamed to src/qt/forms/descriptiondialog.ui

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <ui version="4.0">
- <class>TransactionDescDialog</class>
- <widget class="QDialog" name="TransactionDescDialog">
+ <class>DescriptionDialog</class>
+ <widget class="QDialog" name="DescriptionDialog">
   <property name="geometry">
    <rect>
     <x>0</x>
@@ -11,13 +11,13 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string notr="true">Transaction details</string>
+   <string notr="true">Details</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
    <item>
     <widget class="QTextEdit" name="detailText">
      <property name="toolTip">
-      <string>This pane shows a detailed description of the transaction</string>
+      <string>This pane shows detailed information</string>
      </property>
      <property name="readOnly">
       <bool>true</bool>
@@ -41,7 +41,7 @@
   <connection>
    <sender>buttonBox</sender>
    <signal>accepted()</signal>
-   <receiver>TransactionDescDialog</receiver>
+   <receiver>DescriptionDialog</receiver>
    <slot>accept()</slot>
    <hints>
     <hint type="sourcelabel">
@@ -57,7 +57,7 @@
   <connection>
    <sender>buttonBox</sender>
    <signal>rejected()</signal>
-   <receiver>TransactionDescDialog</receiver>
+   <receiver>DescriptionDialog</receiver>
    <slot>reject()</slot>
    <hints>
     <hint type="sourcelabel">

src/qt/transactiondescdialog.cpp

@@ -7,11 +7,11 @@
 #include <qt/addresstablemodel.h>
 #include <qt/bitcoinunits.h>
 #include <qt/csvmodelwriter.h>
+#include <qt/descriptiondialog.h>
 #include <qt/editaddressdialog.h>
 #include <qt/guiutil.h>
 #include <qt/optionsmodel.h>
 #include <qt/qrdialog.h>
-#include <qt/transactiondescdialog.h>
 #include <qt/transactionfilterproxy.h>
 #include <qt/transactionrecord.h>
 #include <qt/transactiontablemodel.h>
@@ -538,7 +538,11 @@ void TransactionView::showDetails()
     QModelIndexList selection = transactionView->selectionModel()->selectedRows();
     if(!selection.isEmpty())
     {
-        TransactionDescDialog* dlg = new TransactionDescDialog(selection.at(0), this);
+        const QModelIndex& idx{selection.at(0)};
+        DescriptionDialog* dlg = new DescriptionDialog(
+            tr("Details for %1").arg(idx.data(TransactionTableModel::TxHashRole).toString()),
+            idx.data(TransactionTableModel::LongDescriptionRole).toString(),
+            /*parent=*/this);
         dlg->setAttribute(Qt::WA_DeleteOnClose);
         dlg->show();
     }

src/qt/transactiondescdialog.h

@@ -28,6 +28,7 @@ src/masternode/*.cpp
 src/masternode/*.h
 src/messagesigner.*
 src/netfulfilledman.*
+src/qt/descriptiondialog.*
 src/qt/governancelist.*
 src/qt/guiutil_font.*
 src/qt/masternodelist.*