Merge #7103: backport: bitcoin#26705, bitcoin#26706, bitcoin-core/gui#686 - clang-tidy: for all headers and related fixes

f842c28 Merge bitcoin#26705: clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers (MarcoFalke)
6b2b1fe Merge bitcoin-core/gui#686: clang-tidy: Force checks for headers in `src/qt` (Hennadii Stepanov)
2772030 Merge bitcoin#26706: doc: Properly report optional RPC args (fanquake)
3173806 lint: multiple clang-tidy warnings for dash specific code (Konstantin Akimov)
3779f71 refactor: replace define to const for default sample height in traffic widged (Konstantin Akimov)
2c07d66 refactor: simplify GetParams to GetLLLMQType in dkgsession's interface (Konstantin Akimov)
a0cd036 fix: follow-up for bitcoin#24925 - use rand values instead 0 (Konstantin Akimov)
1c7f056 fix: add clang-tidy nolint exception readability-redundant-declaration for cs_main forward declarations (Konstantin Akimov)
8a635ec ci: add a new category of commits `lint` which groups refactorings and fixes to please linters (Konstantin Akimov)

Pull request description:

  ## What was done?
  Backport bitcoin#26705 to enforce clang-tidy for all headers.
  This backport:
    - fixes the only [remained](bitcoin#26705 (comment)) check in headers, i.e., `modernize-use-default-member-init`
    - forces `clang-tidy` check all headers

  It has significant amount of failures for dash specific code; this backport is extracted from #7100 to its own PR and 2 more PRs are added to fix multiple issues in backported code: bitcoin#26706, bitcoin-core/gui#686 to fix related failures.

  ## How Has This Been Tested?
  Run CI & fix failures

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK f842c28

(a bit concerned about touching 3rd-party files but since we aren't going to update them from their upstream ever I think it's ok-ish to fix them too instead of complicating clang-tidy settings)
  kwvg:
    utACK f842c28

Tree-SHA512: 2efbf3bddc748351ff702f0eda29b50f72348e516ebbb0e6e784bafb20850e7a231255c5019838ba05152c3e73c48b2f5ca6f4856842f2c7e4664b0242cd1c57

Author: PastaPastaPasta

.github/workflows/semantic-pull-request.yml

@@ -30,6 +30,7 @@ jobs:
             build
             guix
             ci
+            lint
             chore
             revert
             trivial

src/.clang-tidy

@@ -26,3 +26,4 @@ readability-redundant-string-init,
 CheckOptions:
  - key: performance-move-const-arg.CheckTriviallyCopyableMove
    value: false
+HeaderFilterRegex: '.'

src/active/dkgsessionhandler.cpp

@@ -343,7 +343,7 @@ static void RelayInvToParticipants(const CDKGSession& session, const CConnman& c
                  "HasMasternodeQuorumNodes[%d] for quorumHash[%s] forMember[%s] relayMembers[%s]",
                  inv.ToString(), relayMembers.size(), connman.GetNodeCount(ConnectionDirection::Both),
                  connman.GetNetworkActive(),
-                 connman.HasMasternodeQuorumNodes(session.GetParams().type, session.BlockIndex()->GetBlockHash()),
+                 connman.HasMasternodeQuorumNodes(session.GetType(), session.BlockIndex()->GetBlockHash()),
                  session.BlockIndex()->GetBlockHash().ToString(), session.ProTx().ToString().substr(0, 4), ss.str());
 
     std::stringstream ss2;

src/bls/bls.h

@@ -390,7 +390,7 @@ class CBLSLazyWrapper
 private:
     mutable std::mutex mutex;
 
-    mutable std::array<uint8_t, BLSObject::SerSize> vecBytes;
+    mutable std::array<uint8_t, BLSObject::SerSize> vecBytes{};
 
     mutable BLSObject obj;
     mutable bool objInitialized{false};
@@ -403,7 +403,6 @@ class CBLSLazyWrapper
 
 public:
     CBLSLazyWrapper() :
-        vecBytes{},
         bufLegacyScheme(bls::bls_legacy_scheme.load())
     {}
 

src/chain.h

@@ -35,7 +35,7 @@ static constexpr int64_t TIMESTAMP_WINDOW = MAX_FUTURE_BLOCK_TIME;
  */
 static constexpr int64_t MAX_BLOCK_TIME_GAP = 25 * 60;
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 class CBlockFileInfo
 {

src/coinjoin/coinjoin.h

@@ -34,7 +34,7 @@ class CChainLocksHandler;
 class CInstantSendManager;
 } // namespace llmq
 
-extern RecursiveMutex cs_main;
+extern RecursiveMutex cs_main; // NOLINT(readability-redundant-declaration)
 
 // timeouts
 static constexpr int COINJOIN_AUTO_TIMEOUT_MIN = 5;

src/crypto/ripemd160.cpp

@@ -239,7 +239,7 @@ void Transform(uint32_t* s, const unsigned char* chunk)
 
 ////// RIPEMD160
 
-CRIPEMD160::CRIPEMD160() : bytes(0)
+CRIPEMD160::CRIPEMD160()
 {
     ripemd160::Initialize(s);
 }

src/crypto/ripemd160.h

@@ -14,7 +14,7 @@ class CRIPEMD160
 private:
     uint32_t s[5];
     unsigned char buf[64];
-    uint64_t bytes;
+    uint64_t bytes{0};
 
 public:
     static const size_t OUTPUT_SIZE = 20;

src/crypto/sha1.cpp

@@ -146,7 +146,7 @@ void Transform(uint32_t* s, const unsigned char* chunk)
 
 ////// SHA1
 
-CSHA1::CSHA1() : bytes(0)
+CSHA1::CSHA1()
 {
     sha1::Initialize(s);
 }

src/crypto/sha1.h

@@ -14,7 +14,7 @@ class CSHA1
 private:
     uint32_t s[5];
     unsigned char buf[64];
-    uint64_t bytes;
+    uint64_t bytes{0};
 
 public:
     static const size_t OUTPUT_SIZE = 20;