Merge branch 'main' into fly

Author: danielres

lib/wik/telegram.ex

@@ -0,0 +1,99 @@
+defmodule Wik.Telegram do
+  @login_ttl :timer.hours(24)
+
+  def bot_token, do: Application.get_env(:wik, :bot_token)
+
+  def valid_telegram_auth?(params, miniapp?) do
+    # Get the received hash from params and remove it from the map.
+    check_hash = Map.get(params, "hash") |> String.downcase()
+
+    # Compute the secret key: SHA256(bot_token) in binary.
+    secret_key =
+      if miniapp? do
+        :crypto.mac(:hmac, :sha256, "WebAppData", bot_token())
+      else
+        :crypto.hash(:sha256, bot_token())
+      end
+
+    # Create the data-check string.
+    data_check_string =
+      params
+      |> Map.delete("hash")
+      |> Enum.map(fn {k, v} -> "#{k}=#{v}" end)
+      |> Enum.sort()
+      |> Enum.join("\n")
+
+    # Compute the HMAC-SHA256 of the data-check string with the secret key.
+    computed_hash =
+      :crypto.mac(:hmac, :sha256, secret_key, data_check_string)
+      |> Base.encode16(case: :lower)
+      |> String.downcase()
+
+    # Optionally, check that the authentication is not older than 24 hours.
+    auth_date =
+      case Map.get(params, "auth_date") do
+        nil -> 0
+        date when is_binary(date) -> String.to_integer(date)
+        date when is_integer(date) -> date
+      end
+
+    current_time = System.os_time(:second)
+
+    outdated? = current_time - auth_date > @login_ttl
+
+    cond do
+      computed_hash != check_hash ->
+        false
+
+      outdated? ->
+        false
+
+      true ->
+        true
+    end
+  end
+
+  def fetch_user_groups(telegram_user_id) do
+    # For each group, check if the user is a member.
+    all_groups = Wik.Groups.list_groups()
+
+    filtered =
+      all_groups
+      |> Enum.filter(fn group ->
+        user_member_of?(group, telegram_user_id, bot_token())
+      end)
+
+    serialized =
+      filtered
+      |> Enum.map(fn group ->
+        %{
+          id: group.id,
+          name: group.name,
+          slug: group.slug
+        }
+      end)
+
+    serialized
+  end
+
+  defp user_member_of?(group, telegram_user_id, bot_token) do
+    url =
+      "https://api.telegram.org/bot#{bot_token}/getChatMember?chat_id=#{group.id}&user_id=#{telegram_user_id}"
+
+    req = Finch.build(:get, url)
+
+    case Finch.request(req, WikWeb.Finch) do
+      {:ok, %{status: 200, body: body}} ->
+        case Jason.decode(body) do
+          {:ok, %{"ok" => true, "result" => %{"status" => status}}} ->
+            status in ["member", "administrator", "creator"]
+
+          _ ->
+            false
+        end
+
+      _ ->
+        false
+    end
+  end
+end

lib/wik/user.ex

@@ -8,15 +8,22 @@ defmodule Wik.Users do
 
   alias Wik.Users.User
 
-  def persist_session_user(session_user) do
-    session_user
-    |> Map.put(:telegram_id, session_user.id)
-    |> Map.delete(:id)
-    |> create_or_update_user_by_telegram_id()
+  @doc """
+  Persists a session user to the database and returns the database user.
+  """
+
+  # def persist_session_user(session_user) do
+  #   session_user
+  #   |> create_or_update_user_by_telegram_id()
+  # end
+
+  def find_user_by_telegram_id(telegram_id) do
+    Repo.one(from u in User, where: u.telegram_id == ^telegram_id)
   end
 
-  defp create_or_update_user_by_telegram_id(user_data) do
-    case Repo.one(from u in User, where: u.telegram_id == ^user_data.telegram_id) do
+  def create_or_update_user_by_telegram_id(user_data) do
+    # case Repo.one(from u in User, where: u.telegram_id == ^user_data.telegram_id) do
+    case find_user_by_telegram_id(user_data.telegram_id) do
       nil ->
         create_user(user_data)
 
@@ -118,4 +125,32 @@ defmodule Wik.Users do
   def change_user(%User{} = user, attrs \\ %{}) do
     User.changeset(user, attrs)
   end
+
+  @doc """
+  Updates a user's last_seen timestamp.
+  Only updates if the last update was more than "interval" seconds ago to reduce DB load.
+  """
+  def update_last_seen(%User{} = user) do
+    now = DateTime.utc_now()
+    interval = 60
+    time_elapsed = DateTime.diff(now, user.last_seen, :second)
+    update? = user.last_seen == nil || time_elapsed > interval
+
+    if update?, do: update_user(user, %{last_seen: now})
+  end
+
+  def update_last_seen(user_id) do
+    # Convert to string if it's not already
+    # user_id = to_string(user_id)
+
+    case Repo.get(User, user_id) do
+      nil ->
+        # User doesn't exist in the database
+        IO.warn("[Users.update_last_seen(user_id)] User with ID #{user_id} not found.")
+        {:error, :user_not_found}
+
+      user ->
+        update_last_seen(user)
+    end
+  end
 end

lib/wik/users.ex

@@ -26,6 +26,7 @@ defmodule Wik.Users.User do
       :photo_url,
       :last_seen
     ])
+    |> update_change(:telegram_id, &to_string/1)
     |> unique_constraint(:telegram_id)
     |> validate_required([
       :telegram_id,

lib/wik/users/user.ex

@@ -7,9 +7,7 @@ defmodule WikWeb.SessionController do
     |> redirect(to: "/")
   end
 
-  def dev_login(conn, params) do
-    username = params["user"]
-
+  def dev_login(conn, _params) do
     all_groups = Wik.Groups.list_groups()
 
     serialized =
@@ -25,20 +23,22 @@ defmodule WikWeb.SessionController do
     img =
       "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABwAAAAcBAMAAACAI8KnAAABg2lDQ1BJQ0MgcHJvZmlsZQAAKJF9kT1Iw0AcxV9TpSKVDlYQcQhSneyioo61CkWoEGqFVh1Mrp/QpCFJcXEUXAsOfixWHVycdXVwFQTBDxB3wUnRRUr8X1JoEePBcT/e3XvcvQOERoWpZlcMUDXLSCXiYia7KgZeISCEAYxgRmamPidJSXiOr3v4+HoX5Vne5/4cfbm8yQCfSBxjumERbxBPb1o6533iMCvJOeJz4nGDLkj8yHXF5TfORYcFnhk20ql54jCxWOxgpYNZyVCJp4gjOVWjfCHjco7zFme1UmOte/IXBvPayjLXaQ4jgUUsQYIIBTWUUYGFKK0aKSZStB/38A85folcCrnKYORYQBUqZMcP/ge/uzULkxNuUjAOdL/Y9scoENgFmnXb/j627eYJ4H8GrrS2v9oAZj9Jr7e1yBEQ2gYurtuasgdc7gCDT7psyI7kpykUCsD7GX1TFui/BXrX3N5a+zh9ANLUVfIGODgExoqUve7x7p7O3v490+rvB903ctGnToVWAAAAIVBMVEVKHBxKHD5vKl68TqDKcrS8oE5OvLyFvE6eynK62Zv36fNZSEXTAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAAuIwAALiMBeKU/dgAAAAd0SU1FB+kCDxUqHL67UiAAAAAZdEVYdENvbW1lbnQAQ3JlYXRlZCB3aXRoIEdJTVBXgQ4XAAAAZklEQVQY02OYiQDT0mYy4OROSw1NQ+e6IIBbmgsBrrGxCULAGJ3LYGzitWoVkOm1aolLBzbuQkEg11GKMLcDL7cc2d5yIrjOxiBg4l6OyS0vBjKVjJWUjc2xcSECxiAeMVwEQOMCAM+GiLYSTcf8AAAAAElFTkSuQmCC"
 
-    user = %{
-      id: username,
+    dev_user_data = %{
+      telegram_id: "devuser1",
+      username: "devuser1",
       first_name: "Dev",
       last_name: "User",
-      auth_date: "2023-01-01",
-      username: username,
       photo_url: img,
+      auth_date: "2023-01-01",
       member_of: serialized
     }
 
-    Wik.Users.persist_session_user(user)
+    {:ok, dbuser} = Wik.Users.create_or_update_user_by_telegram_id(dev_user_data)
+
+    session_user = Map.put(dev_user_data, :id, dbuser.id)
 
     conn
-    |> put_session(:user, user)
+    |> put_session(:user, session_user)
     |> configure_session(renew: true)
     |> redirect(to: get_session(conn, :redirect_after_login) || "/")
   end

lib/wik_web/controllers/session_controller.ex

@@ -1,28 +1,19 @@
 defmodule WikWeb.TelegramAuthController do
   use WikWeb, :controller
-  alias Wik.User
-  @login_ttl :timer.hours(24)
+  alias Wik.Telegram
   require Logger
 
-  defp bot_token, do: Application.get_env(:wik, :bot_token)
-
-  def callback(conn, params) do
-    # params is a map with Telegram authentication data:
-    # e.g. %{"id" => "...", "first_name" => "...", "auth_date" => "...", "hash" => "..."}
-
-    if valid_telegram_auth?(params, false) do
-      user =
-        User.get_or_create_from_telegram(params, bot_token())
-        |> Map.delete("hash")
-        |> Map.delete("auth_date")
-
-      Wik.Users.persist_session_user(user)
+  def callback(conn, telegram_callback_response) do
+    if Telegram.valid_telegram_auth?(telegram_callback_response, false) do
+      session_user = make_session_user(telegram_callback_response)
 
       conn
-      |> put_session(:user, user)
+      |> put_session(:user, session_user)
       |> configure_session(renew: true)
       |> redirect(to: get_session(conn, :redirect_after_login) || "/")
     else
+      Logger.error("Invalid Telegram login")
+
       conn
       |> put_flash(:error, "Invalid Telegram login")
       |> redirect(to: "/")
@@ -32,15 +23,17 @@ defmodule WikWeb.TelegramAuthController do
   def miniapp(conn, _params) do
     with ["tma " <> init_data_raw] <- get_req_header(conn, "authorization"),
          params <- URI.decode_query(init_data_raw),
-         true <- valid_telegram_auth?(params, true) do
-      {:ok, params} = JSON.decode(params["user"])
+         true <- Telegram.valid_telegram_auth?(params, true) do
+      {:ok, telegram_callback_response} = JSON.decode(params["user"])
 
-      user = User.get_or_create_from_telegram(params, bot_token())
-      Wik.Users.persist_session_user(user)
+      session_user = make_session_user(telegram_callback_response)
 
       conn
-      |> put_session(:user, user)
-      |> put_flash(:info, "Welcome #{user.first_name} #{user.last_name} (#{user.username})!")
+      |> put_session(:user, session_user)
+      |> put_flash(
+        :info,
+        "Welcome #{session_user.first_name} #{session_user.last_name} (#{session_user.username})!"
+      )
       |> json(%{success: true})
     else
       _ ->
@@ -52,53 +45,23 @@ defmodule WikWeb.TelegramAuthController do
     end
   end
 
-  defp valid_telegram_auth?(params, miniapp?) do
-    # Get the received hash from params and remove it from the map.
-    check_hash = Map.get(params, "hash") |> String.downcase()
-
-    # Compute the secret key: SHA256(bot_token) in binary.
-    secret_key =
-      if miniapp? do
-        :crypto.mac(:hmac, :sha256, "WebAppData", bot_token())
-      else
-        :crypto.hash(:sha256, bot_token())
-      end
-
-    # Create the data-check string.
-    data_check_string =
-      params
-      |> Map.delete("hash")
-      |> Enum.map(fn {k, v} -> "#{k}=#{v}" end)
-      |> Enum.sort()
-      |> Enum.join("\n")
+  def make_session_user(res) do
+    telegram_user_data = %{
+      telegram_id: "#{res["id"]}",
+      first_name: res["first_name"],
+      last_name: res["last_name"],
+      auth_date: res["auth_date"],
+      username: res["username"],
+      photo_url: res["photo_url"]
+    }
 
-    # Compute the HMAC-SHA256 of the data-check string with the secret key.
-    computed_hash =
-      :crypto.mac(:hmac, :sha256, secret_key, data_check_string)
-      |> Base.encode16(case: :lower)
-      |> String.downcase()
+    {:ok, dbuser} = Wik.Users.create_or_update_user_by_telegram_id(telegram_user_data)
 
-    # Optionally, check that the authentication is not older than 24 hours.
-    auth_date =
-      case Map.get(params, "auth_date") do
-        nil -> 0
-        date when is_binary(date) -> String.to_integer(date)
-        date when is_integer(date) -> date
-      end
+    session_user =
+      telegram_user_data
+      |> Map.put(:id, dbuser.id)
+      |> Map.put(:member_of, Telegram.fetch_user_groups(res["id"]))
 
-    current_time = System.os_time(:second)
-
-    outdated? = current_time - auth_date > @login_ttl
-
-    cond do
-      computed_hash != check_hash ->
-        false
-
-      outdated? ->
-        false
-
-      true ->
-        true
-    end
+    session_user
   end
 end