[BUG] npm package contains extra files

[rubiesonthesky]

Describe the bug

When looking at the code in npmjs.org (https://www.npmjs.com/package/danger?activeTab=code), you can see that there are a lot extra files that do not need to be included to the package. The size of danger is already big, so it would be nice to reduce the install size even a little bit.

Paths that could be added to .npmignore

• .github
• .eslintignore
• .eslintrc.json
• .gitattributes
• .pre-commit-config.yaml
• .prettierignore
• .release-it.json
• CHANGELOG.md
• CONTRIBUTING.md
• Dockerfile
• VISION.md
• tsconfig.spec.json

Total would be around 90 kB saved. It's not that much of the total size of 1.43 MB, but at least something.

[orta]

Seems reasonable to me

[v1rtl]

instead of npmignore I suggest files in package.json instead. npmignore is known for causing issues

[glensc]

I suggest creating .npmignore with whitelisting mode:

*
!/dist/**/*
!/package.json
!/CHANGELOG.md
!/README.md

The logic is:

1. Exclude everything
2. Use ! to specify what files to include.

But worth testing it over, I know it works with yarn 1.x, npm different versions may differ.

[glensc]

But for now, I just took the list and inserted it (easier)

• Build: Update .npmignore to exclude additional files #1499

[glensc]

Merged: #1499

[glensc]

I don't think anybody is doing the whitelist based gitignores:

• [BUG] npm package contains extra files #1489 (comment)

so, this can be just closed

[glensc]

@rubiesonthesky, @orta close?

[glensc]

First this looked like it's not released, but there seems to be some mess with git tags:

• [BUG] 13.0.7 release missing from git tags #1507

Also, the changelog is messed up (I'm working on a pr).