[BUG] Bitbucket Cloud cannot comment entire file

[alessandro308]

Describe the bug
warn(message, fileName) adds the message into the mainComment rather than adding a file comment

Here an example of entire file comment:

This happens because a warning is matched with

export const isInline = (violation: Violation): boolean => violation.file !== undefined && violation.line !== undefined

but, in case of Bitbucket, the line is not mandatory.

I have no idea how to fix it because looks like that is a BB specific behaviour and at the inlineResults function we don't have context on the platform, right?

I'm happy to help to find and implement a fix if you can give me some hint...

I know that I may implement this with a custom API but in that case I'm going to lose all the check to update current comments, right?

[fbartho]

The relevant files for you are probably here:

• https://github.com/danger/danger-js/blob/main/source/platforms/BitBucketCloud.ts
• https://github.com/danger/danger-js/blob/main/source/platforms/BitBucketServer.ts

You can probably do something by passing 0 for the line-number so that violation.line !== undefined and then you can update the createInlineComment in either/both of the above files to do what you want to do.

[alessandro308]

Ah, clever! I'll try it!