Add member_for_more_than_three_years account attribute

Return the new member_for_more_than_three_years boolean in the account
attributes response. Uses the same 360-day-year convention as the
existing one-year check (3 × 360 = 1080 days). The total membership
time is now computed once and reused for both thresholds.

Companion to damus-io/damus#3592.

Signed-off-by: alltheseas <alltheseas@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: alltheseas

src/user_management.js

@@ -179,8 +179,11 @@ function get_account_info_payload(subscriber_number, account, authenticated = fa
   const account_active = (account.expiry && current_time() < account.expiry) ? true : false
   // We consider one year to be 360 days, to be a bit lenient with users who might have a few days of downtime in their subscription, and make sure everyone who roughly got a year of service gets the benefit during the announcement.
   const one_year_in_seconds = 360 * 24 * 60 * 60
+  const three_years_in_seconds = 3 * one_year_in_seconds
   // Performance optimization: We only calculate the total membership time if the account is active
-  const member_for_more_than_one_year = account_active ? total_active_membership_time(account) > one_year_in_seconds : false
+  const total_membership_time = account_active ? total_active_membership_time(account) : 0
+  const member_for_more_than_one_year = total_membership_time > one_year_in_seconds
+  const member_for_more_than_three_years = total_membership_time > three_years_in_seconds
 
 
   return {
@@ -192,6 +195,7 @@ function get_account_info_payload(subscriber_number, account, authenticated = fa
     testflight_url: (authenticated && account_active) ? process.env.TESTFLIGHT_URL : null,
     attributes: {
       member_for_more_than_one_year: member_for_more_than_one_year,
+      member_for_more_than_three_years: member_for_more_than_three_years,
     }
   }
 }

test/router_config.test.js

@@ -3,6 +3,7 @@ const express = require('express');
 const config_router = require('../src/router_config.js').config_router;
 const nostr = require('nostr');
 const current_time = require('../src/utils.js').current_time;
+const { get_account_info_payload } = require('../src/user_management.js');
 const { supertest_client } = require('./controllers/utils.js');
 const { v4: uuidv4 } = require('uuid')
 
@@ -92,7 +93,8 @@ test('config_router - Account management routes', async (t) => {
       active: true,
       testflight_url: null,
       attributes: {
-        member_for_more_than_one_year: false
+        member_for_more_than_one_year: false,
+        member_for_more_than_three_years: false
       }
     };
     t.same(res.body, expectedData, 'Response should match expected value');
@@ -101,3 +103,93 @@ test('config_router - Account management routes', async (t) => {
 
   t.end();
 });
+
+test('get_account_info_payload - membership tenure attributes', async (t) => {
+  const one_year_in_seconds = 360 * 24 * 60 * 60
+
+  t.test('account with < 1080 days returns false for both tenure attributes', async (t) => {
+    const account = {
+      pubkey: 'abc123',
+      created_at: current_time() - 60 * 60 * 24 * 30,
+      expiry: current_time() + 60 * 60 * 24 * 30,
+      transactions: [{
+        type: 'iap',
+        id: '1',
+        start_date: current_time() - 60 * 60 * 24 * 30,
+        end_date: current_time() + 60 * 60 * 24 * 30,
+        purchased_date: current_time() - 60 * 60 * 24 * 30,
+        duration: null
+      }]
+    }
+    const payload = get_account_info_payload(1, account)
+    t.equal(payload.attributes.member_for_more_than_one_year, false)
+    t.equal(payload.attributes.member_for_more_than_three_years, false)
+    t.end()
+  })
+
+  t.test('account with > 1080 days returns true for both tenure attributes', async (t) => {
+    const total_duration = 3 * one_year_in_seconds + 1
+    const account = {
+      pubkey: 'abc123',
+      created_at: current_time() - total_duration,
+      expiry: current_time() + 60 * 60 * 24 * 30,
+      transactions: [{
+        type: 'iap',
+        id: '1',
+        start_date: current_time() - total_duration,
+        end_date: current_time(),
+        purchased_date: current_time() - total_duration,
+        duration: null
+      }]
+    }
+    const payload = get_account_info_payload(1, account)
+    t.equal(payload.attributes.member_for_more_than_one_year, true)
+    t.equal(payload.attributes.member_for_more_than_three_years, true)
+    t.end()
+  })
+
+  t.test('account with > 360 days but < 1080 days returns true only for one year', async (t) => {
+    const total_duration = one_year_in_seconds + 1
+    const account = {
+      pubkey: 'abc123',
+      created_at: current_time() - total_duration,
+      expiry: current_time() + 60 * 60 * 24 * 30,
+      transactions: [{
+        type: 'iap',
+        id: '1',
+        start_date: current_time() - total_duration,
+        end_date: current_time(),
+        purchased_date: current_time() - total_duration,
+        duration: null
+      }]
+    }
+    const payload = get_account_info_payload(1, account)
+    t.equal(payload.attributes.member_for_more_than_one_year, true)
+    t.equal(payload.attributes.member_for_more_than_three_years, false)
+    t.end()
+  })
+
+  t.test('inactive account returns false for both tenure attributes', async (t) => {
+    const total_duration = 3 * one_year_in_seconds + 1
+    const account = {
+      pubkey: 'abc123',
+      created_at: current_time() - total_duration,
+      expiry: current_time() - 1, // expired
+      transactions: [{
+        type: 'iap',
+        id: '1',
+        start_date: current_time() - total_duration,
+        end_date: current_time() - 1,
+        purchased_date: current_time() - total_duration,
+        duration: null
+      }]
+    }
+    const payload = get_account_info_payload(1, account)
+    t.equal(payload.active, false)
+    t.equal(payload.attributes.member_for_more_than_one_year, false)
+    t.equal(payload.attributes.member_for_more_than_three_years, false)
+    t.end()
+  })
+
+  t.end()
+});