Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Commit bdd6f6b

Browse files
authored
Merge branch 'main' into dependabot/npm_and_yarn/moment-2.29.4
2 parents c454478 + 97eec25 commit bdd6f6b

6 files changed

Lines changed: 29 additions & 17 deletions

File tree

src/components/CreateProjectModal/index.tsx

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import {
2525
EMPTY_DATASET_CREATE_PROJECT_DATASET_TYPE_VALUE,
2626
EXISTING_DATASET_CREATE_PROJECT_DATASET_TYPE_VALUE,
2727
ID_TOKEN_NAME,
28+
MAX_DATASET_IMAGES,
2829
MAX_DATASET_IMAGES_CREATE_PROJECT,
2930
MAX_PROJECT_DESCRIPTION_CHARACTER_LENGTH,
3031
MIN_DATASET_IMAGES_CREATE_PROJECT,
@@ -123,7 +124,11 @@ const CreateProjectDatasetTypeControl = function (
123124
if (selectedPrebuildDataset) {
124125
setPrebuildDataset(selectedPrebuildDataset);
125126
setNumberOfDatasetImages(
126-
selectedPrebuildDataset.totalImage
127+
selectedPrebuildDataset?.totalImage &&
128+
selectedPrebuildDataset.totalImage > MAX_DATASET_IMAGES
129+
? MAX_DATASET_IMAGES
130+
: selectedPrebuildDataset?.totalImage ||
131+
MIN_DATASET_IMAGES_CREATE_PROJECT
127132
);
128133
}
129134
}}
@@ -139,7 +144,7 @@ const CreateProjectDatasetTypeControl = function (
139144
/>
140145
</Box>
141146
<Typography variant="body2" mt={2}>
142-
Number of dataset images:
147+
Number of images:
143148
</Typography>
144149
<Box display="flex" alignItems="center" columnGap={1} pl={1}>
145150
<Slider
@@ -150,8 +155,11 @@ const CreateProjectDatasetTypeControl = function (
150155
onChange={onChangeNumberOfDatasetImagesSlider}
151156
min={MIN_DATASET_IMAGES_CREATE_PROJECT}
152157
max={
153-
prebuildDataset?.totalImage ||
154-
MIN_DATASET_IMAGES_CREATE_PROJECT
158+
prebuildDataset?.totalImage &&
159+
prebuildDataset.totalImage > MAX_DATASET_IMAGES
160+
? MAX_DATASET_IMAGES
161+
: prebuildDataset?.totalImage ||
162+
MIN_DATASET_IMAGES_CREATE_PROJECT
155163
}
156164
disabled={isCreatingProject}
157165
/>
@@ -163,8 +171,11 @@ const CreateProjectDatasetTypeControl = function (
163171
inputProps={{
164172
min: MIN_DATASET_IMAGES_CREATE_PROJECT,
165173
max:
166-
prebuildDataset?.totalImage ||
167-
MIN_DATASET_IMAGES_CREATE_PROJECT,
174+
prebuildDataset?.totalImage &&
175+
prebuildDataset.totalImage > MAX_DATASET_IMAGES
176+
? MAX_DATASET_IMAGES
177+
: prebuildDataset?.totalImage ||
178+
MIN_DATASET_IMAGES_CREATE_PROJECT,
168179
type: "number",
169180
"aria-labelledby": "input-number-of-dataset-images-slider",
170181
}}

src/components/FeedbackComponent/FeedbackForm.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,8 @@ export const FeedbackFormSlack = function ({
329329
if (onSendFail) onSendFail();
330330
resolve({ action: FeedbackFormAction.NO_ACTION });
331331
});
332+
} else {
333+
resolve({ action: FeedbackFormAction.NO_ACTION });
332334
}
333335
});
334336

src/components/TooltipToggleButton/index.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ type TooltipToggleButtonProps = ToggleButtonProps & {
77
};
88

99
const TooltipToggleButton: VFC<TooltipToggleButtonProps> = forwardRef(
10-
({ TooltipProps, ...props }, ref) => {
11-
return (
12-
<Tooltip {...TooltipProps}>
13-
<ToggleButton ref={ref} {...props} />
14-
</Tooltip>
15-
);
16-
}
10+
({ TooltipProps, ...props }, ref) => (
11+
<Tooltip {...TooltipProps}>
12+
<ToggleButton ref={ref} {...props} />
13+
</Tooltip>
14+
)
1715
);
1816

1917
export default TooltipToggleButton;

src/constants/defaultValues.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,3 +236,5 @@ export const MAX_SIZE_FEEDBACK_ATTACHED_FILE = 2000000;
236236

237237
export const QUIT_FEEDBACK_ALERT_MESSAGE =
238238
"Your feedback content will be lost. Are you sure you want to quit?";
239+
240+
export const MAX_DATASET_IMAGES = 800;

src/routes/AnnotationPage/Editor/Layer/DetectedRectangleDrawLayer.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,13 @@ function DetectedRectangleDrawLayer({
9090
<Rect
9191
x={-FULL_PADDING_VALUE}
9292
y={-FULL_PADDING_VALUE}
93-
width={2 * currentAnnotationFile.width}
94-
height={2 * currentAnnotationFile.height}
93+
width={2 * FULL_PADDING_VALUE}
94+
height={2 * FULL_PADDING_VALUE}
9595
/>
9696
);
9797
}
9898
return null;
9999
};
100-
101100
return (
102101
<Layer
103102
ref={layer}

src/services/authApi.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const service = new Service(axios);
5454

5555
service.register({
5656
onResponse(response: any) {
57-
if (response && typeof response.data === "string") {
57+
if (response && typeof response.data === "string" && response.data !== "") {
5858
const apiData = JSON.parse(response.data);
5959

6060
if (

0 commit comments

Comments
 (0)