From c12dc13b8b880eabc7b433891941b1cf74bfb18d Mon Sep 17 00:00:00 2001
From: Chris Bongers <chrisbongers@gmail.com>
Date: Thu, 23 Jul 2026 16:21:31 +0200
Subject: [PATCH] fix(sentiment): hide sources with no comments

---
 .../CommunitySentimentBreakdown.spec.tsx      | 52 +++++++++++++++++--
 .../focus/CommunitySentimentBreakdown.tsx     | 30 +++++------
 2 files changed, 64 insertions(+), 18 deletions(-)

diff --git a/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.spec.tsx b/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.spec.tsx
index 179c1b14c4..d404e4cddd 100644
--- a/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.spec.tsx
+++ b/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.spec.tsx
@@ -33,12 +33,12 @@ const createData = (
 });
 
 describe('CommunitySentimentBreakdown', () => {
-  it('hides the source lean and shows concise empty copy when a source has no comments', () => {
+  it('does not render a source row when that source has no comments', () => {
     render(<CommunitySentimentBreakdown data={createData()} />);
 
-    expect(screen.getByText('Hacker News')).toBeInTheDocument();
+    expect(screen.queryByText('Hacker News')).not.toBeInTheDocument();
     expect(screen.queryByText('Mixed')).not.toBeInTheDocument();
-    expect(screen.getByText('No comments yet')).toBeInTheDocument();
+    expect(screen.queryByText('No comments yet')).not.toBeInTheDocument();
     expect(
       screen.queryByText(
         'No comments were present, so no community signal is available.',
@@ -46,6 +46,52 @@ describe('CommunitySentimentBreakdown', () => {
     ).not.toBeInTheDocument();
   });
 
+  it('keeps the rest of the breakdown when one source has no comments', () => {
+    render(
+      <CommunitySentimentBreakdown
+        data={createData({
+          pros: ['Developers like the practical examples.'],
+          bySource: [
+            {
+              source: 'hackernews',
+              lean: 'mixed',
+              note: 'No comments were present, so no community signal is available.',
+            },
+            {
+              source: 'lobsters',
+              lean: 'skeptical',
+              note: 'Developers want stronger benchmarks.',
+            },
+          ],
+          discussions: [
+            {
+              provider: 'hackernews',
+              url: 'https://news.ycombinator.com/item?id=1',
+              points: 2,
+              commentsCount: 0,
+            },
+            {
+              provider: 'lobsters',
+              url: 'https://lobste.rs/s/example',
+              points: 12,
+              commentsCount: 5,
+            },
+          ],
+        })}
+      />,
+    );
+
+    expect(
+      screen.getByText('Developers like the practical examples.'),
+    ).toBeInTheDocument();
+    expect(screen.queryByText('Hacker News')).not.toBeInTheDocument();
+    expect(screen.getByText('Lobsters')).toBeInTheDocument();
+    expect(screen.getByText('Skeptical')).toBeInTheDocument();
+    expect(
+      screen.getByText('Developers want stronger benchmarks.'),
+    ).toBeInTheDocument();
+  });
+
   it('keeps the source lean when comments are available', () => {
     render(
       <CommunitySentimentBreakdown
diff --git a/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.tsx b/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.tsx
index b900b8eaaf..1ce0c3f695 100644
--- a/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.tsx
+++ b/packages/shared/src/components/post/focus/CommunitySentimentBreakdown.tsx
@@ -161,8 +161,6 @@ const SourceRow = ({
   // The narrative row may not carry its own url; the raw discussion entry for
   // the same provider is the same thread, so use it as the link fallback.
   const linkUrl = url ?? discussion?.url;
-  const hasNoComments = discussion?.commentsCount === 0;
-  const displayNote = hasNoComments ? 'No comments yet' : note;
 
   const content = (
     <>
@@ -176,16 +174,14 @@ const SourceRow = ({
           >
             {label}
           </Typography>
-          {!hasNoComments && (
-            <span
-              className={classNames(
-                'inline-flex items-center rounded-6 px-1.5 py-0.5 font-bold typo-caption2',
-                chip.className,
-              )}
-            >
-              {chip.label}
-            </span>
-          )}
+          <span
+            className={classNames(
+              'inline-flex items-center rounded-6 px-1.5 py-0.5 font-bold typo-caption2',
+              chip.className,
+            )}
+          >
+            {chip.label}
+          </span>
           {discussion && (
             <Typography
               type={TypographyType.Caption2}
@@ -201,7 +197,7 @@ const SourceRow = ({
           type={TypographyType.Caption1}
           color={TypographyColor.Tertiary}
         >
-          {displayNote}
+          {note}
         </Typography>
       </div>
       {/* Always reserve the link slot so rows without a link stay aligned. */}
@@ -257,6 +253,10 @@ export const CommunitySentimentBreakdown = ({
       discussion,
     ]),
   );
+  const sourcesWithComments = bySource.filter((item) => {
+    const discussion = discussionByProvider.get(normalizeProvider(item.source));
+    return discussion?.commentsCount !== 0;
+  });
 
   return (
     <div className="flex animate-composer-in flex-col gap-4 border-t border-border-subtlest-tertiary pt-3">
@@ -271,11 +271,11 @@ export const CommunitySentimentBreakdown = ({
         </div>
       )}
 
-      {bySource.length > 0 && (
+      {sourcesWithComments.length > 0 && (
         <div className="flex flex-col gap-2.5">
           <BlockTitle>By community</BlockTitle>
           <div className="flex flex-col gap-1">
-            {bySource.map((item) => (
+            {sourcesWithComments.map((item) => (
               <SourceRow
                 key={item.source}
                 {...item}