linter/formatting

Author: landonshumway-ia

backend/compact-connect/lambdas/python/common/cc_common/data_model/data_client.py

@@ -2726,7 +2726,6 @@ def encumber_home_jurisdiction_license_privileges(
             # Add PUT transaction for privilege update record
             transaction_items.append(self._generate_put_transaction_item(privilege_update_record))
 
-
         # Execute transactions in batches of 100 (DynamoDB limit)
         batch_size = 100
         while transaction_items:
@@ -2742,9 +2741,9 @@ def encumber_home_jurisdiction_license_privileges(
 
         logger.info('Successfully encumbered associated privileges for license')
 
-        return (unencumbered_privileges_associated_with_license
-                + previously_encumbered_privileges_associated_with_license)
-
+        return (
+            unencumbered_privileges_associated_with_license + previously_encumbered_privileges_associated_with_license
+        )
 
     @logger_inject_kwargs(logger, 'compact', 'provider_id', 'jurisdiction', 'license_type_abbreviation')
     def lift_home_jurisdiction_license_privilege_encumbrances(

backend/compact-connect/lambdas/python/common/cc_common/data_model/provider_record_util.py

@@ -245,8 +245,8 @@ def populate_provider_record(
 
     @staticmethod
     def get_enriched_history_with_synthetic_updates_from_privilege(
-            privilege: dict,
-            history: list[dict],
+        privilege: dict,
+        history: list[dict],
     ) -> list[dict]:
         """
         Enrich the privilege history with 'synthetic updates'.
@@ -367,8 +367,7 @@ def get_enriched_history_with_synthetic_updates_from_privilege(
 
     @staticmethod
     def construct_simplified_privilege_history_object(
-            privilege_data: list[dict],
-            should_include_encumbrance_details: bool = True
+        privilege_data: list[dict], should_include_encumbrance_details: bool = True
     ) -> dict:
         """
         Construct a simplified list of history events to be easily consumed by the front end
@@ -393,10 +392,7 @@ def construct_simplified_privilege_history_object(
                 and should_include_encumbrance_details
             ):
                 event['note'] = event['encumbranceDetails']['clinicalPrivilegeActionCategory']
-            elif (
-                event['updateType'] == UpdateCategory.DEACTIVATION
-                and event.get('deactivationDetails')
-            ):
+            elif event['updateType'] == UpdateCategory.DEACTIVATION and event.get('deactivationDetails'):
                 event['note'] = event['deactivationDetails']['note']
 
         unsanitized_history = {

backend/compact-connect/lambdas/python/common/cc_common/data_model/schema/military_affiliation/api.py

@@ -65,4 +65,3 @@ class MilitaryAffiliationReadPrivateResponseSchema(ForgivingSchema):
     # this will only be present for compact admins
     documentKeys = List(String(required=True, allow_none=False), required=False, allow_none=False)
     downloadLinks = List(Dict(required=True, allow_none=False), required=False, allow_none=False)
-

backend/compact-connect/lambdas/python/common/cc_common/data_model/schema/privilege/record.py

@@ -51,6 +51,7 @@ class DeactivationDetailsSchema(Schema):
     deactivatedByStaffUserId = UUID(required=True, allow_none=False)
     deactivatedByStaffUserName = String(required=True, allow_none=False)
 
+
 class EncumbranceDetailsSchema(Schema):
     """
     Schema for tracking details about an encumbrance.
@@ -61,6 +62,7 @@ class EncumbranceDetailsSchema(Schema):
     # present if update is created by upstream license encumbrance
     licenseJurisdiction = Jurisdiction(required=False, allow_none=False)
 
+
 @BaseRecordSchema.register_schema('privilege')
 class PrivilegeRecordSchema(BaseRecordSchema, ValidatesLicenseTypeMixin):
     """

backend/compact-connect/lambdas/python/common/cc_common/data_model/schema/provider/api.py

@@ -85,6 +85,7 @@ class ProviderReadPrivateResponseSchema(ForgivingSchema):
     dateOfBirth = Raw(required=True, allow_none=False)
     ssnLastFour = String(required=False, allow_none=False, validate=Length(equal=4))
 
+
 class ProviderGeneralResponseSchema(ForgivingSchema):
     """
     Provider object fields that are sanitized for users with the 'readGeneral' permission.

backend/compact-connect/lambdas/python/common/common_test/test_data_generator.py

@@ -357,7 +357,7 @@ def generate_default_privilege_update(
 
     @staticmethod
     def put_default_privilege_update_record_in_provider_table(
-        value_overrides: dict | None = None
+        value_overrides: dict | None = None,
     ) -> PrivilegeUpdateData:
         """
         Creates a default privilege update and stores it in the provider table.

backend/compact-connect/lambdas/python/common/tests/unit/test_provider_record_util.py

@@ -879,9 +879,7 @@ def test_construct_simplified_privilege_history_object_returns_deactivation_note
         ]
 
         # Enrich the privilege history
-        history = ProviderRecordUtility.construct_simplified_privilege_history_object(
-            privilege_data
-        )
+        history = ProviderRecordUtility.construct_simplified_privilege_history_object(privilege_data)
 
         # Define the expected issuance update
         expected_history = {
@@ -896,7 +894,7 @@ def test_construct_simplified_privilege_history_object_returns_deactivation_note
                     'dateOfUpdate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'effectiveDate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'type': 'privilegeUpdate',
-                    'updateType': 'issuance'
+                    'updateType': 'issuance',
                 },
                 {
                     'createDate': datetime.fromisoformat('2025-06-16T00:00:00+04:00'),
@@ -905,8 +903,8 @@ def test_construct_simplified_privilege_history_object_returns_deactivation_note
                     'type': 'privilegeUpdate',
                     'updateType': 'deactivation',
                     'note': 'test deactivation note',
-                }
-            ]
+                },
+            ],
         }
 
         # Check that the history contains exactly one update with the expected values
@@ -959,9 +957,7 @@ def test_construct_simplified_privilege_history_object_returns_encumbrance_notes
         ]
 
         # Enrich the privilege history
-        history = ProviderRecordUtility.construct_simplified_privilege_history_object(
-            privilege_data
-        )
+        history = ProviderRecordUtility.construct_simplified_privilege_history_object(privilege_data)
 
         # Define the expected issuance update
         expected_history = {
@@ -976,7 +972,7 @@ def test_construct_simplified_privilege_history_object_returns_encumbrance_notes
                     'dateOfUpdate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'effectiveDate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'type': 'privilegeUpdate',
-                    'updateType': 'issuance'
+                    'updateType': 'issuance',
                 },
                 {
                     'createDate': datetime.fromisoformat('2025-06-16T00:00:00+04:00'),
@@ -985,8 +981,8 @@ def test_construct_simplified_privilege_history_object_returns_encumbrance_notes
                     'type': 'privilegeUpdate',
                     'updateType': 'encumbrance',
                     'note': 'Non-compliance With Requirements',
-                }
-            ]
+                },
+            ],
         }
 
         # Check that the history contains exactly one update with the expected values
@@ -1040,9 +1036,7 @@ def test_construct_simplified_privilege_history_object_does_not_return_encumbran
         ]
 
         # Enrich the privilege history
-        history = ProviderRecordUtility.construct_simplified_privilege_history_object(
-            privilege_data, False
-        )
+        history = ProviderRecordUtility.construct_simplified_privilege_history_object(privilege_data, False)
 
         # Define the expected issuance update
         expected_history = {
@@ -1057,22 +1051,23 @@ def test_construct_simplified_privilege_history_object_does_not_return_encumbran
                     'dateOfUpdate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'effectiveDate': datetime.fromisoformat('2024-01-01T00:00:00+00:00'),
                     'type': 'privilegeUpdate',
-                    'updateType': 'issuance'
+                    'updateType': 'issuance',
                 },
                 {
                     'createDate': datetime.fromisoformat('2025-06-16T00:00:00+04:00'),
                     'dateOfUpdate': datetime.fromisoformat('2025-06-16T00:00:00+04:00'),
                     'effectiveDate': datetime.fromisoformat('2025-06-16T00:00:00+04:00'),
                     'type': 'privilegeUpdate',
                     'updateType': 'encumbrance',
-                }
-            ]
+                },
+            ],
         }
 
         # Check that the history contains exactly one update with the expected values
         self.maxDiff = None
         self.assertEqual(expected_history, history)
 
+
 class TestProviderRecordUtilityActiveSinceCalculation(TstLambdas):
     def setUp(self):
         from cc_common.data_model.provider_record_util import ProviderRecordUtility

backend/compact-connect/lambdas/python/data-events/handlers/encumbrance_events.py

@@ -209,7 +209,7 @@ def license_encumbrance_listener(message: dict):
         license_type_abbreviation=license_type_abbreviation,
         effective_date=effective_date,
         adverse_action_category=adverse_action_category,
-        adverse_action_id=adverse_action_id
+        adverse_action_id=adverse_action_id,
     ):
         logger.info('Processing license encumbrance event')
 

backend/compact-connect/lambdas/python/data-events/tests/function/test_encumbrance_events.py

@@ -235,11 +235,14 @@ def test_license_encumbrance_listener_handles_all_privileges_already_encumbered(
         self.assertEqual(1, len(privilege_update_records['Items']))
         update_record = privilege_update_records['Items'][0]
         update_encumbrance_details = update_record['encumbranceDetails']
-        self.assertEqual({
-            'adverseActionId': DEFAULT_ADVERSE_ACTION_ID,
-            'licenseJurisdiction': 'oh',
-            'clinicalPrivilegeActionCategory': 'Unsafe Practice or Substandard Care'
-        }, update_encumbrance_details)
+        self.assertEqual(
+            {
+                'adverseActionId': DEFAULT_ADVERSE_ACTION_ID,
+                'licenseJurisdiction': 'oh',
+                'clinicalPrivilegeActionCategory': 'Unsafe Practice or Substandard Care',
+            },
+            update_encumbrance_details,
+        )
 
         # Verify one event was published for the privilege update
         mock_publish_event.assert_called_once()

backend/compact-connect/lambdas/python/feature-flag/feature_flag_client.py

@@ -82,7 +82,6 @@ def check_flag(self, request: FeatureFlagRequest) -> FeatureFlagResult:
         :return: FeatureFlagResult indicating if flag is enabled
         :raises FeatureFlagException: If flag check fails
         """
-        pass
 
     def _get_secret(self, secret_name: str) -> dict[str, Any]:
         """
@@ -103,9 +102,7 @@ def _get_secret(self, secret_name: str) -> dict[str, Any]:
             response = client.get_secret_value(SecretId=secret_name)
 
             # Parse the secret string as JSON
-            secret_data = json.loads(response['SecretString'])
-
-            return secret_data
+            return json.loads(response['SecretString'])
 
         except ClientError as e:
             error_code = e.response['Error']['Code']
@@ -120,14 +117,10 @@ def _get_secret(self, secret_name: str) -> dict[str, Any]:
 class FeatureFlagException(Exception):
     """Base exception for feature flag operations"""
 
-    pass
-
 
 class FeatureFlagValidationException(FeatureFlagException):
     """Exception raised when feature flag validation fails"""
 
-    pass
-
 
 # Implementing Classes
 
@@ -174,8 +167,8 @@ def __init__(self, environment: str):
         self._is_initialized = False
 
         # Retrieve StatSig configuration from AWS Secrets Manager
+        secret_name = f'compact-connect/env/{environment}/statsig/credentials'
         try:
-            secret_name = f'compact-connect/env/{environment}/statsig/credentials'
             secret_data = self._get_secret(secret_name)
             self._server_secret_key = secret_data.get('serverKey')
 
@@ -252,11 +245,10 @@ def check_flag(self, request: FeatureFlagRequest) -> FeatureFlagResult:
                 flag_name=request.flagName,
             )
 
-        except Exception as e:
+        except (FeatureFlagException, FeatureFlagValidationException) as e:
             # If it's already a FeatureFlagException, re-raise it
-            if isinstance(e, (FeatureFlagException, FeatureFlagValidationException)):
-                raise
-
+            raise e
+        except Exception as e:
             # Otherwise, wrap it in a FeatureFlagException
             raise FeatureFlagException(f"Failed to check feature flag '{request.flagName}': {e}") from e