Resolves #309 - Adds mechanism by which to capture and read browser logs#349
Merged
Conversation
But as-yet, no tests for it. That will need some further work.
I forgot to add the logging preference as I did in other places.
Turns out BrowserStack was a red herring. The failures I'm seeing are from a local webdriver, I just forgot to configure it.
It has become apparent that this is never going to work well enough for prod usage. Note added to the ticket signposting why.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #309 when completed. This allows Screenplay to read web browser console logs. Support for this varies by WebDriver (browser); this deals with two viable techniques.