Fix rubocop offenses and test failures

- Use attr_reader for tracing_langsmith_compat (custom setter defined)
- Consolidate build_request_attributes params into config hash
- Use allow/have_received pattern for logger spy tests
- Fix Model::Info double in tests

Author: pcomans

lib/ruby_llm/chat.rb

@@ -168,10 +168,12 @@ def complete_with_span(span, &)
             model: @model,
             provider: @provider.slug,
             session_id: @session_id,
-            temperature: @temperature,
-            metadata: @metadata,
-            langsmith_compat: langsmith,
-            metadata_prefix: @config.tracing_metadata_prefix
+            config: {
+              temperature: @temperature,
+              metadata: @metadata,
+              langsmith_compat: langsmith,
+              metadata_prefix: @config.tracing_metadata_prefix
+            }
           )
         )
 

lib/ruby_llm/configuration.rb

@@ -51,8 +51,9 @@ class Configuration
                   :tracing_enabled,
                   :tracing_log_content,
                   :tracing_max_content_length,
-                  :tracing_metadata_prefix,
-                  :tracing_langsmith_compat
+                  :tracing_metadata_prefix
+
+    attr_reader :tracing_langsmith_compat
 
     def initialize
       @request_timeout = 300

lib/ruby_llm/instrumentation.rb

@@ -153,17 +153,16 @@ def build_completion_attributes(message, max_length:, langsmith_compat: false)
           attrs
         end
 
-        def build_request_attributes(model:, provider:, session_id:, temperature: nil, metadata: nil,
-                                     langsmith_compat: false, metadata_prefix: 'metadata')
+        def build_request_attributes(model:, provider:, session_id:, config: {})
           attrs = {
             'gen_ai.system' => provider.to_s,
             'gen_ai.operation.name' => 'chat',
             'gen_ai.request.model' => model.id,
             'gen_ai.conversation.id' => session_id
           }
-          attrs['langsmith.span.kind'] = 'LLM' if langsmith_compat
-          attrs['gen_ai.request.temperature'] = temperature if temperature
-          build_metadata_attributes(attrs, metadata, prefix: metadata_prefix) if metadata
+          attrs['langsmith.span.kind'] = 'LLM' if config[:langsmith_compat]
+          attrs['gen_ai.request.temperature'] = config[:temperature] if config[:temperature]
+          build_metadata_attributes(attrs, config[:metadata], prefix: config[:metadata_prefix]) if config[:metadata]
           attrs
         end
 

spec/ruby_llm/instrumentation_spec.rb

@@ -95,20 +95,23 @@
         RubyLLM.configure { |c| c.tracing_enabled = true }
         described_class.reset!
         allow(described_class).to receive(:otel_available?).and_return(false)
+        allow(RubyLLM.logger).to receive(:warn)
 
-        expect(RubyLLM.logger).to receive(:warn).with(/OpenTelemetry is not available/)
         expect(described_class.enabled?).to be false
+        expect(RubyLLM.logger).to have_received(:warn).with(/OpenTelemetry is not available/)
       end
 
       it 'only warns once per reset cycle' do
         RubyLLM.configure { |c| c.tracing_enabled = true }
         described_class.reset!
         allow(described_class).to receive(:otel_available?).and_return(false)
+        allow(RubyLLM.logger).to receive(:warn)
 
-        expect(RubyLLM.logger).to receive(:warn).once
         described_class.enabled?
         described_class.enabled?
         described_class.enabled?
+
+        expect(RubyLLM.logger).to have_received(:warn).once
       end
     end
 
@@ -419,7 +422,7 @@
     end
 
     describe '.build_request_attributes' do
-      let(:model) { instance_double(RubyLLM::Model, id: 'gpt-4') }
+      let(:model) { instance_double(RubyLLM::Model::Info, id: 'gpt-4') }
 
       it 'does not include langsmith.span.kind by default' do
         attrs = RubyLLM::Instrumentation::SpanBuilder.build_request_attributes(
@@ -438,11 +441,22 @@
           model: model,
           provider: :openai,
           session_id: 'session-123',
-          langsmith_compat: true
+          config: { langsmith_compat: true }
         )
 
         expect(attrs['langsmith.span.kind']).to eq 'LLM'
       end
+
+      it 'includes temperature when provided' do
+        attrs = RubyLLM::Instrumentation::SpanBuilder.build_request_attributes(
+          model: model,
+          provider: :openai,
+          session_id: 'session-123',
+          config: { temperature: 0.7 }
+        )
+
+        expect(attrs['gen_ai.request.temperature']).to eq 0.7
+      end
     end
 
     describe '.build_metadata_attributes' do