Skip to content

Commit 1843c79

Browse files
committed
Use io.Copy to avoid crash due to insufficient memory
1 parent 8a4d41a commit 1843c79

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 6.0.2 (2019/07/27)
4+
5+
* Use `io.Copy` to avoid crash due to insufficient memory
6+
37
## 6.0.1 (2019/07/24)
48

59
* Fix cron stopped after first trigger

internal/server/ftp/client.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"crypto/tls"
55
"fmt"
66
"io"
7-
"io/ioutil"
87
"os"
98
"regexp"
109
"time"
@@ -108,12 +107,7 @@ func (c *Client) Retrieve(path string, dest io.Writer) error {
108107
}
109108
defer resp.Close()
110109

111-
buf, err := ioutil.ReadAll(resp)
112-
if err != nil {
113-
return err
114-
}
115-
116-
_, err = dest.Write(buf)
110+
_, err = io.Copy(dest, resp)
117111
return err
118112
}
119113

0 commit comments

Comments
 (0)