Skip to content

Commit 1ba6b0e

Browse files
committed
fix(laravel): @children comment markers
1 parent 3e7668b commit 1ba6b0e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/laravel/src/View/NodeTransformers/CraftileChildrenTagTransformer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ protected function getCompiledCode(): string
6161
{
6262
return '<?php
6363
if (craftile()->inPreview()) {
64-
echo \'<!--BEGIN children \' . $block->id . \'-->\';
64+
echo \'<!--BEGIN children: \' . $block->id . \'-->\';
6565
}
6666
$__childrenFilePath = app(\\Craftile\\Laravel\\View\\BlockCacheManager::class)->getChildrenFilePath($block->id);
6767
if(file_exists($__childrenFilePath)) {
@@ -72,7 +72,7 @@ protected function getCompiledCode(): string
7272
require $__childrenFilePath;
7373
}
7474
if (craftile()->inPreview()) {
75-
echo \'<!--END children \' . $block->id . \'-->\';
75+
echo \'<!--END children: \' . $block->id . \'-->\';
7676
}
7777
?>';
7878
}

tests/laravel/Unit/View/NodeTransformers/CraftileChildrenTagTransformerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ function createMockChildrenComponentNode(string $prefix, array $parameters = [])
136136
$result = $transformer->transform($node, null);
137137

138138
expect($result)->toBeInstanceOf(LiteralNode::class);
139-
expect($result->content)->toContain('<!--BEGIN children');
140-
expect($result->content)->toContain('<!--END children');
139+
expect($result->content)->toContain('<!--BEGIN children: ');
140+
expect($result->content)->toContain('<!--END children: ');
141141
expect($result->content)->toContain('$block->id');
142142
});
143143

@@ -151,6 +151,6 @@ function createMockChildrenComponentNode(string $prefix, array $parameters = [])
151151

152152
expect($result)->toBeInstanceOf(LiteralNode::class);
153153
expect($result->content)->toContain('craftile()->inPreview()');
154-
expect($result->content)->toContain('echo \'<!--BEGIN children');
155-
expect($result->content)->toContain('echo \'<!--END children');
154+
expect($result->content)->toContain('echo \'<!--BEGIN children: ');
155+
expect($result->content)->toContain('echo \'<!--END children: ');
156156
});

0 commit comments

Comments
 (0)