Fix #14949: FP when passing resource to ctor

Author: Aaron Danen

lib/checkmemoryleak.cpp

@@ -517,7 +517,7 @@ void CheckMemoryLeakInClassImpl::check()
     // only check classes and structures
     for (const Scope * scope : symbolDatabase->classAndStructScopes) {
         for (const Variable &var : scope->varlist) {
-            if (!var.isStatic() && (var.isPointer() || var.isPointerArray())) {
+            if (!var.isStatic()) {
                 // allocation but no deallocation of private variables in public function..
                 const Token *tok = var.typeStartToken();
                 // Either it is of standard type or a non-derived type
@@ -1046,7 +1046,8 @@ void CheckMemoryLeakNoVarImpl::checkForUnreleasedInputArgument(const Scope *scop
             const AllocType alloc = getAllocationType(arg, 0);
             if (alloc == No)
                 continue;
-            if (alloc == New || alloc == NewArray) {
+            //if (alloc == New || alloc == NewArray) {
+            else {
                 const Token* typeTok = arg->next();
                 bool bail = !typeTok->isStandardType() &&
                             (!typeTok->valueType() ||

test/testmemleak.cpp

@@ -2628,6 +2628,23 @@ class TestMemleakNoVar : public TestFixture {
                       "[test.cpp:7:12]: (error) Allocation with f2, assert doesn't release it. [leakNoVarFunctionCall]\n"
                       "[test.cpp:8:12]: (error) Allocation with f3, assert doesn't release it. [leakNoVarFunctionCall]\n",
                       errout_str());
+        check("struct S {\n"
+              "    explicit S(int fd) {\n"
+              "        m_fd = fd;\n"
+              "    }\n"
+              "    ~S() {\n"
+              "        if (m_fd >= 0)\n"
+              "            close(m_fd); \n"
+              "    }\n"
+              "    int m_fd = -1;\n"
+              "};\n"
+              "S g(char *name) {\n"
+              "    return S(mkostemp(name, 0));\n"
+              "}\n"
+              "void f(char* ptr) {\n"
+              "    S s = g(ptr);\n"
+              "}\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void missingAssignment() {