Give render output a semi-opaque background for better visibility in dark mode docs

cpp-niel · cpp-niel · commit 49ada30fbfe4 · 2025-11-01T15:18:40.000+01:00
diff --git a/tests/approval_tests/approved_files/docs.accents.approved.svg b/tests/approval_tests/approved_files/docs.accents.approved.svg
@@ -94,6 +94,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-13" width="864" height="156" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="21.08941" y="29.453125"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.additional_accents.approved.svg b/tests/approval_tests/approved_files/docs.additional_accents.approved.svg
@@ -154,6 +154,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-31" width="864" height="372" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="21.08941" y="32.703993"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.additional_arrows.approved.svg b/tests/approval_tests/approved_files/docs.additional_arrows.approved.svg
@@ -247,6 +247,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-61" width="864" height="732" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.additional_binary_operators.approved.svg b/tests/approval_tests/approved_files/docs.additional_binary_operators.approved.svg
@@ -271,6 +271,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-67" width="864" height="804" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.additional_negations.approved.svg b/tests/approval_tests/approved_files/docs.additional_negations.approved.svg
@@ -145,6 +145,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-28" width="864" height="336" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.additional_relational_operators.approved.svg b/tests/approval_tests/approved_files/docs.additional_relational_operators.approved.svg
@@ -444,6 +444,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-124" width="864" height="1488" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.arrows.approved.svg b/tests/approval_tests/approved_files/docs.arrows.approved.svg
@@ -169,6 +169,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-40" width="864" height="480" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.big_ops.approved.svg b/tests/approval_tests/approved_files/docs.big_ops.approved.svg
@@ -109,6 +109,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-34" width="864" height="408" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.big_ops_integrals.approved.svg b/tests/approval_tests/approved_files/docs.big_ops_integrals.approved.svg
@@ -37,6 +37,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-16" width="864" height="192" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="29.969618"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.big_ops_limits.approved.svg b/tests/approval_tests/approved_files/docs.big_ops_limits.approved.svg
@@ -76,6 +76,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-15" width="720" height="180" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="16.972656" y="10.190972"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.binary_operators.approved.svg b/tests/approval_tests/approved_files/docs.binary_operators.approved.svg
@@ -166,6 +166,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-28" width="864" height="336" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.cauchy_integral.approved.svg b/tests/approval_tests/approved_files/docs.cauchy_integral.approved.svg
@@ -46,6 +46,7 @@
 </g>
 </g>
 </defs>
+<rect x="-34" y="-10" width="408" height="120" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="50"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.combining_symbols.approved.svg b/tests/approval_tests/approved_files/docs.combining_symbols.approved.svg
@@ -57,6 +57,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-10" width="864" height="120" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.delimiters.approved.svg b/tests/approval_tests/approved_files/docs.delimiters.approved.svg
@@ -270,6 +270,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-52" width="864" height="624" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.dots.approved.svg b/tests/approval_tests/approved_files/docs.dots.approved.svg
@@ -46,6 +46,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-10" width="864" height="120" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.fonts.approved.svg b/tests/approval_tests/approved_files/docs.fonts.approved.svg
@@ -265,6 +265,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-36" width="720" height="432" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.fractions.approved.svg b/tests/approval_tests/approved_files/docs.fractions.approved.svg
@@ -100,6 +100,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-25" width="960" height="300" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="12.956157" y="17.543403"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.functions.approved.svg b/tests/approval_tests/approved_files/docs.functions.approved.svg
@@ -171,6 +171,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-48" width="960" height="576" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.genfrac.approved.svg b/tests/approval_tests/approved_files/docs.genfrac.approved.svg
@@ -123,6 +123,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-22" width="960" height="264" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.greek_alphabet_lowercase.approved.svg b/tests/approval_tests/approved_files/docs.greek_alphabet_lowercase.approved.svg
@@ -154,6 +154,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-28" width="864" height="336" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.greek_alphabet_uppercase.approved.svg b/tests/approval_tests/approved_files/docs.greek_alphabet_uppercase.approved.svg
@@ -94,6 +94,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-13" width="864" height="156" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.letterlike.approved.svg b/tests/approval_tests/approved_files/docs.letterlike.approved.svg
@@ -412,6 +412,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-76" width="864" height="912" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.lines.approved.svg b/tests/approval_tests/approved_files/docs.lines.approved.svg
@@ -81,6 +81,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-6" width="720" height="72" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.negations.approved.svg b/tests/approval_tests/approved_files/docs.negations.approved.svg
@@ -139,6 +139,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-22" width="864" height="264" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.operatorname.approved.svg b/tests/approval_tests/approved_files/docs.operatorname.approved.svg
@@ -105,6 +105,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-6" width="720" height="72" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.punctuation.approved.svg b/tests/approval_tests/approved_files/docs.punctuation.approved.svg
@@ -121,6 +121,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-22" width="864" height="264" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.radicals.approved.svg b/tests/approval_tests/approved_files/docs.radicals.approved.svg
@@ -114,6 +114,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-22" width="960" height="264" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="4.774306" y="30.478516"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.relational_operators.approved.svg b/tests/approval_tests/approved_files/docs.relational_operators.approved.svg
@@ -178,6 +178,7 @@
 </g>
 </g>
 </defs>
+<rect x="-72" y="-31" width="864" height="372" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.sized_delimiters.approved.svg b/tests/approval_tests/approved_files/docs.sized_delimiters.approved.svg
@@ -153,6 +153,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-26" width="960" height="312" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.spaces.approved.svg b/tests/approval_tests/approved_files/docs.spaces.approved.svg
@@ -60,6 +60,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-15" width="960" height="180" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.subscripts_and_superscripts.approved.svg b/tests/approval_tests/approved_files/docs.subscripts_and_superscripts.approved.svg
@@ -138,6 +138,7 @@
 </g>
 </g>
 </defs>
+<rect x="-80" y="-10" width="960" height="120" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/docs.wide_accents.approved.svg b/tests/approval_tests/approved_files/docs.wide_accents.approved.svg
@@ -88,6 +88,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-10" width="720" height="120" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="13.888889" y="26.080729"/>
 </g>
diff --git a/tests/approval_tests/approved_files/mfl.MathML_torture_test.approved.svg b/tests/approval_tests/approved_files/mfl.MathML_torture_test.approved.svg
@@ -334,6 +334,7 @@
 </g>
 </g>
 </defs>
+<rect x="-120" y="-100" width="1440" height="1200" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/mfl.mathtext.approved.svg b/tests/approval_tests/approved_files/mfl.mathtext.approved.svg
@@ -490,6 +490,7 @@
 </g>
 </g>
 </defs>
+<rect x="-100" y="-80" width="1200" height="960" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="30"/>
 </g>
diff --git a/tests/approval_tests/approved_files/mfl.mfl.approved.svg b/tests/approval_tests/approved_files/mfl.mfl.approved.svg
@@ -328,6 +328,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-80" width="720" height="960" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="100" y="50"/>
 </g>
diff --git a/tests/approval_tests/approved_files/mfl.mfl_large.approved.svg b/tests/approval_tests/approved_files/mfl.mfl_large.approved.svg
@@ -145,6 +145,7 @@
 </g>
 </g>
 </defs>
+<rect x="-60" y="-80" width="720" height="960" fill="rgb(100%, 100%, 100%)" fill-opacity="0.5"/>
 <g fill="rgb(0%, 0%, 0%)" fill-opacity="1">
 <use xlink:href="#glyph-0-0" x="10" y="50"/>
 </g>
diff --git a/tests/approval_tests/mfl.cpp b/tests/approval_tests/mfl.cpp
@@ -3,13 +3,11 @@
 
 #include <doctest/doctest.h>
 
-#include <iostream>
-
 namespace mfl
 {
     TEST_CASE("mfl")
     {
-        std::vector<std::string> formulas = {
+        const std::vector<std::string> formulas = {
             R"(M(s)<M(t)<|M| = m \qquad y'' = c\{f[y',y(x)] + g(x)\})",
             R"(a = \sqrt[2]{b^2 + c^2} \qquad \sqrt[n]{\frac{x^n - y^n}{1 + u^{2n}}} \qquad \sqrt[3]{-q + \sqrt{q^2 + p^3}})",
             R"(A^{x_i^2}_{j^{2n}_{n,m}} \qquad \Gamma(x) \equiv \lim_{n \rightarrow \infty} \prod_{v=0}^{n-1} \frac{n!n^{x-1}}{x+v} \equiv \int^\infty_0 e^{-t}t^{x-1} \, dt)",
@@ -31,7 +29,7 @@ namespace mfl
 
     TEST_CASE("mfl_large")
     {
-        std::vector<std::string> formulas = {
+        const std::vector<std::string> formulas = {
             R"(M(s)<M(t)<|M| = m)",
             R"(y'' = c\{f[y',y(x)] + g(x)\})",
             R"(A^{x_i^2}_{j^{2n}_{n,m}})",
@@ -48,7 +46,7 @@ namespace mfl
 
     TEST_CASE("mathtext")
     {
-        std::vector<std::string> formulas = {
+        const std::vector<std::string> formulas = {
             R"(a+b+\dot s+\dot{s}+\ldots)",
             R"(x \doteq y)",
             R"(\frac{\$100.00}{y})",
@@ -97,7 +95,7 @@ namespace mfl
 
     TEST_CASE("MathML_torture_test")
     {
-        std::vector<std::string> formulas = {
+        const std::vector<std::string> formulas = {
             R"({x}^{2}{y}^{2})",
             R"({}_{2}F_{3})",
             R"(\frac{x+{y}^{2}}{k+1})",
diff --git a/tests/approval_tests/renderer/render_formulas.hpp b/tests/approval_tests/renderer/render_formulas.hpp
@@ -10,7 +10,6 @@
 #include <ranges>
 #include <sstream>
 #include <string>
-#include <type_traits>
 #include <vector>
 
 namespace mfl
@@ -44,19 +43,19 @@ namespace mfl
             auto create_font_face = [&](const font_family family) { return std::make_unique<fft::font_face>(family, ft); };
 
             svg_renderer renderer(os, config.width, config.height, config.dpi, ft);
-            auto num_formulas_processed = size_t(0);
-            for (const auto& col : config.columns)
+            auto num_formulas_processed = size_t{0};
+            for (const auto& [initial_offset, line_height, x, num_rows] : config.columns)
             {
-                auto y = config.height - col.initial_offset;
-                for (const auto& formula : formulas | std::views::drop(num_formulas_processed) | std::views::take(col.num_rows))
+                auto y = config.height - initial_offset;
+                for (const auto& formula : formulas | std::views::drop(num_formulas_processed) | std::views::take(num_rows))
                 {
-                    renderer.render(col.x, y, layout(formula, config.font_size, create_font_face));
-                    if (config.render_input) renderer.render_tt_text(col.x + config.input_offset, y, formula);
+                    renderer.render(x, y, layout(formula, config.font_size, create_font_face));
+                    if (config.render_input) renderer.render_tt_text(x + config.input_offset, y, formula);
 
-                    y -= col.line_height;
+                    y -= line_height;
                 }
 
-                num_formulas_processed += col.num_rows;
+                num_formulas_processed += num_rows;
             }
         }
 
diff --git a/tests/approval_tests/renderer/svg_renderer.cpp b/tests/approval_tests/renderer/svg_renderer.cpp
diff --git a/tests/approval_tests/renderer/svg_renderer.hpp b/tests/approval_tests/renderer/svg_renderer.hpp
