Put the dialog behind setting

Author: alilaa

README.md

@@ -167,6 +167,16 @@ You can set the VSCode text editor to use an installed Nerd Font by setting `"ed
 
 Once you have a Nerd Font set for your editor font, to use these icons in your oil view, set `"oil-code.hasNerdFont": true`.
 
+## Confirmation Dialog
+
+By default, oil.code uses a modal confirmation dialog when you save file operations. You can enable an alternate confirmation interface by setting `"oil-code.enableAlternateConfirmation": true`.
+
+The alternate confirmation dialog provides a QuickPick interface where you can:
+
+- Type `Y` to confirm and apply changes
+- Type `N` to cancel and discard changes
+- Press `Esc` or click outside to cancel
+
 ## Other great extensions
 
 - [vsnetrw](https://github.com/danprince/vsnetrw): Another great option for a split file explorer.

package.json

@@ -5,7 +5,7 @@
   "icon": "images/oil.code.logo.png",
   "repository": "https://github.com/corwinm/oil.code",
   "publisher": "haphazarddev",
-  "version": "0.0.31",
+  "version": "0.0.29",
   "engines": {
     "vscode": "^1.96.2"
   },
@@ -160,6 +160,11 @@
           "type": "boolean",
           "default": false,
           "description": "Enable workspace edit for file move/rename operations. When enabled, VS Code will ask to update references when a file is moved or renamed. Default is false."
+        },
+        "oil-code.enableAlternateConfirmation": {
+          "type": "boolean",
+          "default": false,
+          "description": "Enable alternate confirmation dialog for file operations. When enabled, uses a QuickPick interface instead of the default modal confirmation dialog. Default is false."
         }
       }
     }

src/handlers/onDidSaveTextDocument.ts

@@ -12,7 +12,10 @@ import {
 import { select } from "../commands/select";
 import { newline } from "../newline";
 import { logger } from "../logger";
-import { getEnableWorkspaceEditSetting } from "../utils/settings";
+import {
+  getEnableWorkspaceEditSetting,
+  getEnableAlternateConfirmationSetting,
+} from "../utils/settings";
 import { confirmChanges, type Change } from "../ui/confirmChanges";
 
 export async function onDidSaveTextDocument(document: vscode.TextDocument) {
@@ -135,34 +138,78 @@ export async function onDidSaveTextDocument(document: vscode.TextDocument) {
         oilState.openAfterSave = undefined;
         return;
       }
+      // Get the alternate confirmation dialog setting
+      const useAlternateConfirmation = getEnableAlternateConfirmationSetting();
 
-      // Build change list and confirm using Quick Pick/editor
-      const uiChanges: Change[] = [];
-      for (const [from, to] of movedLines) {
-        uiChanges.push({ kind: "move", from, to });
-      }
-      for (const [from, to] of copiedLines) {
-        uiChanges.push({ kind: "copy", from, to });
-      }
-      for (const p of addedLines) {
-        uiChanges.push({ kind: "create", to: p });
-      }
-      for (const p of deletedLines) {
-        uiChanges.push({ kind: "delete", from: p });
+      if (useAlternateConfirmation) {
+        // Build change list and confirm using Quick Pick
+        const uiChanges: Change[] = [];
+        for (const [from, to] of movedLines) {
+          uiChanges.push({ kind: "move", from, to });
+        }
+        for (const [from, to] of copiedLines) {
+          uiChanges.push({ kind: "copy", from, to });
+        }
+        for (const p of addedLines) {
+          uiChanges.push({ kind: "create", to: p });
+        }
+        for (const p of deletedLines) {
+          uiChanges.push({ kind: "delete", from: p });
+        }
+        const ok = await confirmChanges(
+          uiChanges.map((c) => ({
+            // format paths to relative for nicer display (but still keep full for ops later)
+            ...(c as any),
+            from: "from" in c ? formatPath((c as any).from) : undefined,
+            to: "to" in c ? formatPath((c as any).to) : undefined,
+          })) as Change[]
+        );
+        if (!ok) {
+          oilState.openAfterSave = undefined;
+          return;
+        }
+      } else {
+        // Show confirmation dialog
+        let message = "The following changes will be applied:\n\n";
+        if (movedLines.length > 0) {
+          movedLines.forEach((item) => {
+            const [originalPath, newPath] = item;
+            message += `MOVE ${formatPath(originalPath)} → ${formatPath(
+              newPath
+            )}\n`;
+          });
+        }
+        if (copiedLines.length > 0) {
+          copiedLines.forEach((item) => {
+            const [originalPath, newPath] = item;
+            message += `COPY ${formatPath(originalPath)} → ${formatPath(
+              newPath
+            )}\n`;
+          });
+        }
+        if (addedLines.size > 0) {
+          addedLines.forEach((item) => {
+            message += `CREATE ${formatPath(item)}\n`;
+          });
+        }
+        if (deletedLines.size > 0) {
+          deletedLines.forEach((item) => {
+            message += `DELETE ${formatPath(item)}\n`;
+          });
+        }
+        // Show confirmation dialog
+        const response = await vscode.window.showWarningMessage(
+          message,
+          { modal: true },
+          "Yes",
+          "No"
+        );
+        if (response !== "Yes") {
+          oilState.openAfterSave = undefined;
+          return;
+        }
       }
 
-      const ok = await confirmChanges(
-        uiChanges.map((c) => ({
-          // format paths to relative for nicer display (but still keep full for ops later)
-          ...(c as any),
-          from: "from" in c ? formatPath((c as any).from) : undefined,
-          to: "to" in c ? formatPath((c as any).to) : undefined,
-        })) as Change[]
-      );
-      if (!ok) {
-        oilState.openAfterSave = undefined;
-        return;
-      }
       logger.debug("Processing changes...");
 
       // Delete files/directories

src/utils/settings.ts

@@ -15,6 +15,11 @@ export function getEnableWorkspaceEditSetting(): boolean {
   return config.get<boolean>("enableWorkspaceEdit") || false;
 }
 
+export function getEnableAlternateConfirmationSetting(): boolean {
+  const config = vscode.workspace.getConfiguration("oil-code");
+  return config.get<boolean>("enableAlternateConfirmation") || false;
+}
+
 let restoreAutoSave = false;
 
 export async function checkAndDisableAutoSave() {