From 008aebf482fcbfc9b02921b8bb0f0f145332646d Mon Sep 17 00:00:00 2001 From: mrholek Date: Sat, 13 Jun 2026 18:59:53 +0200 Subject: [PATCH 1/2] ci: replace broken workflows with a working build/test/lint pipeline MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The old project-check and daily-project-check workflows triggered on the non-existent `master` branch, ran on Node 12 with actions/checkout@v1, and called a `jest:test` script that no longer exists — so CI never ran on PRs and the daily job failed every day. Add a single CI workflow that runs on push/PR to main: - test job: build and test @coreui/react on Node 20.x and 22.x - lint job: yarn lint, non-blocking for now (a few react-hooks v7 findings and one deferred public type remain) until the remaining errors clear --- .github/workflows/ci.yml | 44 +++++++++++++++++++++++ .github/workflows/daily-project-check.yml | 31 ---------------- .github/workflows/project-check.yml | 34 ------------------ 3 files changed, 44 insertions(+), 65 deletions(-) create mode 100644 .github/workflows/ci.yml delete mode 100644 .github/workflows/daily-project-check.yml delete mode 100644 .github/workflows/project-check.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..8341572e --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,44 @@ +name: CI + +on: + push: + branches: [main] + pull_request: + branches: [main] + +permissions: + contents: read + +jobs: + test: + name: Build & test (Node ${{ matrix.node-version }}) + runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + node-version: [20.x, 22.x] + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + cache: yarn + - run: yarn install --frozen-lockfile + - run: yarn lib:build + - run: yarn lib:test + + lint: + name: Lint + runs-on: ubuntu-latest + # Non-blocking for now: a handful of react-hooks v7 findings and one + # deferred public type are still open. Drop continue-on-error once the + # remaining errors are resolved to make lint a required check. + continue-on-error: true + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: 22.x + cache: yarn + - run: yarn install --frozen-lockfile + - run: yarn lint diff --git a/.github/workflows/daily-project-check.yml b/.github/workflows/daily-project-check.yml deleted file mode 100644 index 5776ce77..00000000 --- a/.github/workflows/daily-project-check.yml +++ /dev/null @@ -1,31 +0,0 @@ -name: Daily project check - -on: - schedule: - # build runs every weekday at 6AM UTC - - cron: '0 6 * * 1-5' - -jobs: - build: - - runs-on: ubuntu-latest - - strategy: - matrix: - node-version: [12.x] - os: [ubuntu-latest, windows-latest, macOS-latest] - - steps: - - uses: actions/checkout@v1 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - - name: npm install, build, test and lint - run: | - npm i - npm run build - npm run jest:test - npm run lint - env: - CI: true diff --git a/.github/workflows/project-check.yml b/.github/workflows/project-check.yml deleted file mode 100644 index 854186a4..00000000 --- a/.github/workflows/project-check.yml +++ /dev/null @@ -1,34 +0,0 @@ -name: Project check - -on: - push: - branches: - - master - pull_request: - branches: - - master - -jobs: - build: - - runs-on: ubuntu-latest - - strategy: - matrix: - node-version: [12.x] - os: [ubuntu-latest, windows-latest, macOS-latest] - - steps: - - uses: actions/checkout@v1 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - - name: npm install, build, test and lint - run: | - npm i - npm run build - npm run jest:test - npm run lint - env: - CI: true From f58bac0151c69915a922f5be2ca0366ba93a5631 Mon Sep 17 00:00:00 2001 From: mrholek Date: Sat, 13 Jun 2026 19:02:09 +0200 Subject: [PATCH 2/2] ci: install without a lockfile (yarn.lock is gitignored) setup-node's yarn cache and yarn install --frozen-lockfile both require a committed yarn.lock, which this repo gitignores. Drop the cache option and the frozen flag so install resolves from package.json. --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8341572e..0bd1cc3f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,8 +22,9 @@ jobs: - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - cache: yarn - - run: yarn install --frozen-lockfile + # yarn.lock is gitignored in this repo, so there is no lockfile to pin + # against or to key a cache on — install resolves from package.json. + - run: yarn install - run: yarn lib:build - run: yarn lib:test @@ -39,6 +40,5 @@ jobs: - uses: actions/setup-node@v4 with: node-version: 22.x - cache: yarn - - run: yarn install --frozen-lockfile + - run: yarn install - run: yarn lint