Skip to content

Commit 68acb1c

Browse files
committed
884: Fix rubocop issues
1 parent b08b98f commit 68acb1c

8 files changed

Lines changed: 21 additions & 29 deletions

File tree

.rubocop.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
require:
2-
- rubocop-performance
3-
41
AllCops:
52
NewCops: enable
6-
TargetRubyVersion: 2.6
3+
TargetRubyVersion: 3.0
4+
SuggestExtensions: false
5+
6+
plugins:
7+
- rubocop-performance
78
Metrics/AbcSize:
89
Enabled: false
910
Metrics/BlockLength:

Gemfile

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,14 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
66

77
# Specify your gem's dependencies in action_network_rest.gemspec
88
gemspec
9+
10+
group :development do
11+
gem 'bundler', '>= 2.1'
12+
gem 'debug', '> 0'
13+
gem 'dotenv', '~> 2.7'
14+
gem 'rake', '~> 13.0'
15+
gem 'rspec', '~> 3.0'
16+
gem 'rubocop', '> 0'
17+
gem 'rubocop-performance', '> 0'
18+
gem 'webmock', '~> 3.8.3'
19+
end

action_network_rest.gemspec

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,9 @@ Gem::Specification.new do |spec|
2323

2424
spec.required_ruby_version = '>= 3.0.0'
2525

26-
spec.add_runtime_dependency 'vertebrae', '>= 1.0.5'
27-
spec.add_runtime_dependency 'faraday', '~> 2.0'
28-
spec.add_runtime_dependency 'faraday-mashify', '~> 1.0'
26+
spec.add_dependency 'faraday', '~> 2.0'
27+
spec.add_dependency 'faraday-mashify', '~> 1.0'
28+
spec.add_dependency 'vertebrae', '>= 1.0.5'
2929

30-
spec.add_development_dependency 'bundler', '>= 2.1'
31-
spec.add_development_dependency 'debug', '> 0'
32-
spec.add_development_dependency 'dotenv', '~> 2.7'
33-
spec.add_development_dependency 'rake', '~> 13.0'
34-
spec.add_development_dependency 'rspec', '~> 3.0'
35-
spec.add_development_dependency 'rubocop', '> 0'
36-
spec.add_development_dependency 'rubocop-performance', '> 0'
37-
spec.add_development_dependency 'webmock', '~> 3.8.3'
3830
spec.metadata['rubygems_mfa_required'] = 'true'
3931
end

lib/action_network_rest/advocacy_campaigns.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22

33
module ActionNetworkRest
44
class AdvocacyCampaigns < Base
5-
def initialize(client:)
6-
super(client: client)
7-
end
8-
95
def base_path
106
'advocacy_campaigns/'
117
end

lib/action_network_rest/campaigns.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ module ActionNetworkRest
44
class Campaigns < Base
55
attr_accessor :campaign_id
66

7-
def initialize(client:)
8-
super(client: client)
9-
end
10-
117
def base_path
128
'campaigns/'
139
end

lib/action_network_rest/client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class Client < API
66

77
def initialize(options = {}, &block)
88
self.api_key = options[:api_key]
9-
super(options, &block)
9+
super
1010
end
1111

1212
def default_options

lib/action_network_rest/forms.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22

33
module ActionNetworkRest
44
class Forms < Base
5-
def initialize(client:)
6-
super(client: client)
7-
end
8-
95
def base_path
106
'forms/'
117
end

spec/spec_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
require 'webmock/rspec'
66

77
# Require everything in the `support` directory
8-
Dir[File.join(File.dirname(__FILE__), 'support', '**', '*.rb')].sort.each { |f| require f }
8+
Dir[File.join(File.dirname(__FILE__), 'support', '**', '*.rb')].each { |f| require f }
99

1010
RSpec.configure do |config|
1111
# Enable flags like --only-failures and --next-failure

0 commit comments

Comments
 (0)