Skip to content

Commit 9bd6efa

Browse files
authored
Merge pull request #337 from contentstack/fix/asset-fields-correct-parameter-names
fix: correct asset_fields[] parameter names for DAM 2.0
2 parents d134838 + 05e621a commit 9bd6efa

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

src/assets/asset.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,14 @@ export class Asset {
133133
* @method assetFields
134134
* @memberof Asset
135135
* @description Include specific asset fields in the response (CDA getAssets - single asset).
136-
* Use with asset_fields[]: user_defined_fields, embedded, ai_suggested, visual_markups.
136+
* Use with asset_fields[]: user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups.
137137
* @example
138138
* import contentstack from '@contentstack/delivery-sdk'
139139
*
140140
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
141141
* const result = await stack.asset("assetUid").assetFields("user_defined_fields", "embedded_metadata").fetch();
142142
*
143-
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded, ai_suggested, visual_markups)
143+
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups)
144144
* @returns {Asset} - Returns the Asset instance for chaining.
145145
*/
146146
assetFields(...fields: string[]): this {

src/entries/entries.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,14 +281,14 @@ export class Entries extends BaseQuery {
281281
* @method assetFields
282282
* @memberof Entries
283283
* @description Include specific asset fields in the response (CDA getEntry/entries).
284-
* Use with asset_fields[]: user_defined_fields, embedded, ai_suggested, visual_markups.
284+
* Use with asset_fields[]: user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups.
285285
* @example
286286
* import contentstack from '@contentstack/delivery-sdk'
287287
*
288288
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
289289
* const result = await stack.contentType("contentTypeUid").entry().assetFields("user_defined_fields", "embedded_metadata").find();
290290
*
291-
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded, ai_suggested, visual_markups)
291+
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups)
292292
* @returns {Entries} - Returns the Entries instance for chaining.
293293
*/
294294
assetFields(...fields: string[]): this {

src/entries/entry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,14 +278,14 @@ export class Entry {
278278
* @method assetFields
279279
* @memberof Entry
280280
* @description Include specific asset fields in the response (CDA getEntry).
281-
* Use with asset_fields[]: user_defined_fields, embedded, ai_suggested, visual_markups.
281+
* Use with asset_fields[]: user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups.
282282
* @example
283283
* import contentstack from '@contentstack/delivery-sdk'
284284
*
285285
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
286286
* const result = await stack.contentType("contentTypeUid").entry("entryUid").assetFields("user_defined_fields", "embedded_metadata").fetch();
287287
*
288-
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded, ai_suggested, visual_markups)
288+
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups)
289289
* @returns {Entry} - Returns the Entry instance for chaining.
290290
*/
291291
assetFields(...fields: string[]): this {

src/query/asset-query.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ export class AssetQuery extends BaseQuery {
131131
* @method assetFields
132132
* @memberof AssetQuery
133133
* @description Include specific asset fields in the response (CDA getAssets).
134-
* Use with asset_fields[]: user_defined_fields, embedded, ai_suggested, visual_markups.
134+
* Use with asset_fields[]: user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups.
135135
* @example
136136
* import contentstack from '@contentstack/delivery-sdk'
137137
*
138138
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
139139
* const result = await stack.asset().assetFields("user_defined_fields", "embedded_metadata").find();
140140
*
141-
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded, ai_suggested, visual_markups)
141+
* @param {...string} fields - Asset field names to include (e.g. user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups)
142142
* @returns {AssetQuery} - Returns the AssetQuery instance for chaining.
143143
*/
144144
assetFields(...fields: string[]): this {

test/api/asset-query.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe("AssetQuery API tests", () => {
132132
});
133133
it("should query assets with asset_fields[] CDA param (user_defined_fields, embedded, ai_suggested, visual_markups)", async () => {
134134
const result = await makeAssetQuery()
135-
.assetFields("user_defined_fields", "embedded_metadata", "ai_suggested", "visual_markups")
135+
.assetFields("user_defined_fields", "embedded_metadata", "ai_generated_metadata", "visual_markups")
136136
.limit(2)
137137
.find<TAsset>();
138138
if (result.assets) {

test/api/asset.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ describe('Asset API tests', () => {
106106

107107
it('should fetch asset with asset_fields[] CDA param (user_defined_fields, embedded_metadata, ai_suggested, visual_markups)', async () => {
108108
const result = await makeAsset(assetUid)
109-
.assetFields('user_defined_fields', 'embedded_metadata', 'ai_suggested', 'visual_markups')
109+
.assetFields('user_defined_fields', 'embedded_metadata', 'ai_generated_metadata', 'visual_markups')
110110
.fetch<BaseAsset>();
111111
expect(result).toBeDefined();
112112
expect(result.uid).toBeDefined();

test/api/entries.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ describe("Entries API test cases", () => {
173173

174174
it("should query entries with asset_fields[] CDA param (user_defined_fields, embedded, ai_suggested, visual_markups)", async () => {
175175
const result = await makeEntries(BLOG_POST_CT)
176-
.assetFields("user_defined_fields", "embedded_metadata", "ai_suggested", "visual_markups")
176+
.assetFields("user_defined_fields", "embedded_metadata", "ai_generated_metadata", "visual_markups")
177177
.find<TEntry>();
178178
if (result.entries) {
179179
expect(result.entries).toBeDefined();

test/api/entry.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('Entry API tests', () => {
7070

7171
it('should fetch entry with asset_fields[] CDA param (user_defined_fields, embedded, ai_suggested, visual_markups)', async () => {
7272
const result = await makeEntry(entryUid)
73-
.assetFields('user_defined_fields', 'embedded', 'ai_suggested', 'visual_markups')
73+
.assetFields('user_defined_fields', 'embedded_metadata', 'ai_generated_metadata', 'visual_markups')
7474
.fetch<TEntry>();
7575
expect(result).toBeDefined();
7676
expect(result.uid).toBeDefined();

0 commit comments

Comments
 (0)