refactor: Update locales method in Term class to return data directly and adjust related tests

Author: harshitha-cstk

src/lib/term.ts

@@ -22,11 +22,13 @@ export class Term {
    * import contentstack from '@contentstack/delivery-sdk'
    *
    * const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
-   * const result = await stack.taxonomy('taxonomy_uid').term('term_uid').locales().fetch();
+   * const result = await stack.taxonomy('taxonomy_uid').term('term_uid').locales();
    */
-  locales(): this {
-    this._urlPath = `${this._urlPath}/locales`;
-    return this;
+  async locales<T>(): Promise<T> {
+    const urlPath = `/taxonomy-manager/${this._taxonomyUid}/terms/${this._termUid}/locales`;
+    const response = await getData(this._client, urlPath);
+    if (response.locales) return response.locales as T;
+    return response;
   }
 
   async fetch<T>(): Promise<T> {

test/api/term.spec.ts

@@ -17,7 +17,7 @@ describe("Terms API test cases", () => {
   it("should get locales for a term", async () => {
     // const result = await makeTerms("term1").locales().fetch();
     // API under building phase, so it should throw error
-    expect(async () => await makeTerms("term1").locales().fetch()).rejects.toThrow();
+    expect(async () => await makeTerms("term1").locales()).rejects.toThrow();
     // TODO: add assertions
   });
 });

test/unit/term.spec.ts

@@ -1,6 +1,6 @@
 import { AxiosInstance, httpClient } from '@contentstack/core';
 import MockAdapter from 'axios-mock-adapter';
-import { termQueryFindResponseDataMock, termLocalesFindResponseDataMock } from '../utils/mocks';
+import { termQueryFindResponseDataMock, termLocalesResponseDataMock } from '../utils/mocks';
 import { MOCK_CLIENT_OPTIONS } from '../utils/constant';
 import { Term } from '../../src/lib/term';
 import { Taxonomy } from '../../src/lib/taxonomy';
@@ -26,10 +26,10 @@ describe('Term class', () => {
     expect(response).toEqual(termQueryFindResponseDataMock.terms[0]);
   });
 
-  it('should fetch locales for a term when locales().fetch() is called', async () => {
-    mockClient.onGet('/taxonomy-manager/taxonomy_testing/terms/term1/locales').reply(200, termLocalesFindResponseDataMock);
+  it('should fetch locales for a term when locales() is called', async () => {
+    mockClient.onGet('/taxonomy-manager/taxonomy_testing/terms/term1/locales').reply(200, termLocalesResponseDataMock.terms); //TODO: change to /taxonomies
 
-    const response = await term.locales().fetch();
-    expect(response).toEqual(termLocalesFindResponseDataMock.locales);
+    const response = await term.locales();
+    expect(response).toEqual(termLocalesResponseDataMock.terms);
   });
 });

test/utils/mocks.ts

@@ -1699,19 +1699,8 @@ const taxonomyFindResponseDataMock = {
   ]
 }
 
-const termLocalesFindResponseDataMock = {
-  "locales": [
-    {
-      "code": "en-us",
-      "name": "English (United States)",
-      "fallback_code": null
-    },
-    {
-      "code": "es-es",
-      "name": "Spanish (Spain)",
-      "fallback_code": "en-us"
-    }
-  ]
+const termLocalesResponseDataMock = {
+  terms: []
 }
 
 const termQueryFindResponseDataMock = {
@@ -1759,5 +1748,5 @@ export {
   gfieldQueryFindResponseDataMock,
   taxonomyFindResponseDataMock,
   termQueryFindResponseDataMock,
-  termLocalesFindResponseDataMock,
+  termLocalesResponseDataMock,
 };