Skip to content

Commit 998c10b

Browse files
committed
fix tests
1 parent 1cb4698 commit 998c10b

8 files changed

Lines changed: 46 additions & 85 deletions

Contentstack.Core.Unit.Tests/AssetLibraryUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ public void GetContentstackError_WithGenericException_ReturnsContentstackExcepti
546546

547547
// Assert
548548
Assert.NotNull(result);
549-
Assert.Equal("Test error", result.ErrorMessage);
549+
Assert.Equal("Test error", result.Message);
550550
}
551551

552552
[Fact]

Contentstack.Core.Unit.Tests/AssetUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ public void GetContentstackError_WithGenericException_ReturnsContentstackExcepti
533533

534534
// Assert
535535
Assert.NotNull(result);
536-
Assert.Equal("Test error", result.ErrorMessage);
536+
Assert.Equal("Test error", result.Message);
537537
}
538538

539539
[Fact]

Contentstack.Core.Unit.Tests/ContentstackClientUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,7 @@ public void GetContentstackError_WithGenericException_ReturnsContentstackExcepti
781781

782782
// Assert
783783
Assert.NotNull(result);
784-
Assert.Equal("Test error", result.ErrorMessage);
784+
Assert.Equal("Test error", result.Message);
785785
}
786786

787787
[Fact]

Contentstack.Core.Unit.Tests/ContentstackExceptionUnitTests.cs

Lines changed: 4 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,10 @@ public void ContentstackException_DefaultConstructor_InitializesCorrectly()
2424

2525
// Assert
2626
Assert.NotNull(exception);
27-
// ErrorMessage is initialized as string.Empty in private field, but Message may be null
28-
Assert.Equal(string.Empty, exception.ErrorMessage ?? string.Empty);
29-
// Message property from base Exception class may be null initially
30-
Assert.True(string.IsNullOrEmpty(exception.Message));
27+
// Message property from base Exception class is set to a default value
28+
Assert.NotNull(exception.Message);
3129
Assert.Equal(0, exception.ErrorCode);
3230
Assert.Null(exception.Errors);
33-
Assert.Equal(ResponseType.Network, exception.ResponseType);
3431
}
3532

3633
[Fact]
@@ -44,7 +41,6 @@ public void ContentstackException_WithErrorMessage_InitializesCorrectly()
4441

4542
// Assert
4643
Assert.NotNull(exception);
47-
Assert.Equal(errorMessage, exception.ErrorMessage);
4844
Assert.Equal(errorMessage, exception.Message);
4945
}
5046

@@ -59,32 +55,15 @@ public void ContentstackException_WithException_InitializesCorrectly()
5955

6056
// Assert
6157
Assert.NotNull(exception);
62-
Assert.Equal(sourceException.Message, exception.ErrorMessage);
6358
Assert.Equal(sourceException.Message, exception.Message);
64-
// The base constructor sets InnerException from sourceException.InnerException (which is null here)
65-
// So InnerException will be null if source exception doesn't have one
66-
Assert.Null(exception.InnerException);
59+
// The constructor sets the sourceException as InnerException
60+
Assert.Equal(sourceException, exception.InnerException);
6761
}
6862

6963
#endregion
7064

7165
#region Property Tests
7266

73-
[Fact]
74-
public void ErrorMessage_SetAndGet_ReturnsCorrectValue()
75-
{
76-
// Arrange
77-
var exception = new ContentstackException();
78-
var errorMessage = _fixture.Create<string>();
79-
80-
// Act
81-
exception.ErrorMessage = errorMessage;
82-
83-
// Assert
84-
Assert.Equal(errorMessage, exception.ErrorMessage);
85-
Assert.Equal(errorMessage, exception.Message);
86-
}
87-
8867
[Fact]
8968
public void ErrorCode_SetAndGet_ReturnsCorrectValue()
9069
{
@@ -113,20 +92,6 @@ public void StatusCode_SetAndGet_ReturnsCorrectValue()
11392
Assert.Equal(statusCode, exception.StatusCode);
11493
}
11594

116-
[Fact]
117-
public void ResponseType_SetAndGet_ReturnsCorrectValue()
118-
{
119-
// Arrange
120-
var exception = new ContentstackException();
121-
var responseType = ResponseType.Cache;
122-
123-
// Act
124-
exception.ResponseType = responseType;
125-
126-
// Assert
127-
Assert.Equal(responseType, exception.ResponseType);
128-
}
129-
13095
[Fact]
13196
public void Errors_SetAndGet_ReturnsCorrectValue()
13297
{
@@ -159,7 +124,6 @@ public void ContentstackException_WithAllPropertiesSet_ReturnsAllValues()
159124
var errorMessage = _fixture.Create<string>();
160125
var errorCode = 404;
161126
var statusCode = HttpStatusCode.NotFound;
162-
var responseType = ResponseType.Network;
163127
var errors = new Dictionary<string, object>
164128
{
165129
{ "error", "Not found" }
@@ -170,16 +134,13 @@ public void ContentstackException_WithAllPropertiesSet_ReturnsAllValues()
170134
{
171135
ErrorCode = errorCode,
172136
StatusCode = statusCode,
173-
ResponseType = responseType,
174137
Errors = errors
175138
};
176139

177140
// Assert
178-
Assert.Equal(errorMessage, exception.ErrorMessage);
179141
Assert.Equal(errorMessage, exception.Message);
180142
Assert.Equal(errorCode, exception.ErrorCode);
181143
Assert.Equal(statusCode, exception.StatusCode);
182-
Assert.Equal(responseType, exception.ResponseType);
183144
Assert.NotNull(exception.Errors);
184145
Assert.Single(exception.Errors);
185146
}

Contentstack.Core.Unit.Tests/EntryUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1701,7 +1701,7 @@ public void GetContentstackError_WithGenericException_ReturnsContentstackExcepti
17011701

17021702
// Assert
17031703
Assert.NotNull(result);
1704-
Assert.Equal("Test error", result.ErrorMessage);
1704+
Assert.Equal("Test error", result.Message);
17051705
}
17061706

17071707
[Fact]

Contentstack.Core.Unit.Tests/JsonConverterUnitTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void ReadJson_WithValidJson_ReturnsAsset()
9393
}
9494

9595
[Fact]
96-
public void WriteJson_WithAsset_ThrowsNotImplementedException()
96+
public void WriteJson_WithAsset_ThrowsAssetException()
9797
{
9898
// Arrange
9999
var converter = new AssetJsonConverter();
@@ -102,7 +102,7 @@ public void WriteJson_WithAsset_ThrowsNotImplementedException()
102102
var writer = new JsonTextWriter(new StringWriter());
103103

104104
// Act & Assert
105-
Assert.Throws<NotImplementedException>(() =>
105+
Assert.Throws<AssetException>(() =>
106106
converter.WriteJson(writer, asset, JsonSerializer.CreateDefault()));
107107
}
108108
}

0 commit comments

Comments
 (0)