Skip to content

Commit e39fdab

Browse files
authored
[DRE-59]No se puede eliminar un PaymentSource (#72)
* fix delete payment sources issue * add pip install nose * add pip install -e .
1 parent 72506bf commit e39fdab

4 files changed

Lines changed: 20 additions & 9 deletions

File tree

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,8 @@ jobs:
2121
uses: actions/setup-python@v2
2222
with:
2323
python-version: ${{ matrix.python-version }}
24+
- name: Install dependencies
25+
run: |
26+
python -m pip install --upgrade pip && pip install -e .
2427
- name: Run tests
2528
run: nosetests

conekta/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ def instance_url(self):
634634
return "orders/%s/line_items" % (self.parent.id)
635635

636636
def delete(self, params={}, api_key=None):
637-
return super(LineItem, self).delete(params, self.parent.line_items)
637+
return super(LineItem, self).delete(params, self.parent.line_items, api_key=api_key)
638638

639639

640640
class TaxLine(_CreatableResource, _UpdatableResource, _DeletableResource, _FindableResource, _EventableResource):
@@ -643,7 +643,7 @@ def instance_url(self):
643643
return "orders/%s/tax_lines" % (self.parent.id)
644644

645645
def delete(self, params={}, api_key=None):
646-
return super(TaxLine, self).delete(params, self.parent.tax_lines)
646+
return super(TaxLine, self).delete(params, self.parent.tax_lines, api_key=api_key)
647647

648648

649649
class ShippingLine(_CreatableResource, _UpdatableResource, _DeletableResource, _FindableResource, _EventableResource):
@@ -652,7 +652,7 @@ def instance_url(self):
652652
return "orders/%s/shipping_lines" % (self.parent.id)
653653

654654
def delete(self, params={}, api_key=None):
655-
return super(ShippingLine, self).delete(params, self.parent.shipping_lines)
655+
return super(ShippingLine, self).delete(params, self.parent.shipping_lines, api_key=api_key)
656656

657657

658658
class DiscountLine(_CreatableResource, _UpdatableResource, _DeletableResource, _FindableResource, _EventableResource):
@@ -661,15 +661,15 @@ def instance_url(self):
661661
return "orders/%s/discount_lines" % (self.parent.id)
662662

663663
def delete(self, params={}, api_key=None):
664-
return super(DiscountLine, self).delete(params, self.parent.discount_lines)
664+
return super(DiscountLine, self).delete(params, self.parent.discount_lines, api_key=api_key)
665665

666666

667667
class PaymentSource(_CreatableResource, _UpdatableResource, _DeletableResource, _FindableResource):
668668
def instance_url(self):
669669
return "customers/%s/payment_sources" % (self.parent.id)
670670

671-
def delete(self, params={}, api_key=None):
672-
return super(PaymentSource, self).delete(params, self.parent.payment_sources)
671+
def delete(self, params={}, list_to_remove=None, uri=None, api_key=None):
672+
return super(PaymentSource, self).delete(params, self.parent.payment_sources, api_key=api_key)
673673

674674
def events(self, params={}, api_key=None):
675675
uri = "%s/payment_sources/%s/events" % (
@@ -689,7 +689,7 @@ def update(self, params={}, api_key=None):
689689

690690
def delete(self, params={}, api_key=None):
691691
uri = "%s/shipping_contacts/%s" % (self.parent.instance_url(), self.id)
692-
return super(ShippingContact, self).delete(params, self.parent.shipping_contacts, uri)
692+
return super(ShippingContact, self).delete(params, self.parent.shipping_contacts, uri, api_key=api_key)
693693

694694
def events(self, params={}, api_key=None):
695695
uri = "%s/shipping_contacts/%s/events" % (

tests/test_customer.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,12 @@ def test_09_customer_update_plan(self):
7575
customer2 = self.client.Customer.find(customer.id)
7676

7777
assert customer2.subscription.plan_id == "opal-plan"
78+
79+
def test_21_delete_payment_source(self):
80+
self.client.api_key = 'key_ZLy4aP2szht1HqzkCezDEA'
81+
customer = self.client.Customer.create(self.customer_object.copy())
82+
payment_source = customer.payment_sources[0]
83+
84+
response = payment_source.delete()
85+
86+
assert payment_source.id == response.id

tests/test_orders.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,7 @@ def test_19_order_create_with_customer_id(self):
283283
order_params["customer_info"] = {}
284284
order_params["customer_info"]["customer_id"] = customer.id
285285

286-
charge_params = {}
287-
charge_params["payment_method"] = {}
286+
charge_params = {"payment_method": {}}
288287
charge_params["payment_method"]["type"] = "card"
289288
charge_params["payment_method"]["token_id"] = "tok_test_visa_4242"
290289
order_params["charges"] = [charge_params]

0 commit comments

Comments
 (0)