Checklist
What is the idea?
In the NSIS templates there are a lot of variables and functions such as Ana_* This looks like a legacy thing and doesn't really serve any purpose, it makes the code look less attractive. In the PR here some variables were renamed to improve readability. We should update the rest of the code base and improve it in a similar fashion to make it consistent.
Why is this needed?
This would mainly benefit developers of constructor and intends to improve code readability.
What should happen?
Variable and function names with the pattern *Ana* for example:
Function mui_AnaCustomOptions_ShowVar Ana_PreInstall_State
to be renamed- Fix inconsistencies in initialization of variables. For example, the following code can likely be moved into
mui_AnaCustomOptions_InitDefaults:
StrCpy $Ana_ClearPkgCache_State {{ '${BST_UNCHECKED}' if keep_pkgs else '${BST_CHECKED}' }}
StrCpy $Ana_PreInstall_State {{ '${BST_CHECKED}' if pre_install_exists else '${BST_UNCHECKED}' }}
StrCpy $Ana_PostInstall_State {{ '${BST_CHECKED}' if post_install_exists else '${BST_UNCHECKED}' }}
Additional Context
No response
Checklist
What is the idea?
In the NSIS templates there are a lot of variables and functions such as
Ana_*This looks like a legacy thing and doesn't really serve any purpose, it makes the code look less attractive. In the PR here some variables were renamed to improve readability. We should update the rest of the code base and improve it in a similar fashion to make it consistent.Why is this needed?
This would mainly benefit developers of
constructorand intends to improve code readability.What should happen?
Variable and function names with the pattern
*Ana*for example:Function mui_AnaCustomOptions_ShowVar Ana_PreInstall_Stateto be renamed
mui_AnaCustomOptions_InitDefaults:Additional Context
No response