Skip to content

Commit dff13ba

Browse files
mcpiercemcpierce
committed
refactor: change the runtime app name [#66]
Rename the shared library: Variant => shared
1 parent c27e223 commit dff13ba

21 files changed

Lines changed: 74 additions & 29 deletions

‎androidVariant/src/main/AndroidManifest.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
<application
88
android:name=".VariantApp"
9+
android:label="Variant"
910
android:allowBackup="false"
1011
android:supportsRtl="true"
1112
android:theme="@style/AppTheme"

iosVariant/iosVariant.xcodeproj/project.pbxproj renamed to iosVariant/Variant.xcodeproj/project.pbxproj

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
6AA598482DE72E910078CC9F /* ServerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ServerView.swift; sourceTree = "<group>"; };
5353
6AA5984B2DE72EF40078CC9F /* Fixtures.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Fixtures.swift; sourceTree = "<group>"; };
5454
6AA5984F2DE73A8F0078CC9F /* EditServerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EditServerView.swift; sourceTree = "<group>"; };
55-
7555FF7B242A565900829871 /* iosVariant.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = iosVariant.app; sourceTree = BUILT_PRODUCTS_DIR; };
55+
7555FF7B242A565900829871 /* Variant.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Variant.app; sourceTree = BUILT_PRODUCTS_DIR; };
5656
7555FF82242A565900829871 /* HomeView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HomeView.swift; sourceTree = "<group>"; };
5757
7555FF8C242A565B00829871 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
5858
B62AADC22DFDDF01000BCC0C /* DirectoryEntry.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DirectoryEntry.swift; sourceTree = "<group>"; };
@@ -110,7 +110,7 @@
110110
7555FF7C242A565900829871 /* Products */ = {
111111
isa = PBXGroup;
112112
children = (
113-
7555FF7B242A565900829871 /* iosVariant.app */,
113+
7555FF7B242A565900829871 /* Variant.app */,
114114
);
115115
name = Products;
116116
sourceTree = "<group>";
@@ -201,9 +201,9 @@
201201
/* End PBXGroup section */
202202

203203
/* Begin PBXNativeTarget section */
204-
7555FF7A242A565900829871 /* iosVariant */ = {
204+
7555FF7A242A565900829871 /* Variant */ = {
205205
isa = PBXNativeTarget;
206-
buildConfigurationList = 7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "iosVariant" */;
206+
buildConfigurationList = 7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "Variant" */;
207207
buildPhases = (
208208
7555FFB5242A651A00829871 /* ShellScript */,
209209
7555FF77242A565900829871 /* Sources */,
@@ -215,9 +215,9 @@
215215
);
216216
dependencies = (
217217
);
218-
name = iosVariant;
218+
name = Variant;
219219
productName = iosVariant;
220-
productReference = 7555FF7B242A565900829871 /* iosVariant.app */;
220+
productReference = 7555FF7B242A565900829871 /* Variant.app */;
221221
productType = "com.apple.product-type.application";
222222
};
223223
/* End PBXNativeTarget section */
@@ -235,7 +235,7 @@
235235
};
236236
};
237237
};
238-
buildConfigurationList = 7555FF76242A565900829871 /* Build configuration list for PBXProject "iosVariant" */;
238+
buildConfigurationList = 7555FF76242A565900829871 /* Build configuration list for PBXProject "Variant" */;
239239
compatibilityVersion = "Xcode 9.3";
240240
developmentRegion = en;
241241
hasScannedForEncodings = 0;
@@ -252,7 +252,7 @@
252252
projectDirPath = "";
253253
projectRoot = "";
254254
targets = (
255-
7555FF7A242A565900829871 /* iosVariant */,
255+
7555FF7A242A565900829871 /* Variant */,
256256
);
257257
};
258258
/* End PBXProject section */
@@ -447,17 +447,19 @@
447447
"$(SRCROOT)/../Variant/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
448448
);
449449
INFOPLIST_FILE = iosVariant/Info.plist;
450+
INFOPLIST_KEY_CFBundleDisplayName = "ComiXed Variant";
450451
IPHONEOS_DEPLOYMENT_TARGET = 16.0;
451452
LD_RUNPATH_SEARCH_PATHS = (
452453
"$(inherited)",
453454
"@executable_path/Frameworks",
454455
);
456+
MARKETING_VERSION = 0.1.0;
455457
OTHER_LDFLAGS = (
456458
"$(inherited)",
457459
"-framework",
458460
Variant,
459461
);
460-
PRODUCT_BUNDLE_IDENTIFIER = orgIdentifier.iosVariant;
462+
PRODUCT_BUNDLE_IDENTIFIER = org.comixedproject.iosVariant;
461463
PRODUCT_NAME = "$(TARGET_NAME)";
462464
SWIFT_VERSION = 5.0;
463465
TARGETED_DEVICE_FAMILY = "1,2";
@@ -477,17 +479,19 @@
477479
"$(SRCROOT)/../Variant/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
478480
);
479481
INFOPLIST_FILE = iosVariant/Info.plist;
482+
INFOPLIST_KEY_CFBundleDisplayName = "ComiXed Variant";
480483
IPHONEOS_DEPLOYMENT_TARGET = 16.0;
481484
LD_RUNPATH_SEARCH_PATHS = (
482485
"$(inherited)",
483486
"@executable_path/Frameworks",
484487
);
488+
MARKETING_VERSION = 0.1.0;
485489
OTHER_LDFLAGS = (
486490
"$(inherited)",
487491
"-framework",
488492
Variant,
489493
);
490-
PRODUCT_BUNDLE_IDENTIFIER = orgIdentifier.iosVariant;
494+
PRODUCT_BUNDLE_IDENTIFIER = org.comixedproject.iosVariant;
491495
PRODUCT_NAME = "$(TARGET_NAME)";
492496
SWIFT_VERSION = 5.0;
493497
TARGETED_DEVICE_FAMILY = "1,2";
@@ -497,7 +501,7 @@
497501
/* End XCBuildConfiguration section */
498502

499503
/* Begin XCConfigurationList section */
500-
7555FF76242A565900829871 /* Build configuration list for PBXProject "iosVariant" */ = {
504+
7555FF76242A565900829871 /* Build configuration list for PBXProject "Variant" */ = {
501505
isa = XCConfigurationList;
502506
buildConfigurations = (
503507
7555FFA3242A565B00829871 /* Debug */,
@@ -506,7 +510,7 @@
506510
defaultConfigurationIsVisible = 0;
507511
defaultConfigurationName = Release;
508512
};
509-
7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "iosVariant" */ = {
513+
7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "Variant" */ = {
510514
isa = XCConfigurationList;
511515
buildConfigurations = (
512516
7555FFA6242A565B00829871 /* Debug */,

‎iosVariant/Variant.xcodeproj/project.xcworkspace/contents.xcworkspacedata‎

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎iosVariant/Variant.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved‎

Lines changed: 33 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎iosVariant/iosVariant/Data/ImageLoader.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import KMPObservableViewModelSwiftUI
2020
import SwiftUI
21-
import Variant
21+
import shared
2222

2323
private let TAG = "ImageLoader"
2424

‎iosVariant/iosVariant/Data/KMPObservableViewModel.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
*/
1818

1919
import KMPObservableViewModelCore
20-
import Variant
20+
import shared
2121

2222
extension Kmp_observableviewmodel_coreViewModel: ViewModel { }

‎iosVariant/iosVariant/HomeView.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import KMPObservableViewModelSwiftUI
2020
import SwiftUI
21-
import Variant
21+
import shared
2222

2323
private let TAG = "HomeView"
2424

‎iosVariant/iosVariant/Koin.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* along with this program. If not, see <http://www.gnu.org/licenses>
1717
*/
1818

19-
import Variant
19+
import shared
2020

2121
final class Koin {
2222
private var core: Koin_coreKoin?

‎iosVariant/iosVariant/Models/DirectoryEntry.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* along with this program. If not, see <http://www.gnu.org/licenses>
1717
*/
1818

19-
import Variant
19+
import shared
2020

2121
extension DirectoryEntry : @retroactive Identifiable {
2222
public var id: String {

‎iosVariant/iosVariant/Testing/Fixtures.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* along with this program. If not, see <http://www.gnu.org/licenses>
1717
*/
1818

19-
import Variant
19+
import shared
2020

2121
public var DIRECTORY_LIST = [
2222
DirectoryEntry(

0 commit comments

Comments
 (0)