feat: Updated validation checks to ensure that only one of an element exists if allowMultiple: false

Author: kevinwang5658

src/plugin/plugin.test.ts

@@ -448,4 +448,47 @@ describe('Plugin tests', () => {
 
     console.log(match)
   })
+
+  it('Validates that a config correctly allows multiple of a config when allowMultiple is true', async () => {
+    const resource = spy(new class extends TestResource {
+      getSettings(): ResourceSettings<TestConfig> {
+        return {
+          id: 'ssh-config',
+          allowMultiple: true
+        }
+      }
+    })
+
+    const testPlugin = Plugin.create('testPlugin', [resource as any]);
+
+    const validate1 = await testPlugin.validate({
+      configs: [{ core: { type: 'ssh-config' }, parameters: { propA: 'a' } }, {
+        core: { type: 'ssh-config' },
+        parameters: { propB: 'b' }
+      }]
+    })
+
+    expect(validate1.resourceValidations.every((r) => r.isValid)).to.be.true;
+  })
+
+  it('Validates that a config correctly dis-allows multiple of a config when allowMultiple is false', async () => {
+    const resource = spy(new class extends TestResource {
+      getSettings(): ResourceSettings<TestConfig> {
+        return {
+          id: 'ssh-config',
+        }
+      }
+    })
+
+    const testPlugin = Plugin.create('testPlugin', [resource as any]);
+
+    const validate1 = await testPlugin.validate({
+      configs: [{ core: { type: 'ssh-config' }, parameters: { propA: 'a' } }, {
+        core: { type: 'ssh-config' },
+        parameters: { propB: 'b' }
+      }]
+    })
+
+    expect(validate1.resourceValidations.every((r) => r.isValid)).to.be.false;
+  })
 });

src/plugin/plugin.ts

@@ -145,7 +145,7 @@ export class Plugin {
   }
 
   async validate(data: ValidateRequestData): Promise<ValidateResponseData> {
-    const validationResults = [];
+    const validationResults: ValidateResponseData['resourceValidations'] = [];
     for (const config of data.configs) {
       const { core, parameters } = config;
 
@@ -160,6 +160,32 @@ export class Plugin {
       validationResults.push(validation);
     }
 
+    // Validate that if allow multiple is false, then only 1 of each resource exists
+    const countMap = data.configs.reduce((map, resource) => {
+      if (!map.has(resource.core.type)) {
+        map.set(resource.core.type, 0);
+      }
+
+      const count = map.get(resource.core.type)!;
+      map.set(resource.core.type, count + 1)
+
+      return map;
+    }, new Map<string, number>())
+
+    const invalidMultipleConfigs = [...countMap.entries()].filter(([k, v]) => {
+      const controller = this.resourceControllers.get(k)!;
+      return !controller.parsedSettings.allowMultiple && v > 1;
+    });
+
+    if (invalidMultipleConfigs.length > 0) {
+      validationResults.push(...invalidMultipleConfigs.map(([k, v]) => ({
+        resourceType: k,
+        schemaValidationErrors: [],
+        customValidationErrorMessage: `Multiple of resource type: ${k} found in configs. Only allowed 1.`,
+        isValid: false,
+      })));
+    }
+
     await this.crossValidateResources(data.configs);
     return {
       resourceValidations: validationResults