Skip to content

[UI][binaryPath] binaryPath stopped to be evaluated correctly after switching scope to machine #1032

Description

@gontarz

https://github.com/coder/vscode-coder/blame/e7ca50deaa6556f5242c53eeafe41b91220e48cd/package.json#L75

Configuration:

  • binaryPath declared to use already downloaded version
  • enableDownloads disabled to use already downloaded version

After release 1.14.6 evaluation of binaryPath variable seems to be broken. Scope for variable changed to "machine". Intention was clear in my understanding, to use local path from user or user-profile settings when connecting to remote coder workspace, yet vscode interprets scope instantly as remote and tries to locate binary directly on remote machine even before opening connection to remote machine. Still even if there will be file on remote machine at first connection to remote machine is required. Furthermore jumping from workspace into next workspace as through jumphost hard to day was it intention of extension when variable is read from remote machine. While extension is UI extension and binary lives purely on local machine it seems to be bug.
Fix which was already tested and looks to be compliant with sec-200 is to change scope of binaryPath variable (and presumably binaryDestination variable while is related) to "application".

Summary:

  • security hardening broke connection to remote while "enableDownloads" is disabled
  • patching variable binaryPath in package.json to "application" makes coder extension operational again

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions