no-mistakes(lint): restore vscode eslint config, clear resulting lint errors

Author: anvanster

vscode/.eslintrc.json

@@ -0,0 +1,68 @@
+// ESLint config for the VS Code extension, scoped to this package: the npm
+// package next door is plain CommonJS with its own conventions, so `root` stops
+// this from reaching it.
+//
+// The severities below are not a style opinion - each one is set to the level
+// at which the rule catches a real defect in THIS codebase, so that
+// `npm run lint` failing means something is actually wrong and is worth
+// blocking on. Rules that only fire on deliberate, already-idiomatic code are
+// turned off with the reason recorded rather than silenced case by case.
+{
+    "root": true,
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": 2022,
+        "sourceType": "module"
+    },
+    "plugins": ["@typescript-eslint"],
+    "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+    "env": {
+        "node": true,
+        "es2022": true
+    },
+    "ignorePatterns": ["out", "dist", "node_modules", "media", "webview"],
+    "rules": {
+        // The `_`-prefix convention this source already follows: a parameter
+        // named `_token` is one the VS Code API hands us and we deliberately do
+        // not read, and renaming it would lose which API slot it fills. An
+        // unprefixed unused binding is still an error, because that is the case
+        // where something was meant to be used and was not.
+        "@typescript-eslint/no-unused-vars": [
+            "error",
+            {
+                "argsIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "caughtErrorsIgnorePattern": "^_"
+            }
+        ],
+        // `vscode-languageclient` declares its request types as namespaces
+        // (`namespace Foo { export const type = new RequestType(...) }`) and
+        // src/views/graphPanel.ts follows that idiom for its own requests. The
+        // rule is correct in general and wrong for the one pattern our
+        // dependency prescribes.
+        "@typescript-eslint/no-namespace": "off",
+        // Warn, not error: `any` here is concentrated in the boundary code that
+        // talks to the untyped language-server protocol payloads. Each site is
+        // a real typing debt worth seeing, but none of them is a defect that
+        // should stop a build, and typing them properly is a change to the
+        // protocol surface rather than a lint fix.
+        "@typescript-eslint/no-explicit-any": "warn"
+    },
+    "overrides": [
+        {
+            // Test doubles stand in for the `vscode` API, whose shape they must
+            // match exactly - including the parameters a given test never
+            // reads and the wide types the real API declares. Enforcing either
+            // rule here would push the mocks away from the API they imitate.
+            "files": ["**/*.test.ts"],
+            "rules": {
+                "@typescript-eslint/no-explicit-any": "off",
+                "@typescript-eslint/no-unsafe-function-type": "off",
+                "@typescript-eslint/no-unused-vars": [
+                    "error",
+                    { "args": "none", "varsIgnorePattern": "^_" }
+                ]
+            }
+        }
+    ]
+}

vscode/src/ai/contextProvider.test.ts

@@ -3,7 +3,6 @@
 
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import {
-  setMock,
   reset,
   clearAllMocks,
 } from '@vsforge/shim';

vscode/src/ai/toolManager.test.ts

@@ -1,7 +1,7 @@
 // Copyright 2025-2026 Andrey Vasilevsky <anvanster@gmail.com>
 // SPDX-License-Identifier: Apache-2.0
 
-import { describe, it, expect, beforeEach, vi, Mock } from 'vitest';
+import { describe, it, expect, beforeEach, vi } from 'vitest';
 import {
     reset,
     clearAllMocks,

vscode/src/ai/toolManager.ts

@@ -688,7 +688,7 @@ export class CodeGraphToolManager {
 
                             try {
                                 references = await Promise.race([refPromise, timeoutPromise]);
-                            } catch (timeoutErr) {
+                            } catch {
                                 // Reference search timed out, continue without references
                                 console.log('[CodeGraph] Reference search timed out, returning partial results');
                             }

vscode/src/commands/index.test.ts

@@ -9,7 +9,6 @@ import {
   clearAllMocks,
 } from '@vsforge/shim';
 import {
-  mockActiveTextEditor,
   mockConfiguration,
   mockQuickPickSelection,
 } from '@vsforge/test';

vscode/src/commands/index.ts

@@ -94,7 +94,7 @@ export function registerCommands(
                 }
             };
             context.subscriptions.push(vscode.commands.registerCommand(commandId, wrapped));
-        } catch (error) {
+        } catch {
             console.warn(`Command ${commandId} already registered, skipping`);
         }
     };
@@ -240,7 +240,7 @@ export function registerCommands(
                         'CodeGraph: Use @codegraph in the chat to get code context. ' +
                         'Try: @codegraph explain this function'
                     );
-                } catch (error) {
+                } catch {
                     // Chat panel not available - show helpful message
                     vscode.window.showInformationMessage(
                         'CodeGraph provides AI context via:\n' +

vscode/src/engineDownload.ts

@@ -22,7 +22,7 @@ import * as vscode from 'vscode';
 // The canonical implementation lives with the npm package; esbuild follows the
 // path and inlines it into out/extension.js, so both JavaScript channels ship
 // the same code rather than two implementations that drift.
-// eslint-disable-next-line @typescript-eslint/no-var-requires
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 const fetchEngine = require('../../mcp-package/bin/fetch-engine.js');
 
 /** Where downloaded engines live, shared with the CLI and the JetBrains plugin. */

vscode/src/extension.test.ts

@@ -7,7 +7,6 @@ import {
   reset,
   getCalls,
   clearAllMocks,
-  vscode,
 } from '@vsforge/shim';
 import { mockConfiguration } from '@vsforge/test';
 

vscode/src/extension.ts

@@ -41,7 +41,6 @@ let lastExitSignal: string | null = null;
 const MAX_RAPID_CRASHES = 3;
 const RAPID_CRASH_WINDOW_MS = 60_000;
 let rapidCrashTimestamps: number[] = [];
-let crashLoopDetected = false;
 // Set true right before an intentional server stop (crash-loop give-up,
 // deactivate) so the onDidChangeState→Stopped that follows isn't logged
 // as a crash. Consume-once: the handler resets it after skipping.
@@ -468,7 +467,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
         else if (lower.includes('spawn')) errorHint = 'spawn_error';
         else {
             // Last resort: first 80 chars, strip anything that looks like a path
-            errorHint = errStr.substring(0, 80).replace(/[\/\\][^\s:]+/g, '<path>');
+            errorHint = errStr.substring(0, 80).replace(/[/\\][^\s:]+/g, '<path>');
         }
 
         reporter.activationServerStartResult({
@@ -518,7 +517,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
                 );
 
                 if (rapidCrashTimestamps.length >= MAX_RAPID_CRASHES) {
-                    crashLoopDetected = true;
                     expectedShutdown = true;
                     client.stop().catch(() => {});
                     vscode.window
@@ -531,7 +529,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
                         )
                         .then((choice) => {
                             if (choice === 'Retry') {
-                                crashLoopDetected = false;
                                 rapidCrashTimestamps = [];
                                 serverRestartCount = 0;
                                 client.start().catch(() => {});

vscode/src/telemetry/reporter.ts

@@ -29,7 +29,6 @@ import { PostHog } from 'posthog-node';
 
 import {
     type ActivationOutcome,
-    type CommandId,
     categorizeError,
     type ErrorCategory,
     type FirstIndexCta,
@@ -51,7 +50,6 @@ import {
     normalizeAntivirusKind,
     type ServerRestartReason,
     SETTINGS_SNAPSHOT_KEYS,
-    type ToolName,
     type TreeView,
 } from './allowlists';
 import {