fix: address review feedback — tmpdir_path cleanup, args crash, UnboundLocalError

- Delete tmpdir_path in cleanup_temporary_paths to prevent stale refs
- Use self.project_root instead of self.args.project_root (args can be None)
- Move read_text() before try block to prevent UnboundLocalError in finally

Author: KRRT7

.claude/rules/architecture.md

@@ -15,9 +15,15 @@ codeflash/
 ├── code_utils/             # Code parsing, git utilities
 ├── models/                 # Pydantic models and types
 ├── languages/              # Multi-language support (Python, JavaScript/TypeScript)
-│   └── python/
-│       ├── function_optimizer.py  # PythonFunctionOptimizer (Python-specific hooks)
-│       └── optimizer.py           # Python module preparation & AST resolution
+│   ├── code_replacer.py           # Language-agnostic code replacement
+│   ├── python/
+│   │   ├── function_optimizer.py  # PythonFunctionOptimizer subclass
+│   │   ├── optimizer.py           # Python module preparation & AST resolution
+│   │   └── normalizer.py          # Python code normalization for deduplication
+│   └── javascript/
+│       ├── function_optimizer.py  # JavaScriptFunctionOptimizer subclass
+│       ├── optimizer.py           # JS project root finding & module preparation
+│       └── normalizer.py          # JS/TS code normalization for deduplication
 ├── setup/                  # Config schema, auto-detection, first-run experience
 ├── picklepatch/            # Serialization/deserialization utilities
 ├── tracing/                # Function call tracing
@@ -35,10 +41,10 @@ codeflash/
 |------|------------|
 | CLI arguments & commands | `cli_cmds/cli.py` |
 | Optimization orchestration | `optimization/optimizer.py` → `run()` |
-| Per-function optimization | `optimization/function_optimizer.py` (base), `languages/python/function_optimizer.py` (Python subclass) |
+| Per-function optimization | `optimization/function_optimizer.py` (base), `languages/python/function_optimizer.py`, `languages/javascript/function_optimizer.py` |
 | Function discovery | `discovery/functions_to_optimize.py` |
 | Context extraction | `languages/<lang>/context/code_context_extractor.py` |
-| Test execution | `verification/test_runner.py`, `verification/pytest_plugin.py` |
+| Test execution | `languages/<lang>/support.py` (`run_behavioral_tests`, etc.), `verification/pytest_plugin.py` |
 | Performance ranking | `benchmarking/function_ranker.py` |
 | Domain types | `models/models.py`, `models/function_types.py` |
 | Result handling | `either.py` (`Result`, `Success`, `Failure`, `is_successful`) |

codeflash/languages/javascript/function_optimizer.py

@@ -146,7 +146,7 @@ def compare_candidate_results(
         candidate_sqlite = get_run_tmp_file(Path(f"test_return_values_{optimization_candidate_index}.sqlite"))
 
         if original_sqlite.exists() and candidate_sqlite.exists():
-            js_root = self.test_cfg.js_project_root or self.args.project_root
+            js_root = self.test_cfg.js_project_root or self.project_root
             match, diffs = self.language_support.compare_test_results(
                 original_sqlite, candidate_sqlite, project_root=js_root
             )
@@ -176,9 +176,9 @@ def line_profiler_step(
             logger.warning(f"Language support for {self.language_support.language} doesn't support line profiling")
             return {"timings": {}, "unit": 0, "str_out": ""}
 
+        original_source = Path(self.function_to_optimize.file_path).read_text()
         try:
             line_profiler_output_path = get_run_tmp_file(Path("line_profiler_output.json"))
-            original_source = Path(self.function_to_optimize.file_path).read_text()
 
             success = self.language_support.instrument_source_for_line_profiler(
                 func_info=self.function_to_optimize, line_profiler_output_file=line_profiler_output_path

codeflash/optimization/optimizer.py

@@ -652,6 +652,8 @@ def cleanup_temporary_paths(self) -> None:
         if hasattr(get_run_tmp_file, "tmpdir"):
             get_run_tmp_file.tmpdir.cleanup()
             del get_run_tmp_file.tmpdir
+        if hasattr(get_run_tmp_file, "tmpdir_path"):
+            del get_run_tmp_file.tmpdir_path
 
         # Always clean up concolic test directory
         cleanup_paths([self.test_cfg.concolic_test_root_dir])