Merge pull request #1708 from codeflash-ai/extract-js-optimizer

refactor: extract JavaScript Optimizer subclass

Author: KRRT7

.claude/rules/architecture.md

@@ -1,5 +1,7 @@
 # Architecture
 
+When adding, moving, or deleting source files, update this doc to match.
+
 ```
 codeflash/
 ├── main.py                 # CLI entry point
@@ -15,9 +17,20 @@ codeflash/
 ├── code_utils/             # Code parsing, git utilities
 ├── models/                 # Pydantic models and types
 ├── languages/              # Multi-language support (Python, JavaScript/TypeScript)
-│   └── python/
-│       ├── function_optimizer.py  # PythonFunctionOptimizer (Python-specific hooks)
-│       └── optimizer.py           # Python module preparation & AST resolution
+│   ├── base.py                    # LanguageSupport protocol and shared data types
+│   ├── registry.py                # Language registration and lookup by extension/enum
+│   ├── current.py                 # Current language singleton (set_current_language / current_language_support)
+│   ├── code_replacer.py           # Language-agnostic code replacement
+│   ├── python/
+│   │   ├── support.py             # PythonSupport (LanguageSupport implementation)
+│   │   ├── function_optimizer.py  # PythonFunctionOptimizer subclass
+│   │   ├── optimizer.py           # Python module preparation & AST resolution
+│   │   └── normalizer.py          # Python code normalization for deduplication
+│   └── javascript/
+│       ├── support.py             # JavaScriptSupport (LanguageSupport implementation)
+│       ├── function_optimizer.py  # JavaScriptFunctionOptimizer subclass
+│       ├── optimizer.py           # JS project root finding & module preparation
+│       └── normalizer.py          # JS/TS code normalization for deduplication
 ├── setup/                  # Config schema, auto-detection, first-run experience
 ├── picklepatch/            # Serialization/deserialization utilities
 ├── tracing/                # Function call tracing
@@ -35,10 +48,10 @@ codeflash/
 |------|------------|
 | CLI arguments & commands | `cli_cmds/cli.py` |
 | Optimization orchestration | `optimization/optimizer.py` → `run()` |
-| Per-function optimization | `optimization/function_optimizer.py` (base), `languages/python/function_optimizer.py` (Python subclass) |
+| Per-function optimization | `optimization/function_optimizer.py` (base), `languages/python/function_optimizer.py`, `languages/javascript/function_optimizer.py` |
 | Function discovery | `discovery/functions_to_optimize.py` |
 | Context extraction | `languages/<lang>/context/code_context_extractor.py` |
-| Test execution | `verification/test_runner.py`, `verification/pytest_plugin.py` |
+| Test execution | `languages/<lang>/support.py` (`run_behavioral_tests`, etc.), `verification/pytest_plugin.py` |
 | Performance ranking | `benchmarking/function_ranker.py` |
 | Domain types | `models/models.py`, `models/function_types.py` |
 | Result handling | `either.py` (`Result`, `Success`, `Failure`, `is_successful`) |

.claude/rules/code-style.md

@@ -7,4 +7,5 @@
 - **Comments**: Minimal - only explain "why", not "what"
 - **Docstrings**: Do not add unless explicitly requested
 - **Naming**: NEVER use leading underscores (`_function_name`) - Python has no true private functions, use public names
-- **Paths**: Always use absolute paths, handle encoding explicitly (UTF-8)
+- **Paths**: Always use absolute paths
+- **Encoding**: Always pass `encoding="utf-8"` to `open()`, `read_text()`, `write_text()`, etc. in new or changed code — Windows defaults to `cp1252` which breaks on non-ASCII content. Don't flag pre-existing code that lacks it unless you're already modifying that line.

.claude/rules/language-patterns.md

@@ -9,4 +9,5 @@ paths:
 - Use `get_language_support(identifier)` from `languages/registry.py` to get a `LanguageSupport` instance — never import language classes directly
 - New language support classes must use the `@register_language` decorator to register with the extension and language registries
 - `languages/__init__.py` uses `__getattr__` for lazy imports to avoid circular dependencies — follow this pattern when adding new exports
-- `is_javascript()` returns `True` for both JavaScript and TypeScript
+- Prefer `LanguageSupport` protocol dispatch over `is_python()`/`is_javascript()` guards — remaining guards are being migrated to protocol methods
+- `is_javascript()` returns `True` for both JavaScript and TypeScript (still used in ~15 call sites pending migration)

.claude/rules/optimization-patterns.md

@@ -3,7 +3,7 @@ paths:
   - "codeflash/optimization/**/*.py"
   - "codeflash/verification/**/*.py"
   - "codeflash/benchmarking/**/*.py"
-  - "codeflash/context/**/*.py"
+  - "codeflash/languages/*/context/**/*.py"
 ---
 
 # Optimization Pipeline Patterns

codeflash/code_utils/code_utils.py

@@ -408,9 +408,10 @@ def get_all_function_names(code: str) -> tuple[bool, list[str]]:
 def get_run_tmp_file(file_path: Path | str) -> Path:
     if isinstance(file_path, str):
         file_path = Path(file_path)
-    if not hasattr(get_run_tmp_file, "tmpdir"):
+    if not hasattr(get_run_tmp_file, "tmpdir_path"):
         get_run_tmp_file.tmpdir = TemporaryDirectory(prefix="codeflash_")
-    return Path(get_run_tmp_file.tmpdir.name) / file_path
+        get_run_tmp_file.tmpdir_path = Path(get_run_tmp_file.tmpdir.name)
+    return get_run_tmp_file.tmpdir_path / file_path
 
 
 def path_belongs_to_site_packages(file_path: Path) -> bool:

codeflash/code_utils/config_consts.py

@@ -6,6 +6,8 @@
 MAX_TEST_RUN_ITERATIONS = 5
 OPTIMIZATION_CONTEXT_TOKEN_LIMIT = 64000
 TESTGEN_CONTEXT_TOKEN_LIMIT = 64000
+READ_WRITABLE_LIMIT_ERROR = "Read-writable code has exceeded token limit, cannot proceed"
+TESTGEN_LIMIT_ERROR = "Testgen code context has exceeded token limit, cannot proceed"
 INDIVIDUAL_TESTCASE_TIMEOUT = 15
 MAX_FUNCTION_TEST_SECONDS = 60
 MIN_IMPROVEMENT_THRESHOLD = 0.05