Report aggregation executing before sub-modules

[yeroc]

Hi,

You've probably long-since moved on from this but just in case, do you have a working sample project? We tried using this plugin but discovered that in our multi-module setup the plugin ended up executing first because the top-level module executes first in the reactor. It looks like the current logic at Line 92 in src/main/java/org/codefilarete/maven/jacoco/ReportAggregateMojo.java:

  private boolean shouldDelayExecution() {                                                                                                                                                                                                                      
      return !session.getCurrentProject().isExecutionRoot();                                                                                                                                                                                                    
  }                                                                                                                                                                                                                                                             

Should be changed to something like:

  private boolean shouldDelayExecution() {                                                                                                                                                                                                                      
      List<MavenProject> projects = session.getProjects();                                                                                                                                                                                                      
      return session.getCurrentProject() != projects.get(projects.size() - 1);                                                                                                                                                                                  
  }

to ensure the aggregation executes with the last module in the build but I'm probably missing something.

[tircis]

Hi,
I'm glad to see that this plugin has some interest for other people than me ! :)

do you have a working sample project?

I had some working projects working with it, but they are no more accessible to me. The usage is quite simple : just replace what you would have done with the official Jacoco plugin by this one.

to ensure the aggregation executes with the last module in the build but I'm probably missing something.

The aggregation is made by the root module, not by the "last module". We must wait for all the submodules to be built and have their Jacoco file available to aggregate in a all-in-one file, that's why we test with isExecutionRoot()

From the fix you propose, I was wondering if you put the plugin only on the root module, or if you also added it to your submodules, which is not the way it works (not tested at all). If you use the plugin as expected, then I have to check your issue with a concrete example : can you provide the structure of your project ? maybe there's a particular thing that I missed.