feat(web): add Google onboarding completion page#403
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 28 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Adds the web page for completing pending Google onboarding sessions created by backend Google OAuth. The page reads the opaque session ID, fetches safe Google prefill data, collects Twizrr-required onboarding fields, and submits completion to the backend without exposing provider tokens or raw Google payloads.
Type of change
Area affected
How to test this
/register/google/complete?session=<valid-session-id>./auth/google/onboarding/:sessionId.Expected result: under-13 DOB is blocked client-side, valid completion calls
/auth/google/onboarding/:sessionId/complete, auth cookies are accepted from the backend response, and the user is redirected to the backend-provided destination.Pre-commit checklist
console.logleft in production code.envfiles committedanytypes addeddb pushScreenshots
N/A - focused auth form route; no visual redesign.
Notes for reviewer
Route added:
/register/google/completeFields collected:
firstNamelastNamedateOfBirthphonePrefill behavior:
providerEmail,providerEmailVerified, first/last/display name prefill, and provider avatar URL fromGET /auth/google/onboarding/:sessionId.Age-gate behavior:
Phone verification copy:
Redirect behavior:
redirectTo, falling back to/explore.Backend review follow-up:
auth.service.google.spec.tsso the one-time pending-session test first completes successfully, then retries the same session and verifiesGOOGLE_ONBOARDING_SESSION_EXPIREDafterredis.getDelreturns null.Validation:
cd apps/backend && pnpm.cmd test -- auth.service.google.spec.ts --runInBandpassed, 13/13cd apps/web && pnpm.cmd run lintpassedcd apps/web && npx.cmd tsc --noEmitpassedcd apps/web && pnpm.cmd run buildpassedgit diff --checkpassedgit diff --cached --checkpassed