Skip to content

Commit 9a04e63

Browse files
fix: Fix select_related usage
1 parent 974adcf commit 9a04e63

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

apps/codecov-api/core/admin.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -180,23 +180,21 @@ def get_search_results(
180180
https://docs.djangoproject.com/en/5.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_search_results
181181
"""
182182
# Default search is by name, author username, and service_id (defined in `search_fields`)
183-
queryset, may_have_duplicates = (
184-
super()
185-
.get_search_results(
186-
request,
187-
queryset,
188-
search_term,
189-
)
190-
.select_related("author")
183+
queryset, may_have_duplicates = super().get_search_results(
184+
request,
185+
queryset,
186+
search_term,
191187
)
188+
# Avoid N+1 queries for foreign key author
189+
queryset = queryset.select_related("author")
192190
# Also search by repoid if the search term is numeric
193191
try:
194192
search_term_as_int = int(search_term)
195193
except ValueError:
196194
pass
197195
else:
198196
queryset |= self.model.objects.filter(repoid=search_term_as_int)
199-
# avoid N+1 queries for foreign key author
197+
# avoid N+1 queries for with union
200198
queryset = queryset.select_related("author")
201199
return queryset, may_have_duplicates
202200

0 commit comments

Comments
 (0)