Skip to content

Bugfix Goodreads notes transformation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebude merged 2 commits into from
Jun 8, 2026
+3 −5
Merged

Bugfix Goodreads notes transformation #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6416053
Bugfix Goodreads notes transformation
codebude Jun 8, 2026
a0d427b
Prolong retention time of import files
codebude Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions backend/app/routers/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
BOOK_IMPORT_FIELDS,
PREDEFINED_MAPPINGS,
compute_schema_fingerprint,
delete_parsed_upload,
execute_import,
get_predefined_mapping,
load_parsed_upload,
Expand Down Expand Up @@ -323,8 +322,7 @@ async def event_generator():
final_error = 'error.importExecutionFailed'
yield f"data: {json.dumps({'event': 'error', 'message': 'error.importExecutionFailed'})}\n\n"
finally:
if completed and import_failed_rows == 0 and final_error is None:
delete_parsed_upload(body.file_id, current_user.id)
pass # import file is cleaned up by the periodic temp file job

return StreamingResponse(
event_generator(),
Expand Down
4 changes: 2 additions & 2 deletions backend/app/services/data_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ async def execute_import(
"tags": {"source": "Bookshelves", "transform": None},
"notes": {
"source": "My Review",
"transform": "value.replace('<br/>', '\n') if value else None",
"transform": "re.sub(r'<br\\s*/?>', '\\n', value, flags=re.IGNORECASE) if value else None",
},
"blurb": {"source": "", "transform": None},
"rating": {
Expand Down Expand Up @@ -885,7 +885,7 @@ def get_predefined_mapping(mapping_id: int) -> dict[str, object] | None:
return None


def cleanup_temp_files(max_age_hours: int = 24) -> None:
def cleanup_temp_files(max_age_hours: int = 48) -> None:
"""Delete temporary import files older than *max_age_hours*.

Args:
Expand Down
Loading