Conversation
- add books to did-not-finish from the recent dnf shelf on goodreads. - convert br to newlines on reviews.
Fix a couple of fields for the goodreads export mapping templates
Fix unique constraint on book table to set uniqueness over user_id and isbn
🧪 Test Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a significant change to ISBN uniqueness, making it enforced per user rather than globally, and migrates all documentation URLs and related configuration from the old GitHub Pages domain to the new custom domain
docs.librislog.app. It also improves test coverage for user data isolation, updates analytics and version check endpoints, and makes minor workflow and import improvements.Book ISBN uniqueness and user data isolation:
Bookmodel and database schema now enforce ISBN uniqueness per user instead of globally. This is achieved by adding a composite unique constraint on(user_id, isbn)and updating the migration logic to handle the transition both forwards and backwards. Error handling for unique constraint violations is updated accordingly. [1] [2] [3] [4]Documentation and site domain migration:
README.md, developer guides, and frontend/backend configs are updated to usehttps://docs.librislog.app/(and/next/for nightly docs) instead of the oldcodebude.github.io/librislogURLs. [1] [2] [3] [4] [5] [6]docs/.vitepress) is updated for the new domain, including analytics, base paths, and navigation links. [1] [2] [3]CNAMEfile to support the custom domain.Workflow and CI improvements:
issues: writepermission and only posts PR comments if the PR originates from the same repository, avoiding errors on forks. [1] [2]Import and data handling improvements: