Bug: send_monthly_attendance_reminder_emails has never worked

[mroderick]

The Issue

The method InvitationManager#send_monthly_attendance_reminder_emails (introduced in April 2016) has never actually sent any emails in 9+ years.

# app/models/invitation_manager.rb (original, broken)
def send_monthly_attendance_reminder_emails(monthly)
  invitees = Member.attending_meeting(monthly)
  invitees.each do |member|
    MeetingInvitationMailer.attendance_reminder(monthly, member)
    # ^^^^^^^^ Missing: .deliver_now or .deliver_later
  end
end

The mailer method is called but no delivery method is invoked. The mail object is instantiated and then discarded.

Additional Issue

The rake task reminders:meeting (which invokes this method) is NOT scheduled on Heroku Scheduler. Only these are scheduled:

• reminders:workshop
• feedback:request
• jobs:workoff

Impact

• The method has never worked in 9+ years of production
• Even if scheduled, the rake task won't send any emails
• This appears to be dead code

Questions

1. Should we fix it by adding .deliver_later (and schedule it)?
2. Or should we remove it entirely as unused/dead code?