Skip to content

Commit 184fac6

Browse files
committed
[Py] Updates excluded tests and expected failures in sendmail bridges
1 parent a77e71a commit 184fac6

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

rosetta-test-py/sendmail-python-emails.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,9 @@ def sendmail_error(env, result: SMTPResponse):
175175
# python-emails does not support attachments without a name
176176
"test_attachment_without_a_name",),
177177
exclude_capabilities=(
178-
"root.connection.lazy-connection", # TODO: python-emails does not handle failed auth correctly
178+
# python-emails does not close connections gracefully on failed auth
179+
# fixed in https://github.com/lavr/python-emails/pull/173
180+
"root.connection.lazy-connection",
179181
"root.connection.eager-connection",
180182
"root.general-crlf-injection.detection",
181183
"root.headers.crlf-injection.mitigation",
@@ -186,8 +188,9 @@ def sendmail_error(env, result: SMTPResponse):
186188
"test_non-ascii_content_in_send-message_with_8BITMIME_option_and_server_support", # 8bitmime is sent but body is not 8bitmime
187189
"test_Handle_421_at_start_of_data_command",
188190
"test_Handle_421_during_data_command",
189-
# The library should problably automatically detect whether smtputf8 is required
191+
# python-emails does does not support SMTPUTF8 on its own
190192
"test_international_sender_mailbox_in_send-message_with_SMTPUTF8_support",
191193
"test_international_recipient_mailbox_in_send-message_with_SMTPUTF8_support",
192194
"test_Send_a_message_with_empty_recipient",
193-
"test_set_header_with_unicode_value")) # Encoding of unicode in header value seems wrong (underscore instead of space)
195+
# python-emails also encodes the body when a header field is unicode
196+
"test_set_header_field_with_unicode_value"))

rosetta-test-py/sendmail-redmail.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,10 @@ def sendmail_error(env, result):
183183
"test_multiple_attachments_with_same_name",
184184

185185
"test_CRLF_detection_in_send-message_recipient",
186-
"test_CRLF_mitigation_in_send-message_sender",
187-
"test_Connect_with_invalid_credentials"), # TODO redmail leaks sockets when credentials are invalid
186+
"test_CRLF_mitigation_in_send-message_sender",),
187+
188+
# redmail leaks sockets when credentials are invalid
189+
#"test_Connect_with_invalid_credentials"),
188190
exclude_capabilities=(
189191
"root.unicode-messages.8bitmime.automatic-detection",
190192
"root.unicode-messages.8bitmime.mandatory-options",

0 commit comments

Comments
 (0)