Skip to content

Commit 1a8972c

Browse files
authored
Merge pull request #861 from code0-tech/fix-flow-updates
Fix problems with flow updates
2 parents c753785 + 043fca2 commit 1a8972c

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

app/models/node_parameter.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,5 @@ def only_one_value_present
4040

4141
def destroy_value_objects
4242
reference_value.destroy if reference_value.present?
43-
function_value.destroy if function_value.present?
4443
end
4544
end

app/services/namespaces/projects/flows/update_service.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def update_settings(t)
6060
flow_setting = flow.flow_settings.find_or_initialize_by(flow_setting_id: setting.flow_setting_identifier)
6161
flow_setting.object = setting.value
6262

63-
next if flow_setting.valid?
63+
next if flow_setting.save
6464

6565
t.rollback_and_return! ServiceResponse.error(
6666
message: 'Invalid flow settings',
@@ -198,6 +198,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
198198
db_parameters[index].function_value = node[:node]
199199
else
200200
db_parameters[index].function_value&.destroy
201+
db_parameters[index].function_value = nil
201202
end
202203

203204
if parameter.value.reference_value.present?
@@ -228,6 +229,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
228229
)
229230
else
230231
db_parameters[index].reference_value&.destroy
232+
db_parameters[index].reference_value = nil
231233
end
232234

233235
next if db_parameters[index].valid?

0 commit comments

Comments
 (0)