Skip to content

Commit afe093f

Browse files
authored
fix(FilterBar): reduce padded space between filter header and first filter (apache#38646)
Signed-off-by: hainenber <dotronghai96@gmail.com>
1 parent cc066b3 commit afe093f

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const TitleArea = styled.div`
3333
justify-content: space-between;
3434
margin: 0;
3535
padding: 0 ${theme.sizeUnit * 2}px ${theme.sizeUnit * 2}px;
36+
padding-bottom: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
3637
3738
& > span {
3839
font-size: ${theme.fontSizeLG}px;
@@ -56,9 +57,8 @@ const HeaderButton = styled(Button)`
5657

5758
const Wrapper = styled.div`
5859
${({ theme }) => `
59-
padding: ${theme.sizeUnit * 3}px ${theme.sizeUnit * 2}px ${
60-
theme.sizeUnit
61-
}px;
60+
padding: ${theme.sizeUnit * 3}px ${theme.sizeUnit * 2}px;
61+
padding-bottom: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
6262
`}
6363
`;
6464

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ const FilterControlsWrapper = styled.div`
119119
flex-direction: column;
120120
gap: ${theme.sizeUnit * 2}px;
121121
padding: ${theme.sizeUnit * 4}px;
122+
padding-top: 0; /* Works with other changes in PR https://github.com/apache/superset/pull/38646 to reduces space between filter header and 1st filter */
122123
// 108px padding to make room for buttons with position: absolute
123124
padding-bottom: ${theme.sizeUnit * 27}px;
124125
`}

0 commit comments

Comments
 (0)