fix: Forwarding messages to channels with join code (RocketChat#39541)

Author: KevLehman

.changeset/new-students-attack.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixes an issue when forwarding messages to a password-protected room.

apps/meteor/app/lib/server/functions/getRoomByNameOrIdWithOptionToJoin.ts

@@ -1,6 +1,6 @@
 import { Room } from '@rocket.chat/core-services';
 import type { IRoom, IUser, RoomType } from '@rocket.chat/core-typings';
-import { Rooms, Users } from '@rocket.chat/models';
+import { Rooms, Subscriptions, Users } from '@rocket.chat/models';
 import { Meteor } from 'meteor/meteor';
 
 import { isObject } from '../../../../lib/utils/isObject';
@@ -88,7 +88,10 @@ export const getRoomByNameOrIdWithOptionToJoin = async ({
 	// If the room type is channel and joinChannel has been passed, try to join them
 	// if they can't join the room, this will error out!
 	if (room.t === 'c' && joinChannel) {
-		await Room.join({ room, user });
+		const sub = await Subscriptions.findOneByRoomIdAndUserId(room._id, user._id, { projection: { _id: 1 } });
+		if (!sub) {
+			await Room.join({ room, user });
+		}
 	}
 
 	return room;

apps/meteor/tests/end-to-end/api/chat.ts

@@ -28,14 +28,32 @@ const pinMessage = ({ msgId }: { msgId: IMessage['_id'] }) => {
 describe('[Chat]', () => {
 	let testChannel: IRoom;
 	let message: { _id: IMessage['_id'] };
+	let protectedChannel: IRoom;
 
 	before((done) => getCredentials(done));
 
 	before(async () => {
 		testChannel = (await createRoom({ type: 'c', name: `chat.api-test-${Date.now()}` })).body.channel;
+		protectedChannel = (await createRoom({ type: 'c', name: `chat.api-protected-test-${Date.now()}` })).body.channel;
+
+		await request
+			.post(api('rooms.saveRoomSettings'))
+			.set(credentials)
+			.send({
+				rid: protectedChannel._id,
+				joinCode: 'super-secret-password',
+			})
+			.expect('Content-Type', 'application/json')
+			.expect(200)
+			.expect((res) => {
+				expect(res.body).to.have.property('success', true);
+			});
 	});
 
-	after(() => deleteRoom({ type: 'c', roomId: testChannel._id }));
+	after(async () => {
+		await deleteRoom({ type: 'c', roomId: testChannel._id });
+		await deleteRoom({ type: 'c', roomId: protectedChannel._id });
+	});
 
 	describe('/chat.postMessage', () => {
 		it('should throw an error when at least one of required parameters(channel, roomId) is not sent', (done) => {
@@ -586,6 +604,34 @@ describe('[Chat]', () => {
 				.end(done);
 		});
 
+		it('should allow forwarding a message into the same password protected room', async () => {
+			const postResponse = await request
+				.post(api('chat.postMessage'))
+				.set(credentials)
+				.send({
+					roomId: [protectedChannel._id],
+					text: 'Message to be forwarded',
+				})
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(postResponse.body).to.have.property('success', true);
+			const originalMessageId = postResponse.body.message._id as IMessage['_id'];
+
+			const forwardResponse = await request
+				.post(api('chat.postMessage'))
+				.set(credentials)
+				.send({
+					roomId: [protectedChannel._id],
+					text: `[](http://localhost:3000/channel/${protectedChannel.name}?msg=${originalMessageId}`,
+				})
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(forwardResponse.body).to.have.property('success', true);
+			expect(forwardResponse.body).to.have.nested.property('message.rid', protectedChannel._id);
+		});
+
 		it('should return statusCode 200 when postMessage successfully', (done) => {
 			void request
 				.post(api('chat.postMessage'))