From 2a6ffb34a513da1e4dd791a86da8a95fef4914c7 Mon Sep 17 00:00:00 2001 From: Peter Evans Date: Thu, 26 Feb 2026 07:25:00 +0000 Subject: [PATCH] Ensure that our changelog links for github and gitlab go to the correct issue pages. The gitlab URI structure has a hyphen in it. (#4869) --- changelog/src/changelog_entry.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/changelog/src/changelog_entry.py b/changelog/src/changelog_entry.py index 2187b52f7e..bd138f9111 100644 --- a/changelog/src/changelog_entry.py +++ b/changelog/src/changelog_entry.py @@ -44,8 +44,10 @@ def get_markdown_string( string = f"* {message}" if issue_number is not None: - url_prefix = GITLAB_URL if issue_origin == "gitlab" else GITHUB_URL - string += f" [#{issue_number}]({url_prefix}/-/issues/{issue_number})" + if issue_origin == "github": + string += f" [#{issue_number}]({GITHUB_URL}/issues/{issue_number})" + elif issue_origin == "gitlab": + string += f" [#{issue_number}]({GITLAB_URL}/-/issues/{issue_number})" return string