Skip to content

Commit f7d37f7

Browse files
authored
Fix builder settings modal menu highlighting (baserow#4750)
1 parent 40ab8d0 commit f7d37f7

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

web-frontend/modules/automation/components/settings/AutomationSettingsModal.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
<li v-for="setting in registeredSettings" :key="setting.getType()">
1818
<a
1919
class="modal-sidebar__nav-link"
20-
:class="{ active: setting === settingSelected }"
20+
:class="{
21+
active:
22+
settingSelected &&
23+
setting.getType() === settingSelected.getType(),
24+
}"
2125
@click="settingSelected = setting"
2226
>
2327
<i class="modal-sidebar__nav-icon" :class="setting.icon"></i>

web-frontend/modules/builder/components/settings/BuilderSettingsModal.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
<a
1717
v-tooltip="setting.isDeactivatedReason({ workspace }) || null"
1818
class="modal-sidebar__nav-link"
19-
:class="{ active: setting === settingSelected }"
19+
:class="{
20+
active:
21+
settingSelected &&
22+
setting.getType() === settingSelected.getType(),
23+
}"
2024
@click="onClick(setting)"
2125
>
2226
<i class="modal-sidebar__nav-icon" :class="setting.icon"></i>

0 commit comments

Comments
 (0)